return error instead of assertion when hostname is

empty in cf_engine/dns_service_resolver
pull/35353/head
yijiem 1 year ago
parent 85cede5967
commit f84d29a9db
  1. 9
      src/core/lib/event_engine/cf_engine/dns_service_resolver.cc

@ -50,7 +50,14 @@ void DNSServiceResolverImpl::LookupHostname(
});
return;
}
GPR_ASSERT(!host.empty());
if (host.empty()) {
engine_->Run([on_resolve = std::move(on_resolve),
status = absl::InvalidArgumentError(absl::StrCat(
"host must not be empty in name: ", name))]() mutable {
on_resolve(status);
});
return;
}
if (port_string.empty()) {
if (default_port.empty()) {
engine_->Run([on_resolve = std::move(on_resolve),

Loading…
Cancel
Save