Merge pull request #17888 from xichengliudui/updatefiles

Fix various typos in .cc and .md files
pull/17958/head
Jan Tattermusch 6 years ago committed by GitHub
commit f83fbe95b4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      src/core/ext/filters/max_age/max_age_filter.cc
  2. 2
      summerofcode/2018/naresh.md
  3. 2
      test/cpp/end2end/channelz_service_test.cc
  4. 2
      test/cpp/util/channel_trace_proto_helper.cc

@ -106,7 +106,7 @@ struct channel_data {
+--------------------------------+----------------+---------+ +--------------------------------+----------------+---------+
MAX_IDLE_STATE_INIT: The initial and final state of 'idle_state'. The MAX_IDLE_STATE_INIT: The initial and final state of 'idle_state'. The
channel has 1 or 1+ active calls, and the the timer is not set. Note that channel has 1 or 1+ active calls, and the timer is not set. Note that
we may put a virtual call to hold this state at channel initialization or we may put a virtual call to hold this state at channel initialization or
shutdown, so that the channel won't enter other states. shutdown, so that the channel won't enter other states.

@ -128,7 +128,7 @@ bazel test --spawn_strategy=standalone --genrule_strategy=standalone //src/pytho
- Use `bazel build` with a `-s` flag to see the logs being printed out to - Use `bazel build` with a `-s` flag to see the logs being printed out to
standard output while building. standard output while building.
- Similarly, use `bazel test` with a `--test_output=streamed` to see the the - Similarly, use `bazel test` with a `--test_output=streamed` to see the
test logs while testing. Something to know while using this flag is that all test logs while testing. Something to know while using this flag is that all
tests will be run locally, without sharding, one at a time. tests will be run locally, without sharding, one at a time.

@ -708,7 +708,7 @@ TEST_F(ChannelzServerTest, GetServerSocketsPaginationTest) {
get_server_sockets_request, get_server_sockets_request,
&get_server_sockets_response); &get_server_sockets_response);
EXPECT_TRUE(s.ok()) << "s.error_message() = " << s.error_message(); EXPECT_TRUE(s.ok()) << "s.error_message() = " << s.error_message();
// We add one to account the the channelz stub that will end up creating // We add one to account the channelz stub that will end up creating
// a serversocket. // a serversocket.
EXPECT_EQ(get_server_sockets_response.socket_ref_size(), EXPECT_EQ(get_server_sockets_response.socket_ref_size(),
kNumServerSocketsCreated + 1); kNumServerSocketsCreated + 1);

@ -55,7 +55,7 @@ void VaidateProtoJsonTranslation(char* json_c_str) {
// print_options.always_print_primitive_fields = true; // print_options.always_print_primitive_fields = true;
s = grpc::protobuf::json::MessageToJsonString(msg, &proto_json_str); s = grpc::protobuf::json::MessageToJsonString(msg, &proto_json_str);
EXPECT_TRUE(s.ok()); EXPECT_TRUE(s.ok());
// uncomment these to compare the the json strings. // uncomment these to compare the json strings.
// gpr_log(GPR_ERROR, "tracer json: %s", json_str.c_str()); // gpr_log(GPR_ERROR, "tracer json: %s", json_str.c_str());
// gpr_log(GPR_ERROR, "proto json: %s", proto_json_str.c_str()); // gpr_log(GPR_ERROR, "proto json: %s", proto_json_str.c_str());
EXPECT_EQ(json_str, proto_json_str); EXPECT_EQ(json_str, proto_json_str);

Loading…
Cancel
Save