Merge branch 'master' into tjagtap_src_core_lib_gprpp

pull/36468/head
tanvi-jagtap 10 months ago
commit f7ed931db1
  1. 25
      BUILD
  2. 16
      src/core/BUILD
  3. 18
      src/core/ext/transport/binder/client/binder_connector.cc
  4. 17
      src/core/ext/transport/binder/client/channel_create.cc
  5. 6
      src/core/ext/transport/binder/client/channel_create_impl.cc
  6. 3
      src/core/ext/transport/binder/client/connection_id_generator.cc
  7. 12
      src/core/ext/transport/binder/client/endpoint_binder_pool.cc
  8. 4
      src/core/ext/transport/binder/client/jni_utils.cc
  9. 6
      src/core/ext/transport/binder/client/security_policy_setting.cc
  10. 12
      src/core/ext/transport/binder/security_policy/binder_security_policy.cc
  11. 3
      src/core/ext/transport/binder/server/binder_server.cc
  12. 4
      src/core/ext/transport/binder/server/binder_server_credentials.cc
  13. 33
      src/core/ext/transport/binder/transport/binder_transport.cc
  14. 3
      src/core/ext/transport/binder/transport/binder_transport.h
  15. 6
      src/core/ext/transport/binder/utils/ndk_binder.cc
  16. 8
      src/core/ext/transport/binder/utils/transport_stream_receiver_impl.cc
  17. 3
      src/core/ext/transport/binder/wire_format/binder_android.cc
  18. 21
      src/core/ext/transport/binder/wire_format/transaction.h
  19. 9
      src/core/ext/transport/binder/wire_format/wire_reader_impl.cc
  20. 15
      src/core/ext/transport/binder/wire_format/wire_writer.cc
  21. 4
      src/core/ext/transport/chttp2/alpn/alpn.cc
  22. 15
      src/core/ext/transport/chttp2/client/chttp2_connector.cc
  23. 9
      src/core/ext/transport/chttp2/server/chttp2_server.cc
  24. 9
      src/core/ext/transport/chttp2/transport/bin_decoder.cc
  25. 12
      src/core/ext/transport/chttp2/transport/bin_encoder.cc
  26. 102
      src/core/ext/transport/chttp2/transport/chttp2_transport.cc
  27. 5
      src/core/ext/transport/chttp2/transport/flow_control.cc
  28. 5
      src/core/ext/transport/chttp2/transport/flow_control.h
  29. 5
      src/core/ext/transport/chttp2/transport/frame.cc
  30. 3
      src/core/ext/transport/chttp2/transport/frame_data.cc
  31. 7
      src/core/ext/transport/chttp2/transport/frame_goaway.cc
  32. 3
      src/core/ext/transport/chttp2/transport/frame_ping.cc
  33. 3
      src/core/ext/transport/chttp2/transport/frame_rst_stream.cc
  34. 5
      src/core/ext/transport/chttp2/transport/frame_window_update.cc
  35. 4
      src/core/ext/transport/chttp2/transport/hpack_encoder.cc
  36. 16
      src/core/ext/transport/chttp2/transport/hpack_encoder_table.cc
  37. 3
      src/core/ext/transport/chttp2/transport/hpack_parse_result.cc
  38. 3
      src/core/ext/transport/chttp2/transport/hpack_parse_result.h
  39. 45
      src/core/ext/transport/chttp2/transport/hpack_parser.cc
  40. 7
      src/core/ext/transport/chttp2/transport/hpack_parser_table.cc
  41. 4
      src/core/ext/transport/chttp2/transport/max_concurrent_streams_policy.cc
  42. 23
      src/core/ext/transport/chttp2/transport/parsing.cc
  43. 3
      src/core/ext/transport/chttp2/transport/ping_callbacks.cc
  44. 12
      src/core/ext/transport/chttp2/transport/stream_lists.cc
  45. 4
      src/core/ext/transport/chttp2/transport/varint.h
  46. 4
      src/core/ext/transport/chttp2/transport/write_size_policy.cc
  47. 5
      src/core/ext/transport/chttp2/transport/writing.cc
  48. 72
      src/core/tsi/alts/handshaker/alts_handshaker_client.cc
  49. 6
      src/core/tsi/alts/handshaker/alts_shared_resource.cc
  50. 38
      src/core/tsi/alts/handshaker/alts_tsi_handshaker.cc
  51. 6
      src/core/tsi/alts/handshaker/alts_tsi_utils.cc
  52. 6
      src/core/tsi/alts/zero_copy_frame_protector/alts_grpc_integrity_only_record_protocol.cc
  53. 11
      src/core/tsi/alts/zero_copy_frame_protector/alts_grpc_record_protocol_common.cc
  54. 6
      src/core/tsi/alts/zero_copy_frame_protector/alts_zero_copy_grpc_protector.cc
  55. 7
      src/core/tsi/fake_transport_security.cc
  56. 8
      src/core/tsi/ssl/key_logging/ssl_key_logging.cc
  57. 18
      src/core/tsi/ssl/session_cache/ssl_session_cache.cc
  58. 6
      src/core/tsi/ssl/session_cache/ssl_session_openssl.cc
  59. 35
      src/core/tsi/ssl_transport_security.cc
  60. 17
      src/core/tsi/ssl_transport_security_utils.cc

25
BUILD

@ -1133,6 +1133,7 @@ grpc_cc_library(
"absl/container:flat_hash_map",
"absl/functional:any_invocable",
"absl/hash",
"absl/log:check",
"absl/memory",
"absl/meta:type_traits",
"absl/status",
@ -3960,6 +3961,9 @@ grpc_cc_library(
hdrs = [
"//src/core:tsi/fake_transport_security.h",
],
external_deps = [
"absl/log:check",
],
language = "c++",
visibility = [
"@grpc:public",
@ -4077,6 +4081,7 @@ grpc_cc_library(
"//src/core:tsi/alts/handshaker/alts_tsi_utils.h",
],
external_deps = [
"absl/log:check",
"absl/strings",
"@com_google_protobuf//upb:base",
"@com_google_protobuf//upb:mem",
@ -4136,6 +4141,7 @@ grpc_cc_library(
"//src/core:tsi/alts/zero_copy_frame_protector/alts_zero_copy_grpc_protector.h",
],
external_deps = [
"absl/log:check",
"absl/types:span",
"libcrypto",
"libssl",
@ -4166,6 +4172,7 @@ grpc_cc_library(
"//src/core:tsi/ssl/session_cache/ssl_session_cache.h",
],
external_deps = [
"absl/log:check",
"absl/memory",
"libssl",
],
@ -4449,6 +4456,7 @@ grpc_cc_library(
"//src/core:ext/transport/chttp2/transport/frame.h",
],
external_deps = [
"absl/log:check",
"absl/status",
"absl/status:statusor",
"absl/strings",
@ -4494,6 +4502,7 @@ grpc_cc_library(
],
external_deps = [
"absl/functional:function_ref",
"absl/log:check",
"absl/status",
"absl/strings",
],
@ -4520,6 +4529,7 @@ grpc_cc_library(
"//src/core:ext/transport/chttp2/transport/hpack_parse_result.h",
],
external_deps = [
"absl/log:check",
"absl/status",
"absl/strings",
"absl/strings:str_format",
@ -4548,6 +4558,7 @@ grpc_cc_library(
],
external_deps = [
"absl/base:core_headers",
"absl/log:check",
"absl/random:bit_gen_ref",
"absl/status",
"absl/strings",
@ -4588,7 +4599,10 @@ grpc_cc_library(
hdrs = [
"//src/core:ext/transport/chttp2/transport/hpack_encoder.h",
],
external_deps = ["absl/strings"],
external_deps = [
"absl/log:check",
"absl/strings",
],
deps = [
"chttp2_bin_encoder",
"chttp2_legacy_frame",
@ -4618,6 +4632,9 @@ grpc_cc_library(
hdrs = [
"//src/core:ext/transport/chttp2/transport/bin_encoder.h",
],
external_deps = [
"absl/log:check",
],
deps = [
"gpr",
"gpr_platform",
@ -4634,7 +4651,10 @@ grpc_cc_library(
hdrs = [
"//src/core:ext/transport/chttp2/transport/varint.h",
],
external_deps = ["absl/base:core_headers"],
external_deps = [
"absl/base:core_headers",
"absl/log:check",
],
deps = ["gpr"],
)
@ -4693,6 +4713,7 @@ grpc_cc_library(
"absl/base:core_headers",
"absl/container:flat_hash_map",
"absl/hash",
"absl/log:check",
"absl/meta:type_traits",
"absl/random",
"absl/random:bit_gen_ref",

@ -6606,6 +6606,9 @@ grpc_cc_library(
hdrs = [
"ext/transport/chttp2/transport/hpack_encoder_table.h",
],
external_deps = [
"absl/log:check",
],
language = "c++",
deps = [
"hpack_constants",
@ -6623,6 +6626,7 @@ grpc_cc_library(
],
external_deps = [
"absl/functional:function_ref",
"absl/log:check",
"absl/status",
"absl/strings",
"absl/strings:str_format",
@ -6672,6 +6676,7 @@ grpc_cc_library(
"absl/container:flat_hash_map",
"absl/functional:any_invocable",
"absl/hash",
"absl/log:check",
"absl/meta:type_traits",
"absl/random:bit_gen_ref",
"absl/random:distributions",
@ -6694,6 +6699,9 @@ grpc_cc_library(
hdrs = [
"ext/transport/chttp2/transport/write_size_policy.h",
],
external_deps = [
"absl/log:check",
],
deps = [
"time",
"//:gpr",
@ -6732,6 +6740,9 @@ grpc_cc_library(
hdrs = [
"ext/transport/chttp2/transport/max_concurrent_streams_policy.h",
],
external_deps = [
"absl/log:check",
],
deps = [
"//:gpr",
"//:gpr_platform",
@ -6789,6 +6800,9 @@ grpc_cc_library(
hdrs = [
"ext/transport/chttp2/alpn/alpn.h",
],
external_deps = [
"absl/log:check",
],
language = "c++",
deps = [
"useful",
@ -6806,6 +6820,7 @@ grpc_cc_library(
],
external_deps = [
"absl/base:core_headers",
"absl/log:check",
"absl/status",
"absl/status:statusor",
"absl/strings:str_format",
@ -6862,6 +6877,7 @@ grpc_cc_library(
],
external_deps = [
"absl/base:core_headers",
"absl/log:check",
"absl/status",
"absl/status:statusor",
"absl/strings",

@ -33,6 +33,8 @@
#include <functional>
#include <map>
#include "absl/log/check.h"
#include <grpcpp/security/binder_security_policy.h>
#include "src/core/client_channel/connector.h"
@ -60,21 +62,21 @@ class BinderConnector : public grpc_core::SubchannelConnector {
size_t id_length = args.address->len - sizeof(un->sun_family);
// The c-style string at least will have a null terminator, and the
// connection id itself should not be empty
GPR_ASSERT(id_length >= 2);
CHECK_GE(id_length, 2u);
// Make sure there is null terminator at the expected location before
// reading from it
GPR_ASSERT(un->sun_path[id_length - 1] == '\0');
CHECK_EQ(un->sun_path[id_length - 1], '\0');
conn_id_ = un->sun_path;
}
#else
GPR_ASSERT(0);
CHECK(0);
#endif
gpr_log(GPR_INFO, "BinderConnector %p conn_id_ = %s", this,
conn_id_.c_str());
args_ = args;
GPR_ASSERT(notify_ == nullptr);
GPR_ASSERT(notify != nullptr);
CHECK_EQ(notify_, nullptr);
CHECK_NE(notify, nullptr);
notify_ = notify;
result_ = result;
@ -86,15 +88,15 @@ class BinderConnector : public grpc_core::SubchannelConnector {
}
void OnConnected(std::unique_ptr<grpc_binder::Binder> endpoint_binder) {
GPR_ASSERT(endpoint_binder != nullptr);
CHECK(endpoint_binder != nullptr);
grpc_core::Transport* transport = grpc_create_binder_transport_client(
std::move(endpoint_binder),
grpc_binder::GetSecurityPolicySetting()->Get(conn_id_));
GPR_ASSERT(transport != nullptr);
CHECK_NE(transport, nullptr);
result_->channel_args = args_.channel_args;
result_->transport = transport;
GPR_ASSERT(notify_ != nullptr);
CHECK_NE(notify_, nullptr);
// ExecCtx is required here for running grpc_closure because this callback
// might be invoked from non-gRPC code
if (grpc_core::ExecCtx::Get() == nullptr) {

@ -34,6 +34,7 @@
#ifdef GPR_SUPPORT_BINDER_TRANSPORT
#include "absl/log/check.h"
#include "absl/memory/memory.h"
#include "absl/strings/substitute.h"
#include "absl/time/clock.h"
@ -102,8 +103,8 @@ std::shared_ptr<grpc::Channel> CreateCustomBinderChannel(
const ChannelArguments& args) {
grpc_init();
GPR_ASSERT(jni_env_void != nullptr);
GPR_ASSERT(security_policy != nullptr);
CHECK_NE(jni_env_void, nullptr);
CHECK_NE(security_policy, nullptr);
// Generate an unique connection ID that identifies this connection (Useful
// for mapping connection between Java and C++ code).
@ -163,7 +164,7 @@ std::shared_ptr<grpc::Channel> CreateBinderChannel(
"This APK is compiled with Android API level = %d, which is not "
"supported. See port_platform.h for supported versions.",
__ANDROID_API__);
GPR_ASSERT(0);
CHECK(0);
return {};
}
@ -175,7 +176,7 @@ std::shared_ptr<grpc::Channel> CreateCustomBinderChannel(
"This APK is compiled with Android API level = %d, which is not "
"supported. See port_platform.h for supported versions.",
__ANDROID_API__);
GPR_ASSERT(0);
CHECK(0);
return {};
}
@ -186,7 +187,7 @@ std::shared_ptr<grpc::Channel> CreateBinderChannel(
"This APK is compiled with Android API level = %d, which is not "
"supported. See port_platform.h for supported versions.",
__ANDROID_API__);
GPR_ASSERT(0);
CHECK(0);
return {};
}
@ -198,7 +199,7 @@ std::shared_ptr<grpc::Channel> CreateCustomBinderChannel(
"This APK is compiled with Android API level = %d, which is not "
"supported. See port_platform.h for supported versions.",
__ANDROID_API__);
GPR_ASSERT(0);
CHECK(0);
return {};
}
@ -207,7 +208,7 @@ bool InitializeBinderChannelJavaClass(void* jni_env_void) {
"This APK is compiled with Android API level = %d, which is not "
"supported. See port_platform.h for supported versions.",
__ANDROID_API__);
GPR_ASSERT(0);
CHECK(0);
return {};
}
@ -217,7 +218,7 @@ bool InitializeBinderChannelJavaClass(
"This APK is compiled with Android API level = %d, which is not "
"supported. See port_platform.h for supported versions.",
__ANDROID_API__);
GPR_ASSERT(0);
CHECK(0);
return {};
}

@ -21,6 +21,8 @@
#include <memory>
#include <utility>
#include "absl/log/check.h"
#include "src/core/ext/transport/binder/client/binder_connector.h"
#include "src/core/ext/transport/binder/transport/binder_transport.h"
#include "src/core/ext/transport/binder/wire_format/binder.h"
@ -50,7 +52,7 @@ grpc_channel* CreateDirectBinderChannelImplForTesting(
grpc_core::Transport* transport = grpc_create_binder_transport_client(
std::move(endpoint_binder), security_policy);
GPR_ASSERT(transport != nullptr);
CHECK_NE(transport, nullptr);
auto channel_args = grpc_core::CoreConfiguration::Get()
.channel_args_preconditioning()
@ -60,7 +62,7 @@ grpc_channel* CreateDirectBinderChannelImplForTesting(
grpc_core::ChannelCreate("binder_target_placeholder", channel_args,
GRPC_CLIENT_DIRECT_CHANNEL, transport);
// TODO(mingcl): Handle error properly
GPR_ASSERT(channel.ok());
CHECK(channel.ok());
grpc_channel_args_destroy(args);
return channel->release()->c_ptr();
}

@ -18,6 +18,7 @@
#ifndef GRPC_NO_BINDER
#include "absl/log/check.h"
#include "absl/strings/str_cat.h"
namespace {
@ -55,7 +56,7 @@ std::string ConnectionIdGenerator::Generate(absl::string_view uri) {
// Insert a hyphen before serial number
ret = absl::StrCat(s, "-", ++count_);
}
GPR_ASSERT(ret.length() < kPathLengthLimit);
CHECK_LT(ret.length(), kPathLengthLimit);
return ret;
}

@ -14,6 +14,8 @@
#include "src/core/ext/transport/binder/client/endpoint_binder_pool.h"
#include "absl/log/check.h"
#include <grpc/support/port_platform.h>
#ifndef GRPC_NO_BINDER
@ -35,12 +37,12 @@ Java_io_grpc_binder_cpp_GrpcBinderConnection_notifyConnected__Ljava_lang_String_
jboolean isCopy;
const char* conn_id = jni_env->GetStringUTFChars(conn_id_jstring, &isCopy);
gpr_log(GPR_INFO, "%s invoked with conn_id = %s", __func__, conn_id);
GPR_ASSERT(ibinder != nullptr);
CHECK_NE(ibinder, nullptr);
grpc_binder::ndk_util::SpAIBinder aibinder =
grpc_binder::FromJavaBinder(jni_env, ibinder);
gpr_log(GPR_INFO, "%s got aibinder = %p", __func__, aibinder.get());
auto b = std::make_unique<grpc_binder::BinderAndroid>(aibinder);
GPR_ASSERT(b != nullptr);
CHECK(b != nullptr);
grpc_binder::GetEndpointBinderPool()->AddEndpointBinder(conn_id,
std::move(b));
if (isCopy == JNI_TRUE) {
@ -63,7 +65,7 @@ void EndpointBinderPool::GetEndpointBinder(
if (binder_map_.count(conn_id)) {
b = std::move(binder_map_[conn_id]);
binder_map_.erase(conn_id);
GPR_ASSERT(b != nullptr);
CHECK(b != nullptr);
} else {
if (pending_requests_.count(conn_id) != 0) {
gpr_log(GPR_ERROR,
@ -75,14 +77,14 @@ void EndpointBinderPool::GetEndpointBinder(
return;
}
}
GPR_ASSERT(b != nullptr);
CHECK(b != nullptr);
cb(std::move(b));
}
void EndpointBinderPool::AddEndpointBinder(
std::string conn_id, std::unique_ptr<grpc_binder::Binder> b) {
gpr_log(GPR_INFO, "EndpointBinder added. conn_id = %s", conn_id.c_str());
GPR_ASSERT(b != nullptr);
CHECK(b != nullptr);
// cb will be set in the following block if there is a pending callback
std::function<void(std::unique_ptr<grpc_binder::Binder>)> cb = nullptr;
{

@ -14,6 +14,8 @@
#include "src/core/ext/transport/binder/client/jni_utils.h"
#include "absl/log/check.h"
#include <grpc/support/port_platform.h>
#ifndef GRPC_NO_BINDER
@ -41,7 +43,7 @@ jclass FindNativeConnectionHelper(
}
jclass global_cl = static_cast<jclass>(env->NewGlobalRef(cl));
env->DeleteLocalRef(cl);
GPR_ASSERT(global_cl != nullptr);
CHECK_NE(global_cl, nullptr);
return global_cl;
};
static jclass connection_helper_class = do_find();

@ -12,6 +12,8 @@
// See the License for the specific language governing permissions and
// limitations under the License.
#include "absl/log/check.h"
#include <grpc/support/port_platform.h>
#ifndef GRPC_NO_BINDER
@ -25,14 +27,14 @@ void SecurityPolicySetting::Set(
std::shared_ptr<grpc::experimental::binder::SecurityPolicy>
security_policy) {
grpc_core::MutexLock l(&m_);
GPR_ASSERT(security_policy_map_.count(std::string(connection_id)) == 0);
CHECK_EQ(security_policy_map_.count(std::string(connection_id)), 0u);
security_policy_map_[std::string(connection_id)] = security_policy;
}
std::shared_ptr<grpc::experimental::binder::SecurityPolicy>
SecurityPolicySetting::Get(absl::string_view connection_id) {
grpc_core::MutexLock l(&m_);
GPR_ASSERT(security_policy_map_.count(std::string(connection_id)) != 0);
CHECK_NE(security_policy_map_.count(std::string(connection_id)), 0u);
return security_policy_map_[std::string(connection_id)];
}

@ -23,6 +23,8 @@
#include <jni.h>
#include <unistd.h>
#include "absl/log/check.h"
#include <grpc/support/log.h>
#include "src/core/ext/transport/binder/client/jni_utils.h"
@ -61,8 +63,8 @@ JNIEnv* GetEnv(JavaVM* vm) {
JNIEnv* result = nullptr;
jint attach = vm->AttachCurrentThread(&result, nullptr);
GPR_ASSERT(JNI_OK == attach);
GPR_ASSERT(nullptr != result);
CHECK(JNI_OK == attach);
CHECK_NE(result, nullptr);
return result;
}
} // namespace
@ -70,14 +72,14 @@ JNIEnv* GetEnv(JavaVM* vm) {
SameSignatureSecurityPolicy::SameSignatureSecurityPolicy(JavaVM* jvm,
jobject context)
: jvm_(jvm) {
GPR_ASSERT(jvm != nullptr);
GPR_ASSERT(context != nullptr);
CHECK_NE(jvm, nullptr);
CHECK_NE(context, nullptr);
JNIEnv* env = GetEnv(jvm_);
// Make sure the context is still valid when IsAuthorized() is called
context_ = env->NewGlobalRef(context);
GPR_ASSERT(context_ != nullptr);
CHECK_NE(context_, nullptr);
}
SameSignatureSecurityPolicy::~SameSignatureSecurityPolicy() {

@ -22,6 +22,7 @@
#include <string>
#include <utility>
#include "absl/log/check.h"
#include "absl/memory/memory.h"
#include <grpc/grpc.h>
@ -212,7 +213,7 @@ class BinderServerListener : public Server::ListenerInterface {
// grpc_create_binder_transport_server().
Transport* server_transport = grpc_create_binder_transport_server(
std::move(client_binder), security_policy_);
GPR_ASSERT(server_transport);
CHECK(server_transport);
grpc_error_handle error = server_->SetupTransport(
server_transport, nullptr, server_->channel_args(), nullptr);
return grpc_error_to_absl_status(error);

@ -12,6 +12,8 @@
// See the License for the specific language governing permissions and
// limitations under the License.
#include "absl/log/check.h"
#include <grpc/support/port_platform.h>
#ifndef GRPC_NO_BINDER
@ -59,7 +61,7 @@ class BinderServerCredentialsImpl final : public ServerCredentials {
std::shared_ptr<ServerCredentials> BinderServerCredentials(
std::shared_ptr<grpc::experimental::binder::SecurityPolicy>
security_policy) {
GPR_ASSERT(security_policy != nullptr);
CHECK_NE(security_policy, nullptr);
return std::shared_ptr<ServerCredentials>(
new BinderServerCredentialsImpl(security_policy));
}

@ -23,6 +23,7 @@
#include <string>
#include <utility>
#include "absl/log/check.h"
#include "absl/memory/memory.h"
#include "absl/strings/str_cat.h"
#include "absl/strings/substitute.h"
@ -142,7 +143,7 @@ static void cancel_stream_locked(grpc_binder_transport* transport,
grpc_error_handle error) {
gpr_log(GPR_INFO, "cancel_stream_locked");
if (!stream->is_closed) {
GPR_ASSERT(stream->cancel_self_error.ok());
CHECK(stream->cancel_self_error.ok());
stream->is_closed = true;
stream->cancel_self_error = error;
transport->transport_stream_receiver->CancelStream(stream->tx_code);
@ -196,8 +197,8 @@ static void recv_initial_metadata_locked(void* arg,
if (!stream->is_closed) {
grpc_error_handle error = [&] {
GPR_ASSERT(stream->recv_initial_metadata);
GPR_ASSERT(stream->recv_initial_metadata_ready);
CHECK(stream->recv_initial_metadata);
CHECK(stream->recv_initial_metadata_ready);
if (!args->initial_metadata.ok()) {
gpr_log(GPR_ERROR, "Failed to parse initial metadata");
return absl_status_to_grpc_error(args->initial_metadata.status());
@ -233,8 +234,8 @@ static void recv_message_locked(void* arg, grpc_error_handle /*error*/) {
if (!stream->is_closed) {
grpc_error_handle error = [&] {
GPR_ASSERT(stream->recv_message);
GPR_ASSERT(stream->recv_message_ready);
CHECK(stream->recv_message);
CHECK(stream->recv_message_ready);
if (!args->message.ok()) {
gpr_log(GPR_ERROR, "Failed to receive message");
if (args->message.status().message() ==
@ -277,8 +278,8 @@ static void recv_trailing_metadata_locked(void* arg,
if (!stream->is_closed) {
grpc_error_handle error = [&] {
GPR_ASSERT(stream->recv_trailing_metadata);
GPR_ASSERT(stream->recv_trailing_metadata_finished);
CHECK(stream->recv_trailing_metadata);
CHECK(stream->recv_trailing_metadata_finished);
if (!args->trailing_metadata.ok()) {
gpr_log(GPR_ERROR, "Failed to receive trailing metadata");
return absl_status_to_grpc_error(args->trailing_metadata.status());
@ -339,11 +340,11 @@ class MetadataEncoder {
void Encode(grpc_core::HttpPathMetadata, const grpc_core::Slice& value) {
// TODO(b/192208403): Figure out if it is correct to simply drop '/'
// prefix and treat it as rpc method name
GPR_ASSERT(value[0] == '/');
CHECK(value[0] == '/');
std::string path = std::string(value.as_string_view().substr(1));
// Only client send method ref.
GPR_ASSERT(is_client_);
CHECK(is_client_);
tx_->SetMethodRef(path);
}
@ -390,9 +391,9 @@ static void perform_stream_op_locked(void* stream_op,
grpc_binder_transport* transport = stream->t;
if (op->cancel_stream) {
// TODO(waynetu): Is this true?
GPR_ASSERT(!op->send_initial_metadata && !op->send_message &&
!op->send_trailing_metadata && !op->recv_initial_metadata &&
!op->recv_message && !op->recv_trailing_metadata);
CHECK(!op->send_initial_metadata && !op->send_message &&
!op->send_trailing_metadata && !op->recv_initial_metadata &&
!op->recv_message && !op->recv_trailing_metadata);
gpr_log(GPR_INFO, "cancel_stream is_client = %d", stream->is_client);
if (!stream->is_client) {
// Send trailing metadata to inform the other end about the cancellation,
@ -741,8 +742,8 @@ grpc_core::Transport* grpc_create_binder_transport_client(
security_policy) {
gpr_log(GPR_INFO, __func__);
GPR_ASSERT(endpoint_binder != nullptr);
GPR_ASSERT(security_policy != nullptr);
CHECK(endpoint_binder != nullptr);
CHECK_NE(security_policy, nullptr);
grpc_binder_transport* t = new grpc_binder_transport(
std::move(endpoint_binder), /*is_client=*/true, security_policy);
@ -756,8 +757,8 @@ grpc_core::Transport* grpc_create_binder_transport_server(
security_policy) {
gpr_log(GPR_INFO, __func__);
GPR_ASSERT(client_binder != nullptr);
GPR_ASSERT(security_policy != nullptr);
CHECK(client_binder != nullptr);
CHECK_NE(security_policy, nullptr);
grpc_binder_transport* t = new grpc_binder_transport(
std::move(client_binder), /*is_client=*/false, security_policy);

@ -22,6 +22,7 @@
#include <vector>
#include "absl/container/flat_hash_map.h"
#include "absl/log/check.h"
#include <grpc/support/log.h>
#include <grpc/support/port_platform.h>
@ -74,7 +75,7 @@ struct grpc_binder_transport final : public grpc_core::FilterStackTransport {
// TODO(mingcl): Wrap around when all tx codes are used. "If we do detect a
// collision however, we will fail the new call with UNAVAILABLE, and shut
// down the transport gracefully."
GPR_ASSERT(next_free_tx_code <= LAST_CALL_TRANSACTION);
CHECK(next_free_tx_code <= LAST_CALL_TRANSACTION);
return next_free_tx_code++;
}

@ -22,6 +22,8 @@
#include <dlfcn.h>
#include "absl/log/check.h"
#include <grpc/support/log.h>
#include "src/core/lib/gprpp/crash.h"
@ -36,7 +38,7 @@ void* GetNdkBinderHandle() {
gpr_log(
GPR_ERROR,
"Cannot open libbinder_ndk.so. Does this device support API level 29?");
GPR_ASSERT(0);
CHECK(0);
}
return handle;
}
@ -102,7 +104,7 @@ namespace ndk_util {
"dlsym failed. Cannot find %s in libbinder_ndk.so. " \
"BinderTransport requires API level >= 33", \
#name); \
GPR_ASSERT(0); \
CHECK(0); \
} \
return ptr

@ -22,6 +22,8 @@
#include <string>
#include <utility>
#include "absl/log/check.h"
#include <grpc/support/log.h>
#include "src/core/lib/gprpp/crash.h"
@ -38,7 +40,7 @@ void TransportStreamReceiverImpl::RegisterRecvInitialMetadata(
absl::StatusOr<Metadata> initial_metadata{};
{
grpc_core::MutexLock l(&m_);
GPR_ASSERT(initial_metadata_cbs_.count(id) == 0);
CHECK_EQ(initial_metadata_cbs_.count(id), 0u);
auto iter = pending_initial_metadata_.find(id);
if (iter == pending_initial_metadata_.end()) {
if (trailing_metadata_recvd_.count(id)) {
@ -66,7 +68,7 @@ void TransportStreamReceiverImpl::RegisterRecvMessage(
absl::StatusOr<std::string> message{};
{
grpc_core::MutexLock l(&m_);
GPR_ASSERT(message_cbs_.count(id) == 0);
CHECK_EQ(message_cbs_.count(id), 0u);
auto iter = pending_message_.find(id);
if (iter == pending_message_.end()) {
// If we'd already received trailing-metadata and there's no pending
@ -100,7 +102,7 @@ void TransportStreamReceiverImpl::RegisterRecvTrailingMetadata(
std::pair<absl::StatusOr<Metadata>, int> trailing_metadata{};
{
grpc_core::MutexLock l(&m_);
GPR_ASSERT(trailing_metadata_cbs_.count(id) == 0);
CHECK_EQ(trailing_metadata_cbs_.count(id), 0u);
auto iter = pending_trailing_metadata_.find(id);
if (iter == pending_trailing_metadata_.end()) {
trailing_metadata_cbs_[id] = std::move(cb);

@ -20,6 +20,7 @@
#include <map>
#include "absl/log/check.h"
#include "absl/memory/memory.h"
#include "absl/strings/str_cat.h"
@ -152,7 +153,7 @@ TransactionReceiverAndroid::TransactionReceiverAndroid(
args.wire_reader_ref = wire_reader_ref;
args.callback = &transact_cb_;
binder_ = ndk_util::AIBinder_new(aibinder_class, &args);
GPR_ASSERT(binder_);
CHECK(binder_);
gpr_log(GPR_INFO, "ndk_util::AIBinder_associateClass = %d",
static_cast<int>(
ndk_util::AIBinder_associateClass(binder_, aibinder_class)));

@ -18,6 +18,7 @@
#include <string>
#include <vector>
#include "absl/log/check.h"
#include "absl/strings/string_view.h"
#include <grpc/support/log.h>
@ -45,33 +46,33 @@ class Transaction {
// TODO(mingcl): Consider using string_view
void SetPrefix(Metadata prefix_metadata) {
prefix_metadata_ = prefix_metadata;
GPR_ASSERT((flags_ & kFlagPrefix) == 0);
CHECK_EQ((flags_ & kFlagPrefix), 0);
flags_ |= kFlagPrefix;
}
void SetMethodRef(std::string method_ref) {
GPR_ASSERT(is_client_);
CHECK(is_client_);
method_ref_ = method_ref;
}
void SetData(std::string message_data) {
message_data_ = message_data;
GPR_ASSERT((flags_ & kFlagMessageData) == 0);
CHECK_EQ((flags_ & kFlagMessageData), 0);
flags_ |= kFlagMessageData;
}
void SetSuffix(Metadata suffix_metadata) {
if (is_client_) GPR_ASSERT(suffix_metadata.empty());
if (is_client_) CHECK(suffix_metadata.empty());
suffix_metadata_ = suffix_metadata;
GPR_ASSERT((flags_ & kFlagSuffix) == 0);
CHECK_EQ((flags_ & kFlagSuffix), 0);
flags_ |= kFlagSuffix;
}
void SetStatusDescription(std::string status_desc) {
GPR_ASSERT(!is_client_);
GPR_ASSERT((flags_ & kFlagStatusDescription) == 0);
CHECK(!is_client_);
CHECK_EQ((flags_ & kFlagStatusDescription), 0);
status_desc_ = status_desc;
}
void SetStatus(int status) {
GPR_ASSERT(!is_client_);
GPR_ASSERT((flags_ >> 16) == 0);
GPR_ASSERT(status < (1 << 16));
CHECK(!is_client_);
CHECK_EQ((flags_ >> 16), 0);
CHECK(status < (1 << 16));
flags_ |= (status << 16);
}

@ -25,6 +25,7 @@
#include <vector>
#include "absl/functional/any_invocable.h"
#include "absl/log/check.h"
#include "absl/memory/memory.h"
#include "absl/status/statusor.h"
@ -305,7 +306,7 @@ absl::Status WireReaderImpl::ProcessStreamingTransaction(
absl::Seconds(5))) {
return absl::DeadlineExceededError("wire_writer_ is not ready in time!");
}
GPR_ASSERT(wire_writer_);
CHECK(wire_writer_);
// wire_writer_ should not be accessed while holding mu_!
// Otherwise, it is possible that
// 1. wire_writer_::mu_ is acquired before mu_ (NDK call back during
@ -323,7 +324,7 @@ absl::Status WireReaderImpl::ProcessStreamingTransaction(
absl::Status WireReaderImpl::ProcessStreamingTransactionImpl(
transaction_code_t code, ReadableParcel* parcel, int* cancellation_flags,
std::queue<absl::AnyInvocable<void() &&>>& deferred_func_queue) {
GPR_ASSERT(cancellation_flags);
CHECK(cancellation_flags);
num_incoming_bytes_ += parcel->GetDataSize();
gpr_log(GPR_INFO, "Total incoming bytes: %" PRId64, num_incoming_bytes_);
@ -360,8 +361,8 @@ absl::Status WireReaderImpl::ProcessStreamingTransactionImpl(
// TODO(waynetu): According to the protocol, "The sequence number will wrap
// around to 0 if more than 2^31 messages are sent." For now we'll just
// assert that it never reach such circumstances.
GPR_ASSERT(expectation < std::numeric_limits<int32_t>::max() &&
"Sequence number too large");
CHECK(expectation < std::numeric_limits<int32_t>::max())
<< "Sequence number too large";
expectation++;
gpr_log(GPR_DEBUG, "sequence number = %d", seq_num);
if (flags & kFlagPrefix) {

@ -21,6 +21,7 @@
#include <utility>
#include "absl/cleanup/cleanup.h"
#include "absl/log/check.h"
#include "absl/types/variant.h"
#include <grpc/support/log.h>
@ -122,7 +123,7 @@ absl::Status WireWriterImpl::MakeBinderTransaction(
gpr_log(GPR_INFO, "Total outgoing bytes: %" PRId64,
num_outgoing_bytes_.load());
}
GPR_ASSERT(!is_transacting_);
CHECK(!is_transacting_);
is_transacting_ = true;
absl::Status result = binder_->Transact(tx_code);
is_transacting_ = false;
@ -155,10 +156,10 @@ absl::Status WireWriterImpl::RunStreamTx(
bool* is_last_chunk) {
Transaction* tx = stream_tx->tx.get();
// Transaction without data flag should go to fast path.
GPR_ASSERT(tx->GetFlags() & kFlagMessageData);
CHECK(tx->GetFlags() & kFlagMessageData);
absl::string_view data = tx->GetMessageData();
GPR_ASSERT(stream_tx->bytes_sent <= static_cast<int64_t>(data.size()));
CHECK(stream_tx->bytes_sent <= static_cast<int64_t>(data.size()));
int flags = kFlagMessageData;
@ -206,7 +207,7 @@ absl::Status WireWriterImpl::RunStreamTx(
}
void WireWriterImpl::RunScheduledTxInternal(RunScheduledTxArgs* args) {
GPR_ASSERT(args->writer == this);
CHECK(args->writer == this);
if (absl::holds_alternative<RunScheduledTxArgs::AckTx>(args->tx)) {
int64_t num_bytes =
absl::get<RunScheduledTxArgs::AckTx>(args->tx).num_bytes;
@ -223,7 +224,7 @@ void WireWriterImpl::RunScheduledTxInternal(RunScheduledTxArgs* args) {
delete args;
return;
}
GPR_ASSERT(absl::holds_alternative<RunScheduledTxArgs::StreamTx>(args->tx));
CHECK(absl::holds_alternative<RunScheduledTxArgs::StreamTx>(args->tx));
RunScheduledTxArgs::StreamTx* stream_tx =
&absl::get<RunScheduledTxArgs::StreamTx>(args->tx);
// Be reservative. Decrease CombinerTxCount after the data size of this
@ -232,7 +233,7 @@ void WireWriterImpl::RunScheduledTxInternal(RunScheduledTxArgs* args) {
auto decrease_combiner_tx_count = absl::MakeCleanup([this]() {
{
grpc_core::MutexLock lock(&flow_control_mu_);
GPR_ASSERT(num_non_acked_tx_in_combiner_ > 0);
CHECK_GT(num_non_acked_tx_in_combiner_, 0);
num_non_acked_tx_in_combiner_--;
}
// New transaction might be ready to be scheduled.
@ -271,7 +272,7 @@ void WireWriterImpl::RunScheduledTxInternal(RunScheduledTxArgs* args) {
absl::Status WireWriterImpl::RpcCall(std::unique_ptr<Transaction> tx) {
// TODO(mingcl): check tx_code <= last call id
GPR_ASSERT(tx->GetTxCode() >= kFirstCallId);
CHECK(tx->GetTxCode() >= kFirstCallId);
auto args = new RunScheduledTxArgs();
args->writer = this;
args->tx = RunScheduledTxArgs::StreamTx();

@ -18,6 +18,8 @@
#include "src/core/ext/transport/chttp2/alpn/alpn.h"
#include "absl/log/check.h"
#include <grpc/support/log.h>
#include <grpc/support/port_platform.h>
@ -42,6 +44,6 @@ size_t grpc_chttp2_num_alpn_versions(void) {
}
const char* grpc_chttp2_get_alpn_version_index(size_t i) {
GPR_ASSERT(i < GPR_ARRAY_SIZE(supported_versions));
CHECK_LT(i, GPR_ARRAY_SIZE(supported_versions));
return supported_versions[i];
}

@ -24,6 +24,7 @@
#include <type_traits>
#include <utility>
#include "absl/log/check.h"
#include "absl/status/status.h"
#include "absl/status/statusor.h"
#include "absl/strings/str_format.h"
@ -104,11 +105,11 @@ void Chttp2Connector::Connect(const Args& args, Result* result,
grpc_closure* notify) {
{
MutexLock lock(&mu_);
GPR_ASSERT(notify_ == nullptr);
CHECK_EQ(notify_, nullptr);
args_ = args;
result_ = result;
notify_ = notify;
GPR_ASSERT(endpoint_ == nullptr);
CHECK_EQ(endpoint_, nullptr);
event_engine_ = args_.channel_args.GetObject<EventEngine>();
}
absl::StatusOr<std::string> address = grpc_sockaddr_to_uri(args.address);
@ -166,7 +167,7 @@ void Chttp2Connector::OnHandshakeDone(void* arg, grpc_error_handle error) {
} else if (args->endpoint != nullptr) {
self->result_->transport =
grpc_create_chttp2_transport(args->args, args->endpoint, true);
GPR_ASSERT(self->result_->transport != nullptr);
CHECK_NE(self->result_->transport, nullptr);
self->result_->socket_node =
grpc_chttp2_transport_get_socket_node(self->result_->transport);
self->result_->channel_args = args->args;
@ -188,7 +189,7 @@ void Chttp2Connector::OnHandshakeDone(void* arg, grpc_error_handle error) {
// If the handshaking succeeded but there is no endpoint, then the
// handshaker may have handed off the connection to some external
// code. Just verify that exit_early flag is set.
GPR_DEBUG_ASSERT(args->exit_early);
DCHECK(args->exit_early);
NullThenSchedClosure(DEBUG_LOCATION, &self->notify_, error);
}
self->handshake_mgr_.reset();
@ -396,14 +397,14 @@ grpc_channel* grpc_channel_create_from_fd(const char* target, int fd,
.SetObject(creds->Ref());
int flags = fcntl(fd, F_GETFL, 0);
GPR_ASSERT(fcntl(fd, F_SETFL, flags | O_NONBLOCK) == 0);
CHECK_EQ(fcntl(fd, F_SETFL, flags | O_NONBLOCK), 0);
grpc_endpoint* client = grpc_tcp_create_from_fd(
grpc_fd_create(fd, "client", true),
grpc_event_engine::experimental::ChannelArgsEndpointConfig(final_args),
"fd-client");
grpc_core::Transport* transport =
grpc_create_chttp2_transport(final_args, client, true);
GPR_ASSERT(transport);
CHECK(transport);
auto channel = grpc_core::ChannelCreate(
target, final_args, GRPC_CLIENT_DIRECT_CHANNEL, transport);
if (channel.ok()) {
@ -424,7 +425,7 @@ grpc_channel* grpc_channel_create_from_fd(const char* /* target */,
int /* fd */,
grpc_channel_credentials* /* creds*/,
const grpc_channel_args* /* args */) {
GPR_ASSERT(0);
CHECK(0);
return nullptr;
}

@ -29,6 +29,7 @@
#include <vector>
#include "absl/base/thread_annotations.h"
#include "absl/log/check.h"
#include "absl/status/status.h"
#include "absl/status/statusor.h"
#include "absl/strings/str_cat.h"
@ -308,7 +309,7 @@ void Chttp2ServerListener::ConfigFetcherWatcher::UpdateConnectionManager(
void set_connections(
std::map<ActiveConnection*, OrphanablePtr<ActiveConnection>>
connections) {
GPR_ASSERT(connections_.empty());
CHECK(connections_.empty());
connections_ = std::move(connections);
}
@ -334,7 +335,7 @@ void Chttp2ServerListener::ConfigFetcherWatcher::UpdateConnectionManager(
StatusToString(error).c_str());
// TODO(yashykt): We wouldn't need to assert here if we bound to the
// port earlier during AddPort.
GPR_ASSERT(0);
CHECK(0);
}
listener_->StartListening();
{
@ -1000,7 +1001,7 @@ grpc_error_handle Chttp2ServerAddPort(Server* server, const char* addr,
if (*port_num == -1) {
*port_num = port_temp;
} else {
GPR_ASSERT(*port_num == port_temp);
CHECK(*port_num == port_temp);
}
}
}
@ -1139,7 +1140,7 @@ void grpc_server_add_channel_from_fd(grpc_server* server, int fd,
void grpc_server_add_channel_from_fd(grpc_server* /* server */, int /* fd */,
grpc_server_credentials* /* creds */) {
GPR_ASSERT(0);
CHECK(0);
}
#endif // GPR_SUPPORT_CHANNELS_FROM_FD

@ -19,6 +19,7 @@
#include "src/core/ext/transport/chttp2/transport/bin_decoder.h"
#include "absl/base/attributes.h"
#include "absl/log/check.h"
#include <grpc/support/alloc.h>
#include <grpc/support/log.h>
@ -198,8 +199,8 @@ grpc_slice grpc_chttp2_base64_decode(const grpc_slice& input) {
grpc_core::CSliceUnref(output);
return grpc_empty_slice();
}
GPR_ASSERT(ctx.output_cur == GRPC_SLICE_END_PTR(output));
GPR_ASSERT(ctx.input_cur == GRPC_SLICE_END_PTR(input));
CHECK(ctx.output_cur == GRPC_SLICE_END_PTR(output));
CHECK(ctx.input_cur == GRPC_SLICE_END_PTR(input));
return output;
}
@ -245,7 +246,7 @@ grpc_slice grpc_chttp2_base64_decode_with_length(const grpc_slice& input,
grpc_core::CSliceUnref(output);
return grpc_empty_slice();
}
GPR_ASSERT(ctx.output_cur == GRPC_SLICE_END_PTR(output));
GPR_ASSERT(ctx.input_cur <= GRPC_SLICE_END_PTR(input));
CHECK(ctx.output_cur == GRPC_SLICE_END_PTR(output));
CHECK(ctx.input_cur <= GRPC_SLICE_END_PTR(input));
return output;
}

@ -21,6 +21,8 @@
#include <stdint.h>
#include <string.h>
#include "absl/log/check.h"
#include <grpc/support/log.h>
#include <grpc/support/port_platform.h>
@ -87,8 +89,8 @@ grpc_slice grpc_chttp2_base64_encode(const grpc_slice& input) {
break;
}
GPR_ASSERT(out == (char*)GRPC_SLICE_END_PTR(output));
GPR_ASSERT(in == GRPC_SLICE_END_PTR(input));
CHECK(out == (char*)GRPC_SLICE_END_PTR(output));
CHECK(in == GRPC_SLICE_END_PTR(input));
return output;
}
@ -131,7 +133,7 @@ grpc_slice grpc_chttp2_huffman_compress(const grpc_slice& input) {
static_cast<uint8_t>(0xffu >> temp_length));
}
GPR_ASSERT(out == GRPC_SLICE_END_PTR(output));
CHECK(out == GRPC_SLICE_END_PTR(output));
return output;
}
@ -227,9 +229,9 @@ grpc_slice grpc_chttp2_base64_encode_and_huffman_compress(
static_cast<uint8_t>(0xffu >> out.temp_length));
}
GPR_ASSERT(out.out <= GRPC_SLICE_END_PTR(output));
CHECK(out.out <= GRPC_SLICE_END_PTR(output));
GRPC_SLICE_SET_LENGTH(output, out.out - start_out);
GPR_ASSERT(in == GRPC_SLICE_END_PTR(input));
CHECK(in == GRPC_SLICE_END_PTR(input));
return output;
}

@ -34,6 +34,7 @@
#include "absl/base/attributes.h"
#include "absl/container/flat_hash_map.h"
#include "absl/hash/hash.h"
#include "absl/log/check.h"
#include "absl/meta/type_traits.h"
#include "absl/random/random.h"
#include "absl/status/status.h"
@ -398,11 +399,11 @@ grpc_chttp2_transport::~grpc_chttp2_transport() {
grpc_chttp2_goaway_parser_destroy(&goaway_parser);
for (i = 0; i < STREAM_LIST_COUNT; i++) {
GPR_ASSERT(lists[i].head == nullptr);
GPR_ASSERT(lists[i].tail == nullptr);
CHECK_EQ(lists[i].head, nullptr);
CHECK_EQ(lists[i].tail, nullptr);
}
GPR_ASSERT(stream_map.empty());
CHECK(stream_map.empty());
GRPC_COMBINER_UNREF(combiner, "chttp2_transport");
while (write_cb_pool) {
@ -573,7 +574,7 @@ static void read_channel_args(grpc_chttp2_transport* t,
static void init_keepalive_pings_if_enabled_locked(
grpc_core::RefCountedPtr<grpc_chttp2_transport> t,
GRPC_UNUSED grpc_error_handle error) {
GPR_DEBUG_ASSERT(error.ok());
DCHECK(error.ok());
if (t->keepalive_time != grpc_core::Duration::Infinity()) {
t->keepalive_state = GRPC_CHTTP2_KEEPALIVE_STATE_WAITING;
t->keepalive_ping_timer_handle =
@ -616,8 +617,8 @@ grpc_chttp2_transport::grpc_chttp2_transport(
deframe_state(is_client ? GRPC_DTS_FH_0 : GRPC_DTS_CLIENT_PREFIX_0),
is_client(is_client) {
cl = new grpc_core::ContextList();
GPR_ASSERT(strlen(GRPC_CHTTP2_CLIENT_CONNECT_STRING) ==
GRPC_CHTTP2_CLIENT_CONNECT_STRLEN);
CHECK(strlen(GRPC_CHTTP2_CLIENT_CONNECT_STRING) ==
GRPC_CHTTP2_CLIENT_CONNECT_STRLEN);
grpc_slice_buffer_init(&read_buffer);
if (is_client) {
@ -706,7 +707,7 @@ static void close_transport_locked(grpc_chttp2_transport* t,
grpc_error_add_child(t->close_transport_on_writes_finished, error);
return;
}
GPR_ASSERT(!error.ok());
CHECK(!error.ok());
t->closed_with_error = error;
connectivity_state_set(t, GRPC_CHANNEL_SHUTDOWN, absl::Status(),
"close_transport");
@ -750,7 +751,7 @@ static void close_transport_locked(grpc_chttp2_transport* t,
while (grpc_chttp2_list_pop_writable_stream(t, &s)) {
GRPC_CHTTP2_STREAM_UNREF(s, "chttp2_writing:close");
}
GPR_ASSERT(t->write_state == GRPC_CHTTP2_WRITE_STATE_IDLE);
CHECK(t->write_state == GRPC_CHTTP2_WRITE_STATE_IDLE);
grpc_endpoint_shutdown(t->ep, error);
}
if (t->notify_on_receive_settings != nullptr) {
@ -826,9 +827,9 @@ grpc_chttp2_stream::~grpc_chttp2_stream() {
}
}
GPR_ASSERT((write_closed && read_closed) || id == 0);
CHECK((write_closed && read_closed) || id == 0);
if (id != 0) {
GPR_ASSERT(t->stream_map.count(id) == 0);
CHECK_EQ(t->stream_map.count(id), 0u);
}
grpc_slice_buffer_destroy(&frame_storage);
@ -841,11 +842,11 @@ grpc_chttp2_stream::~grpc_chttp2_stream() {
}
}
GPR_ASSERT(send_initial_metadata_finished == nullptr);
GPR_ASSERT(send_trailing_metadata_finished == nullptr);
GPR_ASSERT(recv_initial_metadata_ready == nullptr);
GPR_ASSERT(recv_message_ready == nullptr);
GPR_ASSERT(recv_trailing_metadata_finished == nullptr);
CHECK_EQ(send_initial_metadata_finished, nullptr);
CHECK_EQ(send_trailing_metadata_finished, nullptr);
CHECK_EQ(recv_initial_metadata_ready, nullptr);
CHECK_EQ(recv_message_ready, nullptr);
CHECK_EQ(recv_trailing_metadata_finished, nullptr);
grpc_slice_buffer_destroy(&flow_controlled_buffer);
grpc_core::ExecCtx::Run(DEBUG_LOCATION, destroy_stream_arg, absl::OkStatus());
}
@ -878,7 +879,7 @@ grpc_chttp2_stream* grpc_chttp2_parsing_accept_stream(grpc_chttp2_transport* t,
return nullptr;
}
grpc_chttp2_stream* accepting = nullptr;
GPR_ASSERT(t->accepting_stream == nullptr);
CHECK_EQ(t->accepting_stream, nullptr);
t->accepting_stream = &accepting;
t->accept_stream_cb(t->accept_stream_cb_user_data, t,
reinterpret_cast<void*>(id));
@ -980,7 +981,7 @@ static const char* begin_writing_desc(bool partial) {
static void write_action_begin_locked(
grpc_core::RefCountedPtr<grpc_chttp2_transport> t,
grpc_error_handle /*error_ignored*/) {
GPR_ASSERT(t->write_state != GRPC_CHTTP2_WRITE_STATE_IDLE);
CHECK(t->write_state != GRPC_CHTTP2_WRITE_STATE_IDLE);
grpc_chttp2_begin_write_result r;
if (!t->closed_with_error.ok()) {
r.writing = false;
@ -994,7 +995,7 @@ static void write_action_begin_locked(
begin_writing_desc(r.partial));
write_action(t.get());
if (t->reading_paused_on_pending_induced_frames) {
GPR_ASSERT(t->num_pending_induced_frames == 0);
CHECK_EQ(t->num_pending_induced_frames, 0u);
// We had paused reading, because we had many induced frames (SETTINGS
// ACK, PINGS ACK and RST_STREAMS) pending in t->qbuf. Now that we have
// been able to flush qbuf, we can resume reading.
@ -1211,7 +1212,7 @@ static void maybe_start_some_streams(grpc_chttp2_transport* t) {
"HTTP:%s: Transport %p allocating new grpc_chttp2_stream %p to id %d",
t->is_client ? "CLI" : "SVR", t, s, t->next_stream_id));
GPR_ASSERT(s->id == 0);
CHECK_EQ(s->id, 0u);
s->id = t->next_stream_id;
t->next_stream_id += 2;
@ -1384,7 +1385,7 @@ static void perform_stream_op_locked(void* stream_op,
if (t->is_client && t->channelz_socket != nullptr) {
t->channelz_socket->RecordStreamStartedFromLocal();
}
GPR_ASSERT(s->send_initial_metadata_finished == nullptr);
CHECK_EQ(s->send_initial_metadata_finished, nullptr);
on_complete->next_data.scratch |= t->closure_barrier_may_cover_write;
s->send_initial_metadata_finished = add_closure_barrier(on_complete);
@ -1402,7 +1403,7 @@ static void perform_stream_op_locked(void* stream_op,
if (!s->write_closed) {
if (t->is_client) {
if (t->closed_with_error.ok()) {
GPR_ASSERT(s->id == 0);
CHECK_EQ(s->id, 0u);
grpc_chttp2_list_add_waiting_for_concurrency(t, s);
maybe_start_some_streams(t);
} else {
@ -1419,7 +1420,7 @@ static void perform_stream_op_locked(void* stream_op,
false);
}
} else {
GPR_ASSERT(s->id != 0);
CHECK_NE(s->id, 0u);
grpc_chttp2_mark_stream_writable(t, s);
if (!(op->send_message &&
(op->payload->send_message.flags & GRPC_WRITE_BUFFER_HINT))) {
@ -1520,7 +1521,7 @@ static void perform_stream_op_locked(void* stream_op,
}
if (op->send_trailing_metadata) {
GPR_ASSERT(s->send_trailing_metadata_finished == nullptr);
CHECK_EQ(s->send_trailing_metadata_finished, nullptr);
on_complete->next_data.scratch |= t->closure_barrier_may_cover_write;
s->send_trailing_metadata_finished = add_closure_barrier(on_complete);
s->send_trailing_metadata =
@ -1550,7 +1551,7 @@ static void perform_stream_op_locked(void* stream_op,
}
if (op->recv_initial_metadata) {
GPR_ASSERT(s->recv_initial_metadata_ready == nullptr);
CHECK_EQ(s->recv_initial_metadata_ready, nullptr);
s->recv_initial_metadata_ready =
op_payload->recv_initial_metadata.recv_initial_metadata_ready;
s->recv_initial_metadata =
@ -1564,7 +1565,7 @@ static void perform_stream_op_locked(void* stream_op,
}
if (op->recv_message) {
GPR_ASSERT(s->recv_message_ready == nullptr);
CHECK_EQ(s->recv_message_ready, nullptr);
s->recv_message_ready = op_payload->recv_message.recv_message_ready;
s->recv_message = op_payload->recv_message.recv_message;
s->recv_message->emplace();
@ -1575,9 +1576,9 @@ static void perform_stream_op_locked(void* stream_op,
}
if (op->recv_trailing_metadata) {
GPR_ASSERT(s->collecting_stats == nullptr);
CHECK_EQ(s->collecting_stats, nullptr);
s->collecting_stats = op_payload->recv_trailing_metadata.collect_stats;
GPR_ASSERT(s->recv_trailing_metadata_finished == nullptr);
CHECK_EQ(s->recv_trailing_metadata_finished, nullptr);
s->recv_trailing_metadata_finished =
op_payload->recv_trailing_metadata.recv_trailing_metadata_ready;
s->recv_trailing_metadata =
@ -1600,14 +1601,14 @@ void grpc_chttp2_transport::PerformStreamOp(
if (!is_client) {
if (op->send_initial_metadata) {
GPR_ASSERT(!op->payload->send_initial_metadata.send_initial_metadata
->get(grpc_core::GrpcTimeoutMetadata())
.has_value());
CHECK(!op->payload->send_initial_metadata.send_initial_metadata
->get(grpc_core::GrpcTimeoutMetadata())
.has_value());
}
if (op->send_trailing_metadata) {
GPR_ASSERT(!op->payload->send_trailing_metadata.send_trailing_metadata
->get(grpc_core::GrpcTimeoutMetadata())
.has_value());
CHECK(!op->payload->send_trailing_metadata.send_trailing_metadata
->get(grpc_core::GrpcTimeoutMetadata())
.has_value());
}
}
@ -1699,8 +1700,8 @@ void grpc_chttp2_retry_initiate_ping(
static void retry_initiate_ping_locked(
grpc_core::RefCountedPtr<grpc_chttp2_transport> t,
GRPC_UNUSED grpc_error_handle error) {
GPR_DEBUG_ASSERT(error.ok());
GPR_ASSERT(t->delayed_ping_timer_handle != TaskHandle::kInvalid);
DCHECK(error.ok());
CHECK(t->delayed_ping_timer_handle != TaskHandle::kInvalid);
t->delayed_ping_timer_handle = TaskHandle::kInvalid;
grpc_chttp2_initiate_write(t.get(),
GRPC_CHTTP2_INITIATE_WRITE_RETRY_SEND_PING);
@ -2020,7 +2021,7 @@ void grpc_chttp2_maybe_complete_recv_message(grpc_chttp2_transport* t,
} else {
if (s->frame_storage.length != 0) {
while (true) {
GPR_ASSERT(s->frame_storage.length > 0);
CHECK_GT(s->frame_storage.length, 0u);
int64_t min_progress_size;
auto r = grpc_deframe_unprocessed_incoming_frames(
s, &min_progress_size, &**s->recv_message, s->recv_message_flags);
@ -2106,7 +2107,7 @@ void grpc_chttp2_maybe_complete_recv_trailing_metadata(grpc_chttp2_transport* t,
static grpc_chttp2_transport::RemovedStreamHandle remove_stream(
grpc_chttp2_transport* t, uint32_t id, grpc_error_handle error) {
grpc_chttp2_stream* s = t->stream_map.extract(id).mapped();
GPR_DEBUG_ASSERT(s);
DCHECK(s);
if (t->incoming_stream == s) {
t->incoming_stream = nullptr;
grpc_chttp2_parsing_become_skip_parser(t);
@ -2358,7 +2359,8 @@ static void close_from_api(grpc_chttp2_transport* t, grpc_chttp2_stream* s,
grpc_error_get_status(error, s->deadline, &grpc_status, &message, nullptr,
nullptr);
GPR_ASSERT(grpc_status >= 0 && (int)grpc_status < 100);
CHECK_GE(grpc_status, 0);
CHECK_LT((int)grpc_status, 100);
auto remove_stream_handle = grpc_chttp2_mark_stream_closed(t, s, 1, 1, error);
grpc_core::MaybeTarpit(
@ -2399,7 +2401,7 @@ static void close_from_api(grpc_chttp2_transport* t, grpc_chttp2_stream* s,
*p++ = '2';
*p++ = '0';
*p++ = '0';
GPR_ASSERT(p == GRPC_SLICE_END_PTR(http_status_hdr));
CHECK(p == GRPC_SLICE_END_PTR(http_status_hdr));
len += static_cast<uint32_t> GRPC_SLICE_LENGTH(http_status_hdr);
content_type_hdr = GRPC_SLICE_MALLOC(31);
@ -2435,7 +2437,7 @@ static void close_from_api(grpc_chttp2_transport* t, grpc_chttp2_stream* s,
*p++ = 'r';
*p++ = 'p';
*p++ = 'c';
GPR_ASSERT(p == GRPC_SLICE_END_PTR(content_type_hdr));
CHECK(p == GRPC_SLICE_END_PTR(content_type_hdr));
len += static_cast<uint32_t> GRPC_SLICE_LENGTH(content_type_hdr);
}
@ -2462,11 +2464,11 @@ static void close_from_api(grpc_chttp2_transport* t, grpc_chttp2_stream* s,
*p++ = static_cast<uint8_t>('0' + (grpc_status / 10));
*p++ = static_cast<uint8_t>('0' + (grpc_status % 10));
}
GPR_ASSERT(p == GRPC_SLICE_END_PTR(status_hdr));
CHECK(p == GRPC_SLICE_END_PTR(status_hdr));
len += static_cast<uint32_t> GRPC_SLICE_LENGTH(status_hdr);
size_t msg_len = message.length();
GPR_ASSERT(msg_len <= UINT32_MAX);
CHECK(msg_len <= UINT32_MAX);
grpc_core::VarintWriter<1> msg_len_writer(
static_cast<uint32_t>(msg_len));
message_pfx = GRPC_SLICE_MALLOC(14 + msg_len_writer.length());
@ -2487,7 +2489,7 @@ static void close_from_api(grpc_chttp2_transport* t, grpc_chttp2_stream* s,
*p++ = 'e';
msg_len_writer.Write(0, p);
p += msg_len_writer.length();
GPR_ASSERT(p == GRPC_SLICE_END_PTR(message_pfx));
CHECK(p == GRPC_SLICE_END_PTR(message_pfx));
len += static_cast<uint32_t> GRPC_SLICE_LENGTH(message_pfx);
len += static_cast<uint32_t>(msg_len);
@ -2503,7 +2505,7 @@ static void close_from_api(grpc_chttp2_transport* t, grpc_chttp2_stream* s,
*p++ = static_cast<uint8_t>(id >> 16);
*p++ = static_cast<uint8_t>(id >> 8);
*p++ = static_cast<uint8_t>(id);
GPR_ASSERT(p == GRPC_SLICE_END_PTR(hdr));
CHECK(p == GRPC_SLICE_END_PTR(hdr));
grpc_slice_buffer_add(&t->qbuf, hdr);
if (!sent_initial_metadata) {
@ -2821,7 +2823,7 @@ static void finish_bdp_ping_locked(
t->flow_control.bdp_estimator()->CompletePing();
grpc_chttp2_act_on_flowctl_action(t->flow_control.PeriodicUpdate(), t.get(),
nullptr);
GPR_ASSERT(t->next_bdp_ping_timer_handle == TaskHandle::kInvalid);
CHECK(t->next_bdp_ping_timer_handle == TaskHandle::kInvalid);
t->next_bdp_ping_timer_handle =
t->event_engine->RunAfter(next_ping - grpc_core::Timestamp::Now(), [t] {
grpc_core::ApplicationCallbackExecCtx callback_exec_ctx;
@ -2840,7 +2842,7 @@ static void next_bdp_ping_timer_expired(grpc_chttp2_transport* t) {
static void next_bdp_ping_timer_expired_locked(
grpc_core::RefCountedPtr<grpc_chttp2_transport> t,
GRPC_UNUSED grpc_error_handle error) {
GPR_DEBUG_ASSERT(error.ok());
DCHECK(error.ok());
t->next_bdp_ping_timer_handle = TaskHandle::kInvalid;
if (t->flow_control.bdp_estimator()->accumulator() == 0) {
// Block the bdp ping till we receive more data.
@ -2908,9 +2910,9 @@ static void init_keepalive_ping(
static void init_keepalive_ping_locked(
grpc_core::RefCountedPtr<grpc_chttp2_transport> t,
GRPC_UNUSED grpc_error_handle error) {
GPR_DEBUG_ASSERT(error.ok());
GPR_ASSERT(t->keepalive_state == GRPC_CHTTP2_KEEPALIVE_STATE_WAITING);
GPR_ASSERT(t->keepalive_ping_timer_handle != TaskHandle::kInvalid);
DCHECK(error.ok());
CHECK(t->keepalive_state == GRPC_CHTTP2_KEEPALIVE_STATE_WAITING);
CHECK(t->keepalive_ping_timer_handle != TaskHandle::kInvalid);
t->keepalive_ping_timer_handle = TaskHandle::kInvalid;
if (t->destroying || !t->closed_with_error.ok()) {
t->keepalive_state = GRPC_CHTTP2_KEEPALIVE_STATE_DYING;
@ -2952,7 +2954,7 @@ static void finish_keepalive_ping_locked(
std::string(t->peer_string.as_string_view()).c_str());
}
t->keepalive_state = GRPC_CHTTP2_KEEPALIVE_STATE_WAITING;
GPR_ASSERT(t->keepalive_ping_timer_handle == TaskHandle::kInvalid);
CHECK(t->keepalive_ping_timer_handle == TaskHandle::kInvalid);
t->keepalive_ping_timer_handle =
t->event_engine->RunAfter(t->keepalive_time, [t] {
grpc_core::ApplicationCallbackExecCtx callback_exec_ctx;

@ -27,6 +27,7 @@
#include <tuple>
#include <vector>
#include "absl/log/check.h"
#include "absl/strings/str_cat.h"
#include "absl/strings/str_format.h"
#include "absl/strings/str_join.h"
@ -336,7 +337,7 @@ void StreamFlowControl::SentUpdate(uint32_t announce) {
TransportFlowControl::IncomingUpdateContext tfc_upd(tfc_);
pending_size_ = absl::nullopt;
tfc_upd.UpdateAnnouncedWindowDelta(&announced_window_delta_, announce);
GPR_ASSERT(DesiredAnnounceSize() == 0);
CHECK_EQ(DesiredAnnounceSize(), 0u);
std::ignore = tfc_upd.MakeAction();
}
@ -386,7 +387,7 @@ FlowControlAction StreamFlowControl::UpdateAction(FlowControlAction action) {
void StreamFlowControl::IncomingUpdateContext::SetPendingSize(
int64_t pending_size) {
GPR_ASSERT(pending_size >= 0);
CHECK_GE(pending_size, 0);
sfc_->pending_size_ = pending_size;
}

@ -27,6 +27,7 @@
#include <utility>
#include "absl/functional/function_ref.h"
#include "absl/log/check.h"
#include "absl/status/status.h"
#include "absl/strings/string_view.h"
#include "absl/types/optional.h"
@ -132,7 +133,7 @@ class GRPC_MUST_USE_RESULT FlowControlAction {
static const char* UrgencyString(Urgency u);
std::string DebugString() const;
void AssertEmpty() { GPR_ASSERT(*this == FlowControlAction()); }
void AssertEmpty() { CHECK(*this == FlowControlAction()); }
bool operator==(const FlowControlAction& other) const {
return send_stream_update_ == other.send_stream_update_ &&
@ -195,7 +196,7 @@ class TransportFlowControl final {
class IncomingUpdateContext {
public:
explicit IncomingUpdateContext(TransportFlowControl* tfc) : tfc_(tfc) {}
~IncomingUpdateContext() { GPR_ASSERT(tfc_ == nullptr); }
~IncomingUpdateContext() { CHECK_EQ(tfc_, nullptr); }
IncomingUpdateContext(const IncomingUpdateContext&) = delete;
IncomingUpdateContext& operator=(const IncomingUpdateContext&) = delete;

@ -19,6 +19,7 @@
#include <cstdint>
#include <utility>
#include "absl/log/check.h"
#include "absl/status/status.h"
#include "absl/strings/str_cat.h"
@ -59,7 +60,7 @@ uint16_t Read2b(const uint8_t* input) {
}
void Write3b(uint32_t x, uint8_t* output) {
GPR_ASSERT(x < 16777216);
CHECK_LT(x, 16777216u);
output[0] = static_cast<uint8_t>(x >> 16);
output[1] = static_cast<uint8_t>(x >> 8);
output[2] = static_cast<uint8_t>(x);
@ -475,7 +476,7 @@ void Serialize(absl::Span<Http2Frame> frames, SliceBuffer& out) {
absl::StatusOr<Http2Frame> ParseFramePayload(const Http2FrameHeader& hdr,
SliceBuffer payload) {
GPR_ASSERT(payload.Length() == hdr.length);
CHECK(payload.Length() == hdr.length);
switch (hdr.type) {
case kFrameTypeData:
return ParseDataFrame(hdr, payload);

@ -20,6 +20,7 @@
#include <stdlib.h>
#include "absl/log/check.h"
#include "absl/status/status.h"
#include "absl/strings/str_format.h"
@ -62,7 +63,7 @@ void grpc_chttp2_encode_data(uint32_t id, grpc_slice_buffer* inbuf,
hdr = GRPC_SLICE_MALLOC(header_size);
p = GRPC_SLICE_START_PTR(hdr);
GPR_ASSERT(write_bytes < (1 << 24));
CHECK(write_bytes < (1 << 24));
*p++ = static_cast<uint8_t>(write_bytes >> 16);
*p++ = static_cast<uint8_t>(write_bytes >> 8);
*p++ = static_cast<uint8_t>(write_bytes);

@ -21,6 +21,7 @@
#include <string.h>
#include "absl/base/attributes.h"
#include "absl/log/check.h"
#include "absl/status/status.h"
#include "absl/strings/str_format.h"
#include "absl/strings/string_view.h"
@ -136,7 +137,7 @@ grpc_error_handle grpc_chttp2_goaway_parser_parse(void* parser,
memcpy(p->debug_data + p->debug_pos, cur,
static_cast<size_t>(end - cur));
}
GPR_ASSERT((size_t)(end - cur) < UINT32_MAX - p->debug_pos);
CHECK((size_t)(end - cur) < UINT32_MAX - p->debug_pos);
p->debug_pos += static_cast<uint32_t>(end - cur);
p->state = GRPC_CHTTP2_GOAWAY_DEBUG;
if (is_last) {
@ -157,7 +158,7 @@ void grpc_chttp2_goaway_append(uint32_t last_stream_id, uint32_t error_code,
grpc_slice header = GRPC_SLICE_MALLOC(9 + 4 + 4);
uint8_t* p = GRPC_SLICE_START_PTR(header);
uint32_t frame_length;
GPR_ASSERT(GRPC_SLICE_LENGTH(debug_data) < UINT32_MAX - 4 - 4);
CHECK(GRPC_SLICE_LENGTH(debug_data) < UINT32_MAX - 4 - 4);
frame_length = 4 + 4 + static_cast<uint32_t> GRPC_SLICE_LENGTH(debug_data);
// frame header: length
@ -183,7 +184,7 @@ void grpc_chttp2_goaway_append(uint32_t last_stream_id, uint32_t error_code,
*p++ = static_cast<uint8_t>(error_code >> 16);
*p++ = static_cast<uint8_t>(error_code >> 8);
*p++ = static_cast<uint8_t>(error_code);
GPR_ASSERT(p == GRPC_SLICE_END_PTR(header));
CHECK(p == GRPC_SLICE_END_PTR(header));
grpc_slice_buffer_add(slice_buffer, header);
grpc_slice_buffer_add(slice_buffer, debug_data);
}

@ -24,6 +24,7 @@
#include <algorithm>
#include "absl/container/flat_hash_map.h"
#include "absl/log/check.h"
#include "absl/status/status.h"
#include "absl/strings/str_format.h"
@ -93,7 +94,7 @@ grpc_error_handle grpc_chttp2_ping_parser_parse(void* parser,
}
if (p->byte == 8) {
GPR_ASSERT(is_last);
CHECK(is_last);
if (p->is_ack) {
if (grpc_ping_trace.enabled()) {
gpr_log(GPR_INFO, "%s[%p]: received ping ack %" PRIx64,

@ -20,6 +20,7 @@
#include <stddef.h>
#include "absl/log/check.h"
#include "absl/random/distributions.h"
#include "absl/status/status.h"
#include "absl/strings/str_cat.h"
@ -105,7 +106,7 @@ grpc_error_handle grpc_chttp2_rst_stream_parser_parse(void* parser,
s->stats.incoming.framing_bytes += static_cast<uint64_t>(end - cur);
if (p->byte == 4) {
GPR_ASSERT(is_last);
CHECK(is_last);
uint32_t reason = ((static_cast<uint32_t>(p->reason_bytes[0])) << 24) |
((static_cast<uint32_t>(p->reason_bytes[1])) << 16) |
((static_cast<uint32_t>(p->reason_bytes[2])) << 8) |

@ -20,6 +20,7 @@
#include <stddef.h>
#include "absl/log/check.h"
#include "absl/status/status.h"
#include "absl/strings/str_cat.h"
#include "absl/strings/str_format.h"
@ -37,7 +38,7 @@ grpc_slice grpc_chttp2_window_update_create(
stats->framing_bytes += frame_size;
uint8_t* p = GRPC_SLICE_START_PTR(slice);
GPR_ASSERT(window_delta);
CHECK(window_delta);
*p++ = 0;
*p++ = 0;
@ -93,7 +94,7 @@ grpc_error_handle grpc_chttp2_window_update_parser_parse(
return GRPC_ERROR_CREATE(
absl::StrCat("invalid window update bytes: ", p->amount));
}
GPR_ASSERT(is_last);
CHECK(is_last);
if (t->incoming_stream_id != 0) {
if (s != nullptr) {

@ -21,6 +21,8 @@
#include <algorithm>
#include <cstdint>
#include "absl/log/check.h"
#include <grpc/slice.h>
#include <grpc/slice_buffer.h>
#include <grpc/support/log.h>
@ -61,7 +63,7 @@ static void FillHeader(uint8_t* p, uint8_t type, uint32_t id, size_t len,
// max_frame_size is derived from GRPC_CHTTP2_SETTINGS_MAX_FRAME_SIZE,
// which has a max allowable value of 16777215 (see chttp_transport.cc).
// Thus, the following assert can be a debug assert.
GPR_DEBUG_ASSERT(len <= 16777216);
DCHECK_LE(len, 16777216u);
*p++ = static_cast<uint8_t>(len >> 16);
*p++ = static_cast<uint8_t>(len >> 8);
*p++ = static_cast<uint8_t>(len);

@ -16,16 +16,18 @@
#include <algorithm>
#include "absl/log/check.h"
#include <grpc/support/log.h>
#include <grpc/support/port_platform.h>
namespace grpc_core {
uint32_t HPackEncoderTable::AllocateIndex(size_t element_size) {
GPR_DEBUG_ASSERT(element_size >= 32);
DCHECK_GE(element_size, 32u);
uint32_t new_index = tail_remote_index_ + table_elems_ + 1;
GPR_DEBUG_ASSERT(element_size <= MaxEntrySize());
DCHECK(element_size <= MaxEntrySize());
if (element_size > max_table_size_) {
while (table_size_ > 0) {
@ -40,7 +42,7 @@ uint32_t HPackEncoderTable::AllocateIndex(size_t element_size) {
while (table_size_ + element_size > max_table_size_) {
EvictOne();
}
GPR_ASSERT(table_elems_ < elem_size_.size());
CHECK(table_elems_ < elem_size_.size());
elem_size_[new_index % elem_size_.size()] =
static_cast<uint16_t>(element_size);
table_size_ += element_size;
@ -69,17 +71,17 @@ bool HPackEncoderTable::SetMaxSize(uint32_t max_table_size) {
void HPackEncoderTable::EvictOne() {
tail_remote_index_++;
GPR_ASSERT(tail_remote_index_ > 0);
GPR_ASSERT(table_elems_ > 0);
CHECK_GT(tail_remote_index_, 0u);
CHECK_GT(table_elems_, 0u);
auto removing_size = elem_size_[tail_remote_index_ % elem_size_.size()];
GPR_ASSERT(table_size_ >= removing_size);
CHECK(table_size_ >= removing_size);
table_size_ -= removing_size;
table_elems_--;
}
void HPackEncoderTable::Rebuild(uint32_t capacity) {
decltype(elem_size_) new_elem_size(capacity);
GPR_ASSERT(table_elems_ <= capacity);
CHECK_LE(table_elems_, capacity);
for (uint32_t i = 0; i < table_elems_; i++) {
uint32_t ofs = tail_remote_index_ + i + 1;
new_elem_size[ofs % capacity] = elem_size_[ofs % elem_size_.size()];

@ -16,6 +16,7 @@
#include <stddef.h>
#include "absl/log/check.h"
#include "absl/strings/str_format.h"
#include <grpc/support/port_platform.h>
@ -53,7 +54,7 @@ class MetadataSizeLimitExceededEncoder {
};
absl::Status MakeStreamError(absl::Status error) {
GPR_DEBUG_ASSERT(!error.ok());
DCHECK(!error.ok());
return grpc_error_set_int(std::move(error), StatusIntProperty::kStreamId, 0);
}
} // namespace

@ -21,6 +21,7 @@
#include <string>
#include <utility>
#include "absl/log/check.h"
#include "absl/status/status.h"
#include "absl/strings/str_cat.h"
#include "absl/strings/string_view.h"
@ -193,7 +194,7 @@ class HpackParseResult {
static HpackParseResult InvalidMetadataError(ValidateMetadataResult result,
absl::string_view key) {
GPR_DEBUG_ASSERT(result != ValidateMetadataResult::kOk);
DCHECK(result != ValidateMetadataResult::kOk);
HpackParseResult p{HpackParseStatus::kInvalidMetadata};
p.state_->key = std::string(key);
p.state_->validate_metadata_result = result;

@ -27,6 +27,7 @@
#include <utility>
#include "absl/base/attributes.h"
#include "absl/log/check.h"
#include "absl/status/status.h"
#include "absl/strings/match.h"
#include "absl/strings/str_cat.h"
@ -194,7 +195,7 @@ class HPackParser::Input {
absl::optional<StringPrefix> ParseStringPrefix() {
auto cur = Next();
if (!cur.has_value()) {
GPR_DEBUG_ASSERT(eof_error());
DCHECK(eof_error());
return {};
}
// Huffman if the top bit is 1
@ -205,7 +206,7 @@ class HPackParser::Input {
// all ones ==> varint string length
auto v = ParseVarint(0x7f);
if (!v.has_value()) {
GPR_DEBUG_ASSERT(eof_error());
DCHECK(eof_error());
return {};
}
strlen = *v;
@ -228,7 +229,7 @@ class HPackParser::Input {
// Intended for errors that are specific to a stream and recoverable.
// Callers should ensure that any hpack table updates happen.
void SetErrorAndContinueParsing(HpackParseResult error) {
GPR_DEBUG_ASSERT(error.stream_error());
DCHECK(error.stream_error());
SetError(std::move(error));
}
@ -236,7 +237,7 @@ class HPackParser::Input {
// Intended for unrecoverable errors, with the expectation that they will
// close the connection on return to chttp2.
void SetErrorAndStopParsing(HpackParseResult error) {
GPR_DEBUG_ASSERT(error.connection_error());
DCHECK(error.connection_error());
SetError(std::move(error));
begin_ = end_;
}
@ -245,20 +246,20 @@ class HPackParser::Input {
// min_progress_size: how many bytes beyond the current frontier do we need to
// read prior to being able to get further in this parse.
void UnexpectedEOF(size_t min_progress_size) {
GPR_ASSERT(min_progress_size > 0);
CHECK_GT(min_progress_size, 0u);
if (min_progress_size_ != 0 || error_.connection_error()) {
GPR_DEBUG_ASSERT(eof_error());
DCHECK(eof_error());
return;
}
// Set min progress size, taking into account bytes parsed already but not
// consumed.
min_progress_size_ = min_progress_size + (begin_ - frontier_);
GPR_DEBUG_ASSERT(eof_error());
DCHECK(eof_error());
}
// Update the frontier - signifies we've successfully parsed another element
void UpdateFrontier() {
GPR_DEBUG_ASSERT(skip_bytes_ == 0);
DCHECK_EQ(skip_bytes_, 0u);
frontier_ = begin_;
}
@ -375,7 +376,7 @@ HPackParser::String::StringResult HPackParser::String::ParseUncompressed(
// Check there's enough bytes
if (input->remaining() < length) {
input->UnexpectedEOF(/*min_progress_size=*/length);
GPR_DEBUG_ASSERT(input->eof_error());
DCHECK(input->eof_error());
return StringResult{HpackParseStatus::kEof, wire_size, String{}};
}
auto* refcount = input->slice_refcount();
@ -595,7 +596,7 @@ class HPackParser::Parser {
private:
bool ParseTop() {
GPR_DEBUG_ASSERT(state_.parse_state == ParseState::kTop);
DCHECK(state_.parse_state == ParseState::kTop);
auto cur = *input_->Next();
switch (cur >> 4) {
// Literal header not indexed - First byte format: 0000xxxx
@ -765,7 +766,7 @@ class HPackParser::Parser {
// Parse an index encoded key and a string encoded value
bool StartIdxKey(uint32_t index, bool add_to_table) {
GPR_DEBUG_ASSERT(state_.parse_state == ParseState::kTop);
DCHECK(state_.parse_state == ParseState::kTop);
input_->UpdateFrontier();
const auto* elem = state_.hpack_table.Lookup(index);
if (GPR_UNLIKELY(elem == nullptr)) {
@ -781,14 +782,14 @@ class HPackParser::Parser {
// Parse a varint index encoded key and a string encoded value
bool StartVarIdxKey(uint32_t offset, bool add_to_table) {
GPR_DEBUG_ASSERT(state_.parse_state == ParseState::kTop);
DCHECK(state_.parse_state == ParseState::kTop);
auto index = input_->ParseVarint(offset);
if (GPR_UNLIKELY(!index.has_value())) return false;
return StartIdxKey(*index, add_to_table);
}
bool StartParseLiteralKey(bool add_to_table) {
GPR_DEBUG_ASSERT(state_.parse_state == ParseState::kTop);
DCHECK(state_.parse_state == ParseState::kTop);
state_.add_to_table = add_to_table;
state_.parse_state = ParseState::kParsingKeyLength;
input_->UpdateFrontier();
@ -823,7 +824,7 @@ class HPackParser::Parser {
}
bool ParseKeyLength() {
GPR_DEBUG_ASSERT(state_.parse_state == ParseState::kParsingKeyLength);
DCHECK(state_.parse_state == ParseState::kParsingKeyLength);
auto pfx = input_->ParseStringPrefix();
if (!pfx.has_value()) return false;
state_.is_string_huff_compressed = pfx->huff;
@ -844,14 +845,14 @@ class HPackParser::Parser {
}
bool ParseKeyBody() {
GPR_DEBUG_ASSERT(state_.parse_state == ParseState::kParsingKeyBody);
DCHECK(state_.parse_state == ParseState::kParsingKeyBody);
auto key = String::Parse(input_, state_.is_string_huff_compressed,
state_.string_length);
switch (key.status) {
case HpackParseStatus::kOk:
break;
case HpackParseStatus::kEof:
GPR_DEBUG_ASSERT(input_->eof_error());
DCHECK(input_->eof_error());
return false;
default:
input_->SetErrorAndStopParsing(
@ -891,7 +892,7 @@ class HPackParser::Parser {
}
bool SkipKeyBody() {
GPR_DEBUG_ASSERT(state_.parse_state == ParseState::kSkippingKeyBody);
DCHECK(state_.parse_state == ParseState::kSkippingKeyBody);
if (!SkipStringBody()) return false;
input_->UpdateFrontier();
state_.parse_state = ParseState::kSkippingValueLength;
@ -899,7 +900,7 @@ class HPackParser::Parser {
}
bool SkipValueLength() {
GPR_DEBUG_ASSERT(state_.parse_state == ParseState::kSkippingValueLength);
DCHECK(state_.parse_state == ParseState::kSkippingValueLength);
auto pfx = input_->ParseStringPrefix();
if (!pfx.has_value()) return false;
state_.string_length = pfx->length;
@ -909,7 +910,7 @@ class HPackParser::Parser {
}
bool SkipValueBody() {
GPR_DEBUG_ASSERT(state_.parse_state == ParseState::kSkippingValueBody);
DCHECK(state_.parse_state == ParseState::kSkippingValueBody);
if (!SkipStringBody()) return false;
input_->UpdateFrontier();
state_.parse_state = ParseState::kTop;
@ -920,7 +921,7 @@ class HPackParser::Parser {
}
bool ParseValueLength() {
GPR_DEBUG_ASSERT(state_.parse_state == ParseState::kParsingValueLength);
DCHECK(state_.parse_state == ParseState::kParsingValueLength);
auto pfx = input_->ParseStringPrefix();
if (!pfx.has_value()) return false;
state_.is_string_huff_compressed = pfx->huff;
@ -944,7 +945,7 @@ class HPackParser::Parser {
}
bool ParseValueBody() {
GPR_DEBUG_ASSERT(state_.parse_state == ParseState::kParsingValueBody);
DCHECK(state_.parse_state == ParseState::kParsingValueBody);
auto value =
state_.is_binary_header
? String::ParseBinary(input_, state_.is_string_huff_compressed,
@ -973,7 +974,7 @@ class HPackParser::Parser {
case HpackParseStatus::kOk:
break;
case HpackParseStatus::kEof:
GPR_DEBUG_ASSERT(input_->eof_error());
DCHECK(input_->eof_error());
return false;
default: {
auto result =

@ -25,6 +25,7 @@
#include <cstring>
#include <utility>
#include "absl/log/check.h"
#include "absl/status/status.h"
#include "absl/strings/str_cat.h"
#include "absl/strings/string_view.h"
@ -41,7 +42,7 @@
namespace grpc_core {
void HPackTable::MementoRingBuffer::Put(Memento m) {
GPR_ASSERT(num_entries_ < max_entries_);
CHECK_LT(num_entries_, max_entries_);
if (entries_.size() < max_entries_) {
++num_entries_;
return entries_.push_back(std::move(m));
@ -52,7 +53,7 @@ void HPackTable::MementoRingBuffer::Put(Memento m) {
}
auto HPackTable::MementoRingBuffer::PopOne() -> Memento {
GPR_ASSERT(num_entries_ > 0);
CHECK_GT(num_entries_, 0u);
size_t index = first_entry_ % max_entries_;
++first_entry_;
--num_entries_;
@ -90,7 +91,7 @@ void HPackTable::MementoRingBuffer::ForEach(
// Evict one element from the table
void HPackTable::EvictOne() {
auto first_entry = entries_.PopOne();
GPR_ASSERT(first_entry.md.transport_size() <= mem_used_);
CHECK(first_entry.md.transport_size() <= mem_used_);
mem_used_ -= first_entry.md.transport_size();
}

@ -16,6 +16,8 @@
#include <utility>
#include "absl/log/check.h"
#include <grpc/support/log.h>
#include <grpc/support/port_platform.h>
@ -31,7 +33,7 @@ void Chttp2MaxConcurrentStreamsPolicy::FlushedSettings() {
}
void Chttp2MaxConcurrentStreamsPolicy::AckLastSend() {
GPR_ASSERT(unacked_demerits_ >= sent_demerits_);
CHECK(unacked_demerits_ >= sent_demerits_);
unacked_demerits_ -= std::exchange(sent_demerits_, 0);
}

@ -28,6 +28,7 @@
#include "absl/base/attributes.h"
#include "absl/container/flat_hash_map.h"
#include "absl/log/check.h"
#include "absl/random/bit_gen_ref.h"
#include "absl/status/status.h"
#include "absl/strings/str_cat.h"
@ -267,7 +268,7 @@ absl::variant<size_t, absl::Status> grpc_chttp2_perform_read(
}
ABSL_FALLTHROUGH_INTENDED;
case GRPC_DTS_FH_0:
GPR_DEBUG_ASSERT(cur < end);
DCHECK_LT(cur, end);
t->incoming_frame_size = (static_cast<uint32_t>(*cur)) << 16;
if (++cur == end) {
t->deframe_state = GRPC_DTS_FH_1;
@ -275,7 +276,7 @@ absl::variant<size_t, absl::Status> grpc_chttp2_perform_read(
}
ABSL_FALLTHROUGH_INTENDED;
case GRPC_DTS_FH_1:
GPR_DEBUG_ASSERT(cur < end);
DCHECK_LT(cur, end);
t->incoming_frame_size |= (static_cast<uint32_t>(*cur)) << 8;
if (++cur == end) {
t->deframe_state = GRPC_DTS_FH_2;
@ -283,7 +284,7 @@ absl::variant<size_t, absl::Status> grpc_chttp2_perform_read(
}
ABSL_FALLTHROUGH_INTENDED;
case GRPC_DTS_FH_2:
GPR_DEBUG_ASSERT(cur < end);
DCHECK_LT(cur, end);
t->incoming_frame_size |= *cur;
if (++cur == end) {
t->deframe_state = GRPC_DTS_FH_3;
@ -291,7 +292,7 @@ absl::variant<size_t, absl::Status> grpc_chttp2_perform_read(
}
ABSL_FALLTHROUGH_INTENDED;
case GRPC_DTS_FH_3:
GPR_DEBUG_ASSERT(cur < end);
DCHECK_LT(cur, end);
t->incoming_frame_type = *cur;
if (++cur == end) {
t->deframe_state = GRPC_DTS_FH_4;
@ -299,7 +300,7 @@ absl::variant<size_t, absl::Status> grpc_chttp2_perform_read(
}
ABSL_FALLTHROUGH_INTENDED;
case GRPC_DTS_FH_4:
GPR_DEBUG_ASSERT(cur < end);
DCHECK_LT(cur, end);
t->incoming_frame_flags = *cur;
if (++cur == end) {
t->deframe_state = GRPC_DTS_FH_5;
@ -307,7 +308,7 @@ absl::variant<size_t, absl::Status> grpc_chttp2_perform_read(
}
ABSL_FALLTHROUGH_INTENDED;
case GRPC_DTS_FH_5:
GPR_DEBUG_ASSERT(cur < end);
DCHECK_LT(cur, end);
t->incoming_stream_id = ((static_cast<uint32_t>(*cur)) & 0x7f) << 24;
if (++cur == end) {
t->deframe_state = GRPC_DTS_FH_6;
@ -315,7 +316,7 @@ absl::variant<size_t, absl::Status> grpc_chttp2_perform_read(
}
ABSL_FALLTHROUGH_INTENDED;
case GRPC_DTS_FH_6:
GPR_DEBUG_ASSERT(cur < end);
DCHECK_LT(cur, end);
t->incoming_stream_id |= (static_cast<uint32_t>(*cur)) << 16;
if (++cur == end) {
t->deframe_state = GRPC_DTS_FH_7;
@ -323,7 +324,7 @@ absl::variant<size_t, absl::Status> grpc_chttp2_perform_read(
}
ABSL_FALLTHROUGH_INTENDED;
case GRPC_DTS_FH_7:
GPR_DEBUG_ASSERT(cur < end);
DCHECK_LT(cur, end);
t->incoming_stream_id |= (static_cast<uint32_t>(*cur)) << 8;
if (++cur == end) {
t->deframe_state = GRPC_DTS_FH_8;
@ -331,7 +332,7 @@ absl::variant<size_t, absl::Status> grpc_chttp2_perform_read(
}
ABSL_FALLTHROUGH_INTENDED;
case GRPC_DTS_FH_8:
GPR_DEBUG_ASSERT(cur < end);
DCHECK_LT(cur, end);
t->incoming_stream_id |= (static_cast<uint32_t>(*cur));
if (grpc_http_trace.enabled()) {
gpr_log(GPR_INFO, "INCOMING[%p]: %s len:%d id:0x%08x", t,
@ -366,7 +367,7 @@ absl::variant<size_t, absl::Status> grpc_chttp2_perform_read(
}
ABSL_FALLTHROUGH_INTENDED;
case GRPC_DTS_FRAME:
GPR_DEBUG_ASSERT(cur < end);
DCHECK_LT(cur, end);
if (static_cast<uint32_t>(end - cur) == t->incoming_frame_size) {
err = parse_frame_slice(
t,
@ -729,7 +730,7 @@ static grpc_error_handle init_header_frame_parser(grpc_chttp2_transport* t,
} else {
t->incoming_stream = s;
}
GPR_DEBUG_ASSERT(s != nullptr);
DCHECK_NE(s, nullptr);
s->stats.incoming.framing_bytes += 9;
if (GPR_UNLIKELY(s->read_closed)) {
GRPC_CHTTP2_IF_TRACING(gpr_log(

@ -16,6 +16,7 @@
#include <utility>
#include "absl/log/check.h"
#include "absl/meta/type_traits.h"
#include "absl/random/distributions.h"
@ -95,7 +96,7 @@ absl::optional<uint64_t> Chttp2PingCallbacks::OnPingTimeout(
Duration ping_timeout,
grpc_event_engine::experimental::EventEngine* event_engine,
Callback callback) {
GPR_ASSERT(started_new_ping_without_setting_timeout_);
CHECK(started_new_ping_without_setting_timeout_);
started_new_ping_without_setting_timeout_ = false;
auto it = inflight_.find(most_recent_inflight_);
if (it == inflight_.end()) return absl::nullopt;

@ -16,6 +16,8 @@
//
//
#include "absl/log/check.h"
#include <grpc/support/log.h>
#include <grpc/support/port_platform.h>
@ -57,7 +59,7 @@ static bool stream_list_pop(grpc_chttp2_transport* t,
grpc_chttp2_stream* s = t->lists[id].head;
if (s) {
grpc_chttp2_stream* new_head = s->links[id].next;
GPR_ASSERT(s->included.is_set(id));
CHECK(s->included.is_set(id));
if (new_head) {
t->lists[id].head = new_head;
new_head->links[id].prev = nullptr;
@ -77,12 +79,12 @@ static bool stream_list_pop(grpc_chttp2_transport* t,
static void stream_list_remove(grpc_chttp2_transport* t, grpc_chttp2_stream* s,
grpc_chttp2_stream_list_id id) {
GPR_ASSERT(s->included.is_set(id));
CHECK(s->included.is_set(id));
s->included.clear(id);
if (s->links[id].prev) {
s->links[id].prev->links[id].next = s->links[id].next;
} else {
GPR_ASSERT(t->lists[id].head == s);
CHECK(t->lists[id].head == s);
t->lists[id].head = s->links[id].next;
}
if (s->links[id].next) {
@ -111,7 +113,7 @@ static void stream_list_add_tail(grpc_chttp2_transport* t,
grpc_chttp2_stream* s,
grpc_chttp2_stream_list_id id) {
grpc_chttp2_stream* old_tail;
GPR_ASSERT(!s->included.is_set(id));
CHECK(!s->included.is_set(id));
old_tail = t->lists[id].tail;
s->links[id].next = nullptr;
s->links[id].prev = old_tail;
@ -141,7 +143,7 @@ static bool stream_list_add(grpc_chttp2_transport* t, grpc_chttp2_stream* s,
bool grpc_chttp2_list_add_writable_stream(grpc_chttp2_transport* t,
grpc_chttp2_stream* s) {
GPR_ASSERT(s->id != 0);
CHECK_NE(s->id, 0u);
return stream_list_add(t, s, GRPC_CHTTP2_LIST_WRITABLE);
}

@ -22,6 +22,8 @@
#include <stdint.h>
#include <stdlib.h>
#include "absl/log/check.h"
#include <grpc/support/log.h>
#include <grpc/support/port_platform.h>
@ -49,7 +51,7 @@ class VarintWriter {
explicit VarintWriter(size_t value)
: value_(value),
length_(value < kMaxInPrefix ? 1 : VarintLength(value - kMaxInPrefix)) {
GPR_ASSERT(value <= UINT32_MAX);
CHECK(value <= UINT32_MAX);
}
size_t value() const { return value_; }

@ -16,6 +16,8 @@
#include <algorithm>
#include "absl/log/check.h"
#include <grpc/support/log.h>
#include <grpc/support/port_platform.h>
@ -24,7 +26,7 @@ namespace grpc_core {
size_t Chttp2WriteSizePolicy::WriteTargetSize() { return current_target_; }
void Chttp2WriteSizePolicy::BeginWrite(size_t size) {
GPR_ASSERT(experiment_start_time_ == Timestamp::InfFuture());
CHECK(experiment_start_time_ == Timestamp::InfFuture());
if (size < current_target_ * 7 / 10) {
// If we were trending fast but stopped getting enough data to verify, then
// reset back to the default state.

@ -26,6 +26,7 @@
#include <utility>
#include "absl/container/flat_hash_map.h"
#include "absl/log/check.h"
#include "absl/status/status.h"
#include "absl/types/optional.h"
@ -268,7 +269,7 @@ class WriteContext {
grpc_core::Http2Frame frame(std::move(*update));
Serialize(absl::Span<grpc_core::Http2Frame>(&frame, 1), t_->outbuf);
if (t_->keepalive_timeout != grpc_core::Duration::Infinity()) {
GPR_ASSERT(
CHECK(
t_->settings_ack_watchdog ==
grpc_event_engine::experimental::EventEngine::TaskHandle::kInvalid);
// We base settings timeout on keepalive timeout, but double it to allow
@ -290,7 +291,7 @@ class WriteContext {
// simple writes are queued to qbuf, and flushed here
grpc_slice_buffer_move_into(&t_->qbuf, t_->outbuf.c_slice_buffer());
t_->num_pending_induced_frames = 0;
GPR_ASSERT(t_->qbuf.count == 0);
CHECK_EQ(t_->qbuf.count, 0u);
}
void FlushWindowUpdates() {

@ -20,6 +20,7 @@
#include <list>
#include "absl/log/check.h"
#include "absl/strings/numbers.h"
#include "upb/mem/arena.hpp"
@ -117,13 +118,13 @@ typedef struct alts_grpc_handshaker_client {
static void handshaker_client_send_buffer_destroy(
alts_grpc_handshaker_client* client) {
GPR_ASSERT(client != nullptr);
CHECK_NE(client, nullptr);
grpc_byte_buffer_destroy(client->send_buffer);
client->send_buffer = nullptr;
}
static bool is_handshake_finished_properly(grpc_gcp_HandshakerResp* resp) {
GPR_ASSERT(resp != nullptr);
CHECK_NE(resp, nullptr);
return grpc_gcp_HandshakerResp_result(resp) != nullptr;
}
@ -156,7 +157,7 @@ static void maybe_complete_tsi_next(
grpc_core::MutexLock lock(&client->mu);
client->receive_status_finished |= receive_status_finished;
if (pending_recv_message_result != nullptr) {
GPR_ASSERT(client->pending_recv_message_result == nullptr);
CHECK_EQ(client->pending_recv_message_result, nullptr);
client->pending_recv_message_result = pending_recv_message_result;
}
if (client->pending_recv_message_result == nullptr) {
@ -197,7 +198,7 @@ static void handle_response_done(alts_grpc_handshaker_client* client,
void alts_handshaker_client_handle_response(alts_handshaker_client* c,
bool is_ok) {
GPR_ASSERT(c != nullptr);
CHECK_NE(c, nullptr);
alts_grpc_handshaker_client* client =
reinterpret_cast<alts_grpc_handshaker_client*>(c);
grpc_byte_buffer* recv_buffer = client->recv_buffer;
@ -312,7 +313,7 @@ void alts_handshaker_client_handle_response(alts_handshaker_client* c,
static tsi_result continue_make_grpc_call(alts_grpc_handshaker_client* client,
bool is_start) {
GPR_ASSERT(client != nullptr);
CHECK_NE(client, nullptr);
grpc_op ops[kHandshakerClientOpNum];
memset(ops, 0, sizeof(ops));
grpc_op* op = ops;
@ -325,34 +326,34 @@ static tsi_result continue_make_grpc_call(alts_grpc_handshaker_client* client,
op->flags = 0;
op->reserved = nullptr;
op++;
GPR_ASSERT(op - ops <= kHandshakerClientOpNum);
CHECK(op - ops <= kHandshakerClientOpNum);
gpr_ref(&client->refs);
grpc_call_error call_error =
client->grpc_caller(client->call, ops, static_cast<size_t>(op - ops),
&client->on_status_received);
// TODO(apolcyn): return the error here instead, as done for other ops?
GPR_ASSERT(call_error == GRPC_CALL_OK);
CHECK_EQ(call_error, GRPC_CALL_OK);
memset(ops, 0, sizeof(ops));
op = ops;
op->op = GRPC_OP_SEND_INITIAL_METADATA;
op->data.send_initial_metadata.count = 0;
op++;
GPR_ASSERT(op - ops <= kHandshakerClientOpNum);
CHECK(op - ops <= kHandshakerClientOpNum);
op->op = GRPC_OP_RECV_INITIAL_METADATA;
op->data.recv_initial_metadata.recv_initial_metadata =
&client->recv_initial_metadata;
op++;
GPR_ASSERT(op - ops <= kHandshakerClientOpNum);
CHECK(op - ops <= kHandshakerClientOpNum);
}
op->op = GRPC_OP_SEND_MESSAGE;
op->data.send_message.send_message = client->send_buffer;
op++;
GPR_ASSERT(op - ops <= kHandshakerClientOpNum);
CHECK(op - ops <= kHandshakerClientOpNum);
op->op = GRPC_OP_RECV_MESSAGE;
op->data.recv_message.recv_message = &client->recv_buffer;
op++;
GPR_ASSERT(op - ops <= kHandshakerClientOpNum);
GPR_ASSERT(client->grpc_caller != nullptr);
CHECK(op - ops <= kHandshakerClientOpNum);
CHECK_NE(client->grpc_caller, nullptr);
if (client->grpc_caller(client->call, ops, static_cast<size_t>(op - ops),
&client->on_handshaker_service_resp_recv) !=
GRPC_CALL_OK) {
@ -450,7 +451,7 @@ void HandshakeDone(bool is_client) {
/// make a grpc call.
///
static tsi_result make_grpc_call(alts_handshaker_client* c, bool is_start) {
GPR_ASSERT(c != nullptr);
CHECK_NE(c, nullptr);
alts_grpc_handshaker_client* client =
reinterpret_cast<alts_grpc_handshaker_client*>(c);
if (is_start) {
@ -500,7 +501,7 @@ static grpc_byte_buffer* get_serialized_handshaker_req(
// Create and populate a client_start handshaker request, then serialize it.
static grpc_byte_buffer* get_serialized_start_client(
alts_handshaker_client* c) {
GPR_ASSERT(c != nullptr);
CHECK_NE(c, nullptr);
alts_grpc_handshaker_client* client =
reinterpret_cast<alts_grpc_handshaker_client*>(c);
upb::Arena arena;
@ -565,8 +566,8 @@ static tsi_result handshaker_client_start_client(alts_handshaker_client* c) {
// Create and populate a start_server handshaker request, then serialize it.
static grpc_byte_buffer* get_serialized_start_server(
alts_handshaker_client* c, grpc_slice* bytes_received) {
GPR_ASSERT(c != nullptr);
GPR_ASSERT(bytes_received != nullptr);
CHECK_NE(c, nullptr);
CHECK_NE(bytes_received, nullptr);
alts_grpc_handshaker_client* client =
reinterpret_cast<alts_grpc_handshaker_client*>(c);
@ -623,7 +624,7 @@ static tsi_result handshaker_client_start_server(alts_handshaker_client* c,
// Create and populate a next handshaker request, then serialize it.
static grpc_byte_buffer* get_serialized_next(grpc_slice* bytes_received) {
GPR_ASSERT(bytes_received != nullptr);
CHECK_NE(bytes_received, nullptr);
upb::Arena arena;
grpc_gcp_HandshakerReq* req = grpc_gcp_HandshakerReq_new(arena.ptr());
grpc_gcp_NextHandshakeMessageReq* next =
@ -661,7 +662,7 @@ static tsi_result handshaker_client_next(alts_handshaker_client* c,
}
static void handshaker_client_shutdown(alts_handshaker_client* c) {
GPR_ASSERT(c != nullptr);
CHECK_NE(c, nullptr);
alts_grpc_handshaker_client* client =
reinterpret_cast<alts_grpc_handshaker_client*>(c);
if (client->call != nullptr) {
@ -759,7 +760,8 @@ namespace internal {
void alts_handshaker_client_set_grpc_caller_for_testing(
alts_handshaker_client* c, alts_grpc_caller caller) {
GPR_ASSERT(c != nullptr && caller != nullptr);
CHECK(c != nullptr);
CHECK_NE(caller, nullptr);
alts_grpc_handshaker_client* client =
reinterpret_cast<alts_grpc_handshaker_client*>(c);
client->grpc_caller = caller;
@ -767,7 +769,7 @@ void alts_handshaker_client_set_grpc_caller_for_testing(
grpc_byte_buffer* alts_handshaker_client_get_send_buffer_for_testing(
alts_handshaker_client* c) {
GPR_ASSERT(c != nullptr);
CHECK_NE(c, nullptr);
alts_grpc_handshaker_client* client =
reinterpret_cast<alts_grpc_handshaker_client*>(c);
return client->send_buffer;
@ -775,7 +777,7 @@ grpc_byte_buffer* alts_handshaker_client_get_send_buffer_for_testing(
grpc_byte_buffer** alts_handshaker_client_get_recv_buffer_addr_for_testing(
alts_handshaker_client* c) {
GPR_ASSERT(c != nullptr);
CHECK_NE(c, nullptr);
alts_grpc_handshaker_client* client =
reinterpret_cast<alts_grpc_handshaker_client*>(c);
return &client->recv_buffer;
@ -783,7 +785,7 @@ grpc_byte_buffer** alts_handshaker_client_get_recv_buffer_addr_for_testing(
grpc_metadata_array* alts_handshaker_client_get_initial_metadata_for_testing(
alts_handshaker_client* c) {
GPR_ASSERT(c != nullptr);
CHECK_NE(c, nullptr);
alts_grpc_handshaker_client* client =
reinterpret_cast<alts_grpc_handshaker_client*>(c);
return &client->recv_initial_metadata;
@ -791,7 +793,7 @@ grpc_metadata_array* alts_handshaker_client_get_initial_metadata_for_testing(
void alts_handshaker_client_set_recv_bytes_for_testing(
alts_handshaker_client* c, grpc_slice* recv_bytes) {
GPR_ASSERT(c != nullptr);
CHECK_NE(c, nullptr);
alts_grpc_handshaker_client* client =
reinterpret_cast<alts_grpc_handshaker_client*>(c);
client->recv_bytes = CSliceRef(*recv_bytes);
@ -801,7 +803,7 @@ void alts_handshaker_client_set_fields_for_testing(
alts_handshaker_client* c, alts_tsi_handshaker* handshaker,
tsi_handshaker_on_next_done_cb cb, void* user_data,
grpc_byte_buffer* recv_buffer, bool inject_read_failure) {
GPR_ASSERT(c != nullptr);
CHECK_NE(c, nullptr);
alts_grpc_handshaker_client* client =
reinterpret_cast<alts_grpc_handshaker_client*>(c);
client->handshaker = handshaker;
@ -814,22 +816,22 @@ void alts_handshaker_client_set_fields_for_testing(
void alts_handshaker_client_check_fields_for_testing(
alts_handshaker_client* c, tsi_handshaker_on_next_done_cb cb,
void* user_data, bool has_sent_start_message, grpc_slice* recv_bytes) {
GPR_ASSERT(c != nullptr);
CHECK_NE(c, nullptr);
alts_grpc_handshaker_client* client =
reinterpret_cast<alts_grpc_handshaker_client*>(c);
GPR_ASSERT(client->cb == cb);
GPR_ASSERT(client->user_data == user_data);
CHECK(client->cb == cb);
CHECK(client->user_data == user_data);
if (recv_bytes != nullptr) {
GPR_ASSERT(grpc_slice_cmp(client->recv_bytes, *recv_bytes) == 0);
CHECK_EQ(grpc_slice_cmp(client->recv_bytes, *recv_bytes), 0);
}
GPR_ASSERT(alts_tsi_handshaker_get_has_sent_start_message_for_testing(
client->handshaker) == has_sent_start_message);
CHECK(alts_tsi_handshaker_get_has_sent_start_message_for_testing(
client->handshaker) == has_sent_start_message);
}
void alts_handshaker_client_set_vtable_for_testing(
alts_handshaker_client* c, alts_handshaker_client_vtable* vtable) {
GPR_ASSERT(c != nullptr);
GPR_ASSERT(vtable != nullptr);
CHECK_NE(c, nullptr);
CHECK_NE(vtable, nullptr);
alts_grpc_handshaker_client* client =
reinterpret_cast<alts_grpc_handshaker_client*>(c);
client->base.vtable = vtable;
@ -837,7 +839,7 @@ void alts_handshaker_client_set_vtable_for_testing(
alts_tsi_handshaker* alts_handshaker_client_get_handshaker_for_testing(
alts_handshaker_client* c) {
GPR_ASSERT(c != nullptr);
CHECK_NE(c, nullptr);
alts_grpc_handshaker_client* client =
reinterpret_cast<alts_grpc_handshaker_client*>(c);
return client->handshaker;
@ -845,7 +847,7 @@ alts_tsi_handshaker* alts_handshaker_client_get_handshaker_for_testing(
void alts_handshaker_client_set_cb_for_testing(
alts_handshaker_client* c, tsi_handshaker_on_next_done_cb cb) {
GPR_ASSERT(c != nullptr);
CHECK_NE(c, nullptr);
alts_grpc_handshaker_client* client =
reinterpret_cast<alts_grpc_handshaker_client*>(c);
client->cb = cb;
@ -853,7 +855,7 @@ void alts_handshaker_client_set_cb_for_testing(
grpc_closure* alts_handshaker_client_get_closure_for_testing(
alts_handshaker_client* c) {
GPR_ASSERT(c != nullptr);
CHECK_NE(c, nullptr);
alts_grpc_handshaker_client* client =
reinterpret_cast<alts_grpc_handshaker_client*>(c);
return &client->on_handshaker_service_resp_recv;

@ -18,6 +18,8 @@
#include "src/core/tsi/alts/handshaker/alts_shared_resource.h"
#include "absl/log/check.h"
#include <grpc/support/log.h>
#include <grpc/support/port_platform.h>
@ -36,11 +38,11 @@ static void thread_worker(void* /*arg*/) {
grpc_event event =
grpc_completion_queue_next(g_alts_resource_dedicated.cq,
gpr_inf_future(GPR_CLOCK_REALTIME), nullptr);
GPR_ASSERT(event.type != GRPC_QUEUE_TIMEOUT);
CHECK(event.type != GRPC_QUEUE_TIMEOUT);
if (event.type == GRPC_QUEUE_SHUTDOWN) {
break;
}
GPR_ASSERT(event.type == GRPC_OP_COMPLETE);
CHECK(event.type == GRPC_OP_COMPLETE);
alts_handshaker_client* client =
static_cast<alts_handshaker_client*>(event.tag);
alts_handshaker_client_handle_response(client, event.success);

@ -22,6 +22,7 @@
#include <stdlib.h>
#include <string.h>
#include "absl/log/check.h"
#include "upb/mem/arena.hpp"
#include <grpc/credentials.h>
@ -92,14 +93,14 @@ static tsi_result handshaker_result_extract_peer(
alts_tsi_handshaker_result* result =
reinterpret_cast<alts_tsi_handshaker_result*>(
const_cast<tsi_handshaker_result*>(self));
GPR_ASSERT(kTsiAltsNumOfPeerProperties == 5);
CHECK_EQ(kTsiAltsNumOfPeerProperties, 5u);
tsi_result ok = tsi_construct_peer(kTsiAltsNumOfPeerProperties, peer);
int index = 0;
if (ok != TSI_OK) {
gpr_log(GPR_ERROR, "Failed to construct tsi peer");
return ok;
}
GPR_ASSERT(&peer->properties[index] != nullptr);
CHECK_NE(&peer->properties[index], nullptr);
ok = tsi_construct_string_peer_property_from_cstring(
TSI_CERTIFICATE_TYPE_PEER_PROPERTY, TSI_ALTS_CERTIFICATE_TYPE,
&peer->properties[index]);
@ -109,7 +110,7 @@ static tsi_result handshaker_result_extract_peer(
return ok;
}
index++;
GPR_ASSERT(&peer->properties[index] != nullptr);
CHECK_NE(&peer->properties[index], nullptr);
ok = tsi_construct_string_peer_property_from_cstring(
TSI_ALTS_SERVICE_ACCOUNT_PEER_PROPERTY, result->peer_identity,
&peer->properties[index]);
@ -118,7 +119,7 @@ static tsi_result handshaker_result_extract_peer(
gpr_log(GPR_ERROR, "Failed to set tsi peer property");
}
index++;
GPR_ASSERT(&peer->properties[index] != nullptr);
CHECK_NE(&peer->properties[index], nullptr);
ok = tsi_construct_string_peer_property(
TSI_ALTS_RPC_VERSIONS,
reinterpret_cast<char*>(GRPC_SLICE_START_PTR(result->rpc_versions)),
@ -128,7 +129,7 @@ static tsi_result handshaker_result_extract_peer(
gpr_log(GPR_ERROR, "Failed to set tsi peer property");
}
index++;
GPR_ASSERT(&peer->properties[index] != nullptr);
CHECK_NE(&peer->properties[index], nullptr);
ok = tsi_construct_string_peer_property(
TSI_ALTS_CONTEXT,
reinterpret_cast<char*>(GRPC_SLICE_START_PTR(result->serialized_context)),
@ -138,7 +139,7 @@ static tsi_result handshaker_result_extract_peer(
gpr_log(GPR_ERROR, "Failed to set tsi peer property");
}
index++;
GPR_ASSERT(&peer->properties[index] != nullptr);
CHECK_NE(&peer->properties[index], nullptr);
ok = tsi_construct_string_peer_property_from_cstring(
TSI_SECURITY_LEVEL_PEER_PROPERTY,
tsi_security_level_to_string(TSI_PRIVACY_AND_INTEGRITY),
@ -147,7 +148,7 @@ static tsi_result handshaker_result_extract_peer(
tsi_peer_destruct(peer);
gpr_log(GPR_ERROR, "Failed to set tsi peer property");
}
GPR_ASSERT(++index == kTsiAltsNumOfPeerProperties);
CHECK(++index == kTsiAltsNumOfPeerProperties);
return ok;
}
@ -423,7 +424,7 @@ static tsi_result alts_tsi_handshaker_continue_handshaker_next(
handshaker->handshaker_service_url);
handshaker->interested_parties =
grpc_alts_get_shared_resource_dedicated()->interested_parties;
GPR_ASSERT(handshaker->interested_parties != nullptr);
CHECK_NE(handshaker->interested_parties, nullptr);
}
grpc_iomgr_cb_func grpc_cb = handshaker->channel == nullptr
? on_handshaker_service_resp_recv_dedicated
@ -445,7 +446,7 @@ static tsi_result alts_tsi_handshaker_continue_handshaker_next(
}
{
grpc_core::MutexLock lock(&handshaker->mu);
GPR_ASSERT(handshaker->client == nullptr);
CHECK_EQ(handshaker->client, nullptr);
handshaker->client = client;
if (handshaker->shutdown) {
gpr_log(GPR_INFO, "TSI handshake shutdown");
@ -457,8 +458,8 @@ static tsi_result alts_tsi_handshaker_continue_handshaker_next(
}
if (handshaker->channel == nullptr &&
handshaker->client_vtable_for_testing == nullptr) {
GPR_ASSERT(grpc_cq_begin_op(grpc_alts_get_shared_resource_dedicated()->cq,
handshaker->client));
CHECK(grpc_cq_begin_op(grpc_alts_get_shared_resource_dedicated()->cq,
handshaker->client));
}
grpc_slice slice = (received_bytes == nullptr || received_bytes_size == 0)
? grpc_empty_slice()
@ -500,7 +501,7 @@ static void alts_tsi_handshaker_create_channel(
alts_tsi_handshaker_continue_handshaker_next_args* next_args =
static_cast<alts_tsi_handshaker_continue_handshaker_next_args*>(arg);
alts_tsi_handshaker* handshaker = next_args->handshaker;
GPR_ASSERT(handshaker->channel == nullptr);
CHECK_EQ(handshaker->channel, nullptr);
grpc_channel_credentials* creds = grpc_insecure_credentials_create();
// Disable retries so that we quickly get a signal when the
// handshake server is not reachable.
@ -592,7 +593,7 @@ static tsi_result handshaker_next_dedicated(
}
static void handshaker_shutdown(tsi_handshaker* self) {
GPR_ASSERT(self != nullptr);
CHECK_NE(self, nullptr);
alts_tsi_handshaker* handshaker =
reinterpret_cast<alts_tsi_handshaker*>(self);
grpc_core::MutexLock lock(&handshaker->mu);
@ -638,7 +639,7 @@ static const tsi_handshaker_vtable handshaker_vtable_dedicated = {
handshaker_shutdown};
bool alts_tsi_handshaker_has_shutdown(alts_tsi_handshaker* handshaker) {
GPR_ASSERT(handshaker != nullptr);
CHECK_NE(handshaker, nullptr);
grpc_core::MutexLock lock(&handshaker->mu);
return handshaker->shutdown;
}
@ -676,7 +677,8 @@ tsi_result alts_tsi_handshaker_create(
void alts_tsi_handshaker_result_set_unused_bytes(tsi_handshaker_result* result,
grpc_slice* recv_bytes,
size_t bytes_consumed) {
GPR_ASSERT(recv_bytes != nullptr && result != nullptr);
CHECK(recv_bytes != nullptr);
CHECK_NE(result, nullptr);
if (GRPC_SLICE_LENGTH(*recv_bytes) == bytes_consumed) {
return;
}
@ -695,19 +697,19 @@ namespace internal {
bool alts_tsi_handshaker_get_has_sent_start_message_for_testing(
alts_tsi_handshaker* handshaker) {
GPR_ASSERT(handshaker != nullptr);
CHECK_NE(handshaker, nullptr);
return handshaker->has_sent_start_message;
}
void alts_tsi_handshaker_set_client_vtable_for_testing(
alts_tsi_handshaker* handshaker, alts_handshaker_client_vtable* vtable) {
GPR_ASSERT(handshaker != nullptr);
CHECK_NE(handshaker, nullptr);
handshaker->client_vtable_for_testing = vtable;
}
bool alts_tsi_handshaker_get_is_client_for_testing(
alts_tsi_handshaker* handshaker) {
GPR_ASSERT(handshaker != nullptr);
CHECK_NE(handshaker, nullptr);
return handshaker->is_client;
}

@ -18,6 +18,8 @@
#include "src/core/tsi/alts/handshaker/alts_tsi_utils.h"
#include "absl/log/check.h"
#include <grpc/byte_buffer_reader.h>
#include <grpc/support/port_platform.h>
@ -43,8 +45,8 @@ tsi_result alts_tsi_utils_convert_to_tsi_result(grpc_status_code code) {
grpc_gcp_HandshakerResp* alts_tsi_utils_deserialize_response(
grpc_byte_buffer* resp_buffer, upb_Arena* arena) {
GPR_ASSERT(resp_buffer != nullptr);
GPR_ASSERT(arena != nullptr);
CHECK_NE(resp_buffer, nullptr);
CHECK_NE(arena, nullptr);
grpc_byte_buffer_reader bbr;
grpc_byte_buffer_reader_init(&bbr, resp_buffer);
grpc_slice slice = grpc_byte_buffer_reader_readall(&bbr);

@ -20,6 +20,8 @@
#include <string.h>
#include "absl/log/check.h"
#include <grpc/support/alloc.h>
#include <grpc/support/log.h>
#include <grpc/support/port_platform.h>
@ -142,14 +144,14 @@ static tsi_result alts_grpc_integrity_only_unprotect(
grpc_slice_buffer_reset_and_unref(&rp->header_sb);
grpc_slice_buffer_move_first(protected_slices, rp->header_length,
&rp->header_sb);
GPR_ASSERT(rp->header_sb.length == rp->header_length);
CHECK(rp->header_sb.length == rp->header_length);
iovec_t header_iovec = alts_grpc_record_protocol_get_header_iovec(rp);
// Moves protected slices data to data_sb and leaves the remaining tag.
grpc_slice_buffer_reset_and_unref(&integrity_only_record_protocol->data_sb);
grpc_slice_buffer_move_first(protected_slices,
protected_slices->length - rp->tag_length,
&integrity_only_record_protocol->data_sb);
GPR_ASSERT(protected_slices->length == rp->tag_length);
CHECK(protected_slices->length == rp->tag_length);
iovec_t tag_iovec = {nullptr, rp->tag_length};
if (protected_slices->count == 1) {
tag_iovec.iov_base = GRPC_SLICE_START_PTR(protected_slices->slices[0]);

@ -20,6 +20,8 @@
#include <string.h>
#include "absl/log/check.h"
#include <grpc/support/alloc.h>
#include <grpc/support/log.h>
#include <grpc/support/port_platform.h>
@ -34,7 +36,8 @@ const size_t kInitialIovecBufferSize = 8;
// Makes sure iovec_buf in alts_grpc_record_protocol is large enough.
static void ensure_iovec_buf_size(alts_grpc_record_protocol* rp,
const grpc_slice_buffer* sb) {
GPR_ASSERT(rp != nullptr && sb != nullptr);
CHECK(rp != nullptr);
CHECK_NE(sb, nullptr);
if (sb->count <= rp->iovec_buf_length) {
return;
}
@ -49,7 +52,8 @@ static void ensure_iovec_buf_size(alts_grpc_record_protocol* rp,
void alts_grpc_record_protocol_convert_slice_buffer_to_iovec(
alts_grpc_record_protocol* rp, const grpc_slice_buffer* sb) {
GPR_ASSERT(rp != nullptr && sb != nullptr);
CHECK(rp != nullptr);
CHECK_NE(sb, nullptr);
ensure_iovec_buf_size(rp, sb);
for (size_t i = 0; i < sb->count; i++) {
rp->iovec_buf[i].iov_base = GRPC_SLICE_START_PTR(sb->slices[i]);
@ -59,7 +63,8 @@ void alts_grpc_record_protocol_convert_slice_buffer_to_iovec(
void alts_grpc_record_protocol_copy_slice_buffer(const grpc_slice_buffer* src,
unsigned char* dst) {
GPR_ASSERT(src != nullptr && dst != nullptr);
CHECK(src != nullptr);
CHECK_NE(dst, nullptr);
for (size_t i = 0; i < src->count; i++) {
size_t slice_length = GRPC_SLICE_LENGTH(src->slices[i]);
memcpy(dst, GRPC_SLICE_START_PTR(src->slices[i]), slice_length);

@ -23,6 +23,8 @@
#include <memory>
#include <utility>
#include "absl/log/check.h"
#include <grpc/support/alloc.h>
#include <grpc/support/log.h>
#include <grpc/support/port_platform.h>
@ -84,7 +86,7 @@ static bool read_frame_size(const grpc_slice_buffer* sb,
remaining -= slice_length;
}
}
GPR_ASSERT(remaining == 0);
CHECK_EQ(remaining, 0u);
// Gets little-endian frame size.
uint32_t frame_size = (static_cast<uint32_t>(frame_size_buffer[3]) << 24) |
(static_cast<uint32_t>(frame_size_buffer[2]) << 16) |
@ -294,7 +296,7 @@ tsi_result alts_zero_copy_grpc_protector_create(
impl->max_unprotected_data_size =
alts_grpc_record_protocol_max_unprotected_data_size(
impl->record_protocol, max_protected_frame_size_to_set);
GPR_ASSERT(impl->max_unprotected_data_size > 0);
CHECK_GT(impl->max_unprotected_data_size, 0u);
// Allocates internal slice buffers.
grpc_slice_buffer_init(&impl->unprotected_staging_sb);
grpc_slice_buffer_init(&impl->protected_sb);

@ -21,6 +21,8 @@
#include <stdlib.h>
#include <string.h>
#include "absl/log/check.h"
#include <grpc/support/alloc.h>
#include <grpc/support/log.h>
#include <grpc/support/port_platform.h>
@ -124,7 +126,8 @@ static void store32_little_endian(uint32_t value, unsigned char* buf) {
}
static uint32_t read_frame_size(const grpc_slice_buffer* sb) {
GPR_ASSERT(sb != nullptr && sb->length >= TSI_FAKE_FRAME_HEADER_SIZE);
CHECK(sb != nullptr);
CHECK(sb->length >= TSI_FAKE_FRAME_HEADER_SIZE);
uint8_t frame_size_buffer[TSI_FAKE_FRAME_HEADER_SIZE];
uint8_t* buf = frame_size_buffer;
// Copies the first 4 bytes to a temporary buffer.
@ -141,7 +144,7 @@ static uint32_t read_frame_size(const grpc_slice_buffer* sb) {
remaining -= slice_length;
}
}
GPR_ASSERT(remaining == 0);
CHECK_EQ(remaining, 0u);
return load32_little_endian(frame_size_buffer);
}

@ -16,6 +16,8 @@
#include <map>
#include "absl/log/check.h"
#include <grpc/support/log.h>
#include <grpc/support/port_platform.h>
@ -47,8 +49,8 @@ TlsSessionKeyLoggerCache::TlsSessionKeyLogger::TlsSessionKeyLogger(
grpc_core::RefCountedPtr<TlsSessionKeyLoggerCache> cache)
: tls_session_key_log_file_path_(std::move(tls_session_key_log_file_path)),
cache_(std::move(cache)) {
GPR_ASSERT(!tls_session_key_log_file_path_.empty());
GPR_ASSERT(cache_ != nullptr);
CHECK(!tls_session_key_log_file_path_.empty());
CHECK(cache_ != nullptr);
fd_ = fopen(tls_session_key_log_file_path_.c_str(), "a");
if (fd_ == nullptr) {
grpc_error_handle error = GRPC_OS_ERROR(errno, "fopen");
@ -109,7 +111,7 @@ TlsSessionKeyLoggerCache::~TlsSessionKeyLoggerCache() {
grpc_core::RefCountedPtr<TlsSessionKeyLogger> TlsSessionKeyLoggerCache::Get(
std::string tls_session_key_log_file_path) {
gpr_once_init(&g_cache_mutex_init, do_cache_mutex_init);
GPR_DEBUG_ASSERT(g_tls_session_key_log_cache_mu != nullptr);
DCHECK_NE(g_tls_session_key_log_cache_mu, nullptr);
if (tls_session_key_log_file_path.empty()) {
return nullptr;
}

@ -18,6 +18,8 @@
#include "src/core/tsi/ssl/session_cache/ssl_session_cache.h"
#include "absl/log/check.h"
#include <grpc/support/log.h>
#include <grpc/support/port_platform.h>
#include <grpc/support/string_util.h>
@ -112,7 +114,7 @@ void SslSessionLRUCache::Put(const char* key, SslSessionPtr session) {
entry_by_key_.emplace(key, node);
AssertInvariants();
if (use_order_list_size_ > capacity_) {
GPR_ASSERT(use_order_list_tail_);
CHECK(use_order_list_tail_);
node = use_order_list_tail_;
Remove(node);
// Order matters, key is destroyed after deleting node.
@ -143,7 +145,7 @@ void SslSessionLRUCache::Remove(SslSessionLRUCache::Node* node) {
} else {
node->next_->prev_ = node->prev_;
}
GPR_ASSERT(use_order_list_size_ >= 1);
CHECK_GE(use_order_list_size_, 1u);
use_order_list_size_--;
}
@ -169,16 +171,16 @@ void SslSessionLRUCache::AssertInvariants() {
Node* current = use_order_list_head_;
while (current != nullptr) {
size++;
GPR_ASSERT(current->prev_ == prev);
CHECK(current->prev_ == prev);
auto it = entry_by_key_.find(current->key());
GPR_ASSERT(it != entry_by_key_.end());
GPR_ASSERT(it->second == current);
CHECK(it != entry_by_key_.end());
CHECK(it->second == current);
prev = current;
current = current->next_;
}
GPR_ASSERT(prev == use_order_list_tail_);
GPR_ASSERT(size == use_order_list_size_);
GPR_ASSERT(entry_by_key_.size() == use_order_list_size_);
CHECK(prev == use_order_list_tail_);
CHECK(size == use_order_list_size_);
CHECK(entry_by_key_.size() == use_order_list_size_);
}
#else
void SslSessionLRUCache::AssertInvariants() {}

@ -15,8 +15,8 @@
// limitations under the License.
//
//
#include "absl/log/check.h"
#include <grpc/support/log.h>
#include <grpc/support/port_platform.h>
#include "src/core/lib/gprpp/crash.h"
@ -43,11 +43,11 @@ class OpenSslCachedSession : public SslCachedSession {
public:
OpenSslCachedSession(SslSessionPtr session) {
int size = i2d_SSL_SESSION(session.get(), nullptr);
GPR_ASSERT(size > 0);
CHECK_GT(size, 0);
grpc_slice slice = grpc_slice_malloc(size_t(size));
unsigned char* start = GRPC_SLICE_START_PTR(slice);
int second_size = i2d_SSL_SESSION(session.get(), &start);
GPR_ASSERT(size == second_size);
CHECK(size == second_size);
serialized_session_ = slice;
}

@ -45,6 +45,7 @@
#include <openssl/x509.h>
#include <openssl/x509v3.h>
#include "absl/log/check.h"
#include "absl/strings/match.h"
#include "absl/strings/str_cat.h"
#include "absl/strings/string_view.h"
@ -194,7 +195,7 @@ static void init_openssl(void) {
#if OPENSSL_VERSION_NUMBER < 0x10100000
if (!CRYPTO_get_locking_callback()) {
int num_locks = CRYPTO_num_locks();
GPR_ASSERT(num_locks > 0);
CHECK_GT(num_locks, 0);
g_openssl_mutexes = static_cast<gpr_mu*>(
gpr_malloc(static_cast<size_t>(num_locks) * sizeof(gpr_mu)));
for (int i = 0; i < num_locks; i++) {
@ -208,15 +209,15 @@ static void init_openssl(void) {
#endif
g_ssl_ctx_ex_factory_index =
SSL_CTX_get_ex_new_index(0, nullptr, nullptr, nullptr, nullptr);
GPR_ASSERT(g_ssl_ctx_ex_factory_index != -1);
CHECK_NE(g_ssl_ctx_ex_factory_index, -1);
g_ssl_ctx_ex_crl_provider_index =
SSL_CTX_get_ex_new_index(0, nullptr, nullptr, nullptr, nullptr);
GPR_ASSERT(g_ssl_ctx_ex_crl_provider_index != -1);
CHECK_NE(g_ssl_ctx_ex_crl_provider_index, -1);
g_ssl_ex_verified_root_cert_index = SSL_get_ex_new_index(
0, nullptr, nullptr, nullptr, verified_root_cert_free);
GPR_ASSERT(g_ssl_ex_verified_root_cert_index != -1);
CHECK_NE(g_ssl_ex_verified_root_cert_index, -1);
}
// --- Ssl utils. ---
@ -475,7 +476,7 @@ static tsi_result peer_from_x509(X509* cert, int include_certificate_type,
: 0;
size_t property_count;
tsi_result result;
GPR_ASSERT(subject_alt_name_count >= 0);
CHECK_GE(subject_alt_name_count, 0);
property_count = (include_certificate_type ? size_t{1} : 0) +
3 /* subject, common name, certificate */ +
static_cast<size_t>(subject_alt_name_count);
@ -530,7 +531,7 @@ static tsi_result peer_from_x509(X509* cert, int include_certificate_type,
}
if (result != TSI_OK) tsi_peer_destruct(peer);
GPR_ASSERT((int)peer->property_count == current_insert_index);
CHECK((int)peer->property_count == current_insert_index);
return result;
}
@ -541,7 +542,7 @@ static tsi_result ssl_ctx_use_certificate_chain(SSL_CTX* context,
tsi_result result = TSI_OK;
X509* certificate = nullptr;
BIO* pem;
GPR_ASSERT(pem_cert_chain_size <= INT_MAX);
CHECK_LE(pem_cert_chain_size, static_cast<size_t>(INT_MAX));
pem = BIO_new_mem_buf(pem_cert_chain, static_cast<int>(pem_cert_chain_size));
if (pem == nullptr) return TSI_OUT_OF_RESOURCES;
@ -661,7 +662,7 @@ static tsi_result ssl_ctx_use_pem_private_key(SSL_CTX* context,
tsi_result result = TSI_OK;
EVP_PKEY* private_key = nullptr;
BIO* pem;
GPR_ASSERT(pem_key_size <= INT_MAX);
CHECK_LE(pem_key_size, static_cast<size_t>(INT_MAX));
pem = BIO_new_mem_buf(pem_key, static_cast<int>(pem_key_size));
if (pem == nullptr) return TSI_OUT_OF_RESOURCES;
do {
@ -706,7 +707,7 @@ static tsi_result x509_store_load_certs(X509_STORE* cert_store,
X509* root = nullptr;
X509_NAME* root_name = nullptr;
BIO* pem;
GPR_ASSERT(pem_roots_size <= INT_MAX);
CHECK_LE(pem_roots_size, static_cast<size_t>(INT_MAX));
pem = BIO_new_mem_buf(pem_roots, static_cast<int>(pem_roots_size));
if (cert_store == nullptr) return TSI_INVALID_ARGUMENT;
if (pem == nullptr) return TSI_OUT_OF_RESOURCES;
@ -1372,7 +1373,7 @@ static tsi_ssl_handshaker_factory_vtable handshaker_factory_vtable = {nullptr};
// allocating memory for the factory.
static void tsi_ssl_handshaker_factory_init(
tsi_ssl_handshaker_factory* factory) {
GPR_ASSERT(factory != nullptr);
CHECK_NE(factory, nullptr);
factory->vtable = &handshaker_factory_vtable;
gpr_ref_init(&factory->refcount, 1);
@ -1600,7 +1601,7 @@ static tsi_result ssl_handshaker_get_bytes_to_send_to_peer(
if (error != nullptr) *error = "invalid argument";
return TSI_INVALID_ARGUMENT;
}
GPR_ASSERT(*bytes_size <= INT_MAX);
CHECK_LE(*bytes_size, static_cast<size_t>(INT_MAX));
bytes_read_from_ssl =
BIO_read(impl->network_io, bytes, static_cast<int>(*bytes_size));
if (bytes_read_from_ssl < 0) {
@ -1671,7 +1672,7 @@ static tsi_result ssl_handshaker_process_bytes_from_peer(
if (error != nullptr) *error = "invalid argument";
return TSI_INVALID_ARGUMENT;
}
GPR_ASSERT(*bytes_size <= INT_MAX);
CHECK_LE(*bytes_size, static_cast<size_t>(INT_MAX));
bytes_written_into_ssl_size =
BIO_write(impl->network_io, bytes, static_cast<int>(*bytes_size));
if (bytes_written_into_ssl_size < 0) {
@ -2135,7 +2136,7 @@ static int server_handshaker_factory_npn_advertised_callback(
tsi_ssl_server_handshaker_factory* factory =
static_cast<tsi_ssl_server_handshaker_factory*>(arg);
*out = factory->alpn_protocol_list;
GPR_ASSERT(factory->alpn_protocol_list_length <= UINT_MAX);
CHECK(factory->alpn_protocol_list_length <= UINT_MAX);
*outlen = static_cast<unsigned int>(factory->alpn_protocol_list_length);
return SSL_TLSEXT_ERR_OK;
}
@ -2169,7 +2170,7 @@ static int server_handshaker_factory_new_session_callback(
template <typename T>
static void ssl_keylogging_callback(const SSL* ssl, const char* info) {
SSL_CTX* ssl_context = SSL_get_SSL_CTX(ssl);
GPR_ASSERT(ssl_context != nullptr);
CHECK_NE(ssl_context, nullptr);
void* arg = SSL_CTX_get_ex_data(ssl_context, g_ssl_ctx_ex_factory_index);
T* factory = static_cast<T*>(arg);
factory->key_logger->LogSessionKeys(ssl_context, info);
@ -2303,7 +2304,7 @@ tsi_result tsi_create_ssl_client_handshaker_factory_with_options(
break;
}
#if TSI_OPENSSL_ALPN_SUPPORT
GPR_ASSERT(impl->alpn_protocol_list_length < UINT_MAX);
CHECK(impl->alpn_protocol_list_length < UINT_MAX);
if (SSL_CTX_set_alpn_protos(
ssl_context, impl->alpn_protocol_list,
static_cast<unsigned int>(impl->alpn_protocol_list_length))) {
@ -2631,8 +2632,8 @@ int tsi_ssl_peer_matches_name(const tsi_peer* peer, absl::string_view name) {
const tsi_ssl_handshaker_factory_vtable* tsi_ssl_handshaker_factory_swap_vtable(
tsi_ssl_handshaker_factory* factory,
tsi_ssl_handshaker_factory_vtable* new_vtable) {
GPR_ASSERT(factory != nullptr);
GPR_ASSERT(factory->vtable != nullptr);
CHECK_NE(factory, nullptr);
CHECK_NE(factory->vtable, nullptr);
const tsi_ssl_handshaker_factory_vtable* orig_vtable = factory->vtable;
factory->vtable = new_vtable;

@ -23,6 +23,7 @@
#include <openssl/ssl.h>
#include <openssl/x509v3.h>
#include "absl/log/check.h"
#include "absl/status/status.h"
#include "absl/status/statusor.h"
@ -68,7 +69,7 @@ void LogSslErrorStack(void) {
tsi_result DoSslWrite(SSL* ssl, unsigned char* unprotected_bytes,
size_t unprotected_bytes_size) {
GPR_ASSERT(unprotected_bytes_size <= INT_MAX);
CHECK_LE(unprotected_bytes_size, static_cast<size_t>(INT_MAX));
ERR_clear_error();
int ssl_write_result = SSL_write(ssl, unprotected_bytes,
static_cast<int>(unprotected_bytes_size));
@ -89,7 +90,7 @@ tsi_result DoSslWrite(SSL* ssl, unsigned char* unprotected_bytes,
tsi_result DoSslRead(SSL* ssl, unsigned char* unprotected_bytes,
size_t* unprotected_bytes_size) {
GPR_ASSERT(*unprotected_bytes_size <= INT_MAX);
CHECK_LE(*unprotected_bytes_size, static_cast<size_t>(INT_MAX));
ERR_clear_error();
int read_from_ssl = SSL_read(ssl, unprotected_bytes,
static_cast<int>(*unprotected_bytes_size));
@ -134,7 +135,7 @@ tsi_result SslProtectorProtect(const unsigned char* unprotected_bytes,
int pending_in_ssl = static_cast<int>(BIO_pending(network_io));
if (pending_in_ssl > 0) {
*unprotected_bytes_size = 0;
GPR_ASSERT(*protected_output_frames_size <= INT_MAX);
CHECK_LE(*protected_output_frames_size, static_cast<size_t>(INT_MAX));
read_from_ssl = BIO_read(network_io, protected_output_frames,
static_cast<int>(*protected_output_frames_size));
if (read_from_ssl < 0) {
@ -161,7 +162,7 @@ tsi_result SslProtectorProtect(const unsigned char* unprotected_bytes,
result = DoSslWrite(ssl, buffer, buffer_size);
if (result != TSI_OK) return result;
GPR_ASSERT(*protected_output_frames_size <= INT_MAX);
CHECK_LE(*protected_output_frames_size, static_cast<size_t>(INT_MAX));
read_from_ssl = BIO_read(network_io, protected_output_frames,
static_cast<int>(*protected_output_frames_size));
if (read_from_ssl < 0) {
@ -191,11 +192,11 @@ tsi_result SslProtectorProtectFlush(size_t& buffer_offset,
}
pending = static_cast<int>(BIO_pending(network_io));
GPR_ASSERT(pending >= 0);
CHECK_GE(pending, 0);
*still_pending_size = static_cast<size_t>(pending);
if (*still_pending_size == 0) return TSI_OK;
GPR_ASSERT(*protected_output_frames_size <= INT_MAX);
CHECK_LE(*protected_output_frames_size, static_cast<size_t>(INT_MAX));
read_from_ssl = BIO_read(network_io, protected_output_frames,
static_cast<int>(*protected_output_frames_size));
if (read_from_ssl <= 0) {
@ -204,7 +205,7 @@ tsi_result SslProtectorProtectFlush(size_t& buffer_offset,
}
*protected_output_frames_size = static_cast<size_t>(read_from_ssl);
pending = static_cast<int>(BIO_pending(network_io));
GPR_ASSERT(pending >= 0);
CHECK_GE(pending, 0);
*still_pending_size = static_cast<size_t>(pending);
return TSI_OK;
}
@ -232,7 +233,7 @@ tsi_result SslProtectorUnprotect(const unsigned char* protected_frames_bytes,
*unprotected_bytes_size = output_bytes_size - output_bytes_offset;
// Then, try to write some data to ssl.
GPR_ASSERT(*protected_frames_bytes_size <= INT_MAX);
CHECK_LE(*protected_frames_bytes_size, static_cast<size_t>(INT_MAX));
written_into_ssl = BIO_write(network_io, protected_frames_bytes,
static_cast<int>(*protected_frames_bytes_size));
if (written_into_ssl < 0) {

Loading…
Cancel
Save