From f69369741d7090d65064449a3b96712814335a81 Mon Sep 17 00:00:00 2001 From: Craig Tiller Date: Wed, 16 Nov 2016 15:03:53 -0800 Subject: [PATCH] Review feedback --- include/grpc++/support/channel_arguments.h | 4 +++- test/cpp/microbenchmarks/bm_fullstack.cc | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/include/grpc++/support/channel_arguments.h b/include/grpc++/support/channel_arguments.h index 5879f404473..0c05f5478a9 100644 --- a/include/grpc++/support/channel_arguments.h +++ b/include/grpc++/support/channel_arguments.h @@ -107,7 +107,9 @@ class ChannelArguments { /// Set a textual argument \a value under \a key. void SetString(const grpc::string& key, const grpc::string& value); - grpc_channel_args c_args() { + /// Return (by value) a c grpc_channel_args structure which points to + /// arguments owned by this ChannelArguments instance + grpc_channel_args c_channel_args() { grpc_channel_args out; out.num_args = args_.size(); out.args = args_.empty() ? NULL : &args_[0]; diff --git a/test/cpp/microbenchmarks/bm_fullstack.cc b/test/cpp/microbenchmarks/bm_fullstack.cc index 09a629814c4..2b6dd3219ce 100644 --- a/test/cpp/microbenchmarks/bm_fullstack.cc +++ b/test/cpp/microbenchmarks/bm_fullstack.cc @@ -164,7 +164,7 @@ class EndpointPairFixture { ChannelArguments args; args.SetString(GRPC_ARG_DEFAULT_AUTHORITY, "test.authority"); - grpc_channel_args c_args = args.c_args(); + grpc_channel_args c_args = args.c_channel_args(); grpc_transport* transport = grpc_create_chttp2_transport(&exec_ctx, &c_args, endpoints.client, 1); GPR_ASSERT(transport);