Add comment on use of GPRC_CLOSURE_SCHED instead of GRPC_CLOSURE_RUN

pull/15200/head
Yash Tibrewal 7 years ago
parent 592dc0fa1f
commit f609e62578
  1. 4
      src/core/lib/surface/call.cc

@ -1259,6 +1259,10 @@ static void post_batch_completion(batch_control* bctl) {
if (bctl->completion_data.notify_tag.is_closure) { if (bctl->completion_data.notify_tag.is_closure) {
/* unrefs bctl->error */ /* unrefs bctl->error */
bctl->call = nullptr; bctl->call = nullptr;
/* This closure may be meant to be run within some combiner. Since we aren't
* running in any combiner here, we need to use GRPC_CLOSURE_SCHED instead
* of GRPC_CLOSURE_RUN.
*/
GRPC_CLOSURE_SCHED((grpc_closure*)bctl->completion_data.notify_tag.tag, GRPC_CLOSURE_SCHED((grpc_closure*)bctl->completion_data.notify_tag.tag,
error); error);
GRPC_CALL_INTERNAL_UNREF(call, "completion"); GRPC_CALL_INTERNAL_UNREF(call, "completion");

Loading…
Cancel
Save