From f6057e093d18f28b3b66eec5fb0f77dc8659dd7c Mon Sep 17 00:00:00 2001 From: Michael Lumish Date: Fri, 18 Sep 2020 11:43:52 -0700 Subject: [PATCH] Add a comment explaining the Popen change --- tools/run_tests/run_xds_tests.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/run_tests/run_xds_tests.py b/tools/run_tests/run_xds_tests.py index cdc0e6a1e15..51fd022c13f 100755 --- a/tools/run_tests/run_xds_tests.py +++ b/tools/run_tests/run_xds_tests.py @@ -1800,6 +1800,7 @@ try: metadata_to_send=metadata_to_send) logger.debug('running client: %s', client_cmd_formatted) try: + # We invoke the client using bash to avoid https://github.com/nvm-sh/nvm/issues/1866 client_process = subprocess.Popen(['/bin/bash', '-i', '-c', client_cmd_formatted], env=client_env, stderr=subprocess.STDOUT,