From 532aad7752c27447124df8b0b6f05292a2009f9c Mon Sep 17 00:00:00 2001 From: "Nicolas \"Pixel\" Noble" Date: Wed, 20 Sep 2017 01:50:12 +0200 Subject: [PATCH 1/4] Adding script to generate pull request list from an interval. --- tools/distrib/pull_requests_interval.sh | 67 +++++++++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100755 tools/distrib/pull_requests_interval.sh diff --git a/tools/distrib/pull_requests_interval.sh b/tools/distrib/pull_requests_interval.sh new file mode 100755 index 00000000000..43114990aa2 --- /dev/null +++ b/tools/distrib/pull_requests_interval.sh @@ -0,0 +1,67 @@ +#!/bin/bash + +if [ "x$1" = "x" ] ; then + echo "Usage: $0 [second ref]" + exit 1 +else + first=$1 +fi + +if [ -n $2 ] ; then + second=HEAD +fi + +if [ -e ~/github-credentials.vars ] ; then + . ~/github-credentials.vars +fi + +if [ "x$github_client_id" = "x" ] || [ "x$github_client_secret" = "x" ] ; then + echo "Warning: you don't have github credentials set." + echo + echo "You may end up exceeding guest quota quickly." + echo "You can create an application for yourself," + echo "and get its credentials. Go to" + echo + echo " https://github.com/settings/developers" + echo + echo "and click 'Register a new application'." + echo + echo "From the application's information, copy/paste" + echo "its Client ID and Client Secret, into the file" + echo + echo " ~/github-credentials.vars" + echo + echo "with the following format:" + echo + echo "github_client_id=0123456789abcdef0123" + echo "github_client_secret=0123456789abcdef0123456789abcdef" + echo + echo + addendum="" +else + addendum="?client_id=$github_client_id&client_secret=$github_client_secret" +fi + +unset notfirst +echo "[" +git log --pretty=oneline $1..$2 | + grep '[^ ]\+ Merge pull request #[0-9]\{4,6\} ' | + cut -f 2 -d# | + cut -f 1 -d\ | + sort -u | + while read id ; do + if [ "x$notfirst" = "x" ] ; then + notfirst=true + else + echo "," + fi + echo -n " {\"url\": \"https://github.com/grpc/grpc/pull/$id\"," + out=`mktemp` + curl -s "https://api.github.com/repos/grpc/grpc/pulls/$id$addendum" > $out + echo -n " "`grep '"title"' $out` + echo -n " "`grep '"login"' $out | head -1` + echo -n " \"pr\": $id }" + rm $out + done +echo +echo "]" From bdf998a1840a5b35c9ad84d27c8ca4ce2642b06a Mon Sep 17 00:00:00 2001 From: Yash Tibrewal Date: Wed, 27 Sep 2017 17:07:43 -0700 Subject: [PATCH 2/4] Fix compression tests for when they expect the client to receive the completion tag --- test/core/end2end/tests/compressed_payload.c | 2 +- test/core/end2end/tests/stream_compression_compressed_payload.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/core/end2end/tests/compressed_payload.c b/test/core/end2end/tests/compressed_payload.c index ce86e97b83e..ba03773036b 100644 --- a/test/core/end2end/tests/compressed_payload.c +++ b/test/core/end2end/tests/compressed_payload.c @@ -193,6 +193,7 @@ static void request_for_disabled_algorithm( GPR_ASSERT(GRPC_CALL_OK == error); CQ_EXPECT_COMPLETION(cqv, tag(101), true); + CQ_EXPECT_COMPLETION(cqv, tag(1), true); cq_verify(cqv); op = ops; @@ -221,7 +222,6 @@ static void request_for_disabled_algorithm( GPR_ASSERT(GRPC_CALL_OK == error); CQ_EXPECT_COMPLETION(cqv, tag(103), true); - CQ_EXPECT_COMPLETION(cqv, tag(1), true); cq_verify(cqv); /* call was cancelled (closed) ... */ diff --git a/test/core/end2end/tests/stream_compression_compressed_payload.c b/test/core/end2end/tests/stream_compression_compressed_payload.c index 094c4de1c05..8b47741cd40 100644 --- a/test/core/end2end/tests/stream_compression_compressed_payload.c +++ b/test/core/end2end/tests/stream_compression_compressed_payload.c @@ -193,6 +193,7 @@ static void request_for_disabled_algorithm( GPR_ASSERT(GRPC_CALL_OK == error); CQ_EXPECT_COMPLETION(cqv, tag(101), true); + CQ_EXPECT_COMPLETION(cqv, tag(1), true); cq_verify(cqv); op = ops; @@ -221,7 +222,6 @@ static void request_for_disabled_algorithm( GPR_ASSERT(GRPC_CALL_OK == error); CQ_EXPECT_COMPLETION(cqv, tag(103), true); - CQ_EXPECT_COMPLETION(cqv, tag(1), true); cq_verify(cqv); /* call was cancelled (closed) ... */ From daa70e67ccd9d9359c6692fa132a64417c8d57ee Mon Sep 17 00:00:00 2001 From: "Nicolas \"Pixel\" Noble" Date: Fri, 29 Sep 2017 19:18:41 +0200 Subject: [PATCH 3/4] Adding Copyright info. --- tools/distrib/pull_requests_interval.sh | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/tools/distrib/pull_requests_interval.sh b/tools/distrib/pull_requests_interval.sh index 43114990aa2..7a6c702daa6 100755 --- a/tools/distrib/pull_requests_interval.sh +++ b/tools/distrib/pull_requests_interval.sh @@ -1,4 +1,17 @@ #!/bin/bash +# Copyright 2017 gRPC authors. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. if [ "x$1" = "x" ] ; then echo "Usage: $0 [second ref]" From 520cc8f55544bcbba3630da934607776d551d9f7 Mon Sep 17 00:00:00 2001 From: ncteisen Date: Fri, 29 Sep 2017 10:36:28 -0700 Subject: [PATCH 4/4] Fix ClangTidy --- src/cpp/client/secure_credentials.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cpp/client/secure_credentials.h b/src/cpp/client/secure_credentials.h index fa1e31996ad..ed9afb37b00 100644 --- a/src/cpp/client/secure_credentials.h +++ b/src/cpp/client/secure_credentials.h @@ -73,7 +73,7 @@ class MetadataCredentialsPluginWrapper final : private GrpcLibraryCodegen { grpc_auth_metadata_context context, grpc_credentials_plugin_metadata_cb cb, void* user_data, grpc_metadata creds_md[GRPC_METADATA_CREDENTIALS_PLUGIN_SYNC_MAX], - size_t* num_creds_md, grpc_status_code* status, + size_t* num_creds_md, grpc_status_code* status_code, const char** error_details); std::unique_ptr thread_pool_; std::unique_ptr plugin_;