Merge pull request #25144 from vjpai/deser_failure

Check for deser failure before destructing included request in ServerCallbackWriter
pull/25147/head
Vijay Pai 4 years ago committed by GitHub
commit f5806072f2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 6
      include/grpcpp/impl/codegen/server_callback_handlers.h

@ -616,7 +616,11 @@ class CallbackServerStreamingHandler : public ::grpc::internal::MethodHandler {
// DefaultReactor (which is unary).
this->MaybeDone(/*inlineable_ondone=*/false);
}
~ServerCallbackWriterImpl() { req_->~RequestType(); }
~ServerCallbackWriterImpl() {
if (req_ != nullptr) {
req_->~RequestType();
}
}
const RequestType* request() { return req_; }

Loading…
Cancel
Save