From 109040f79664e6b14003a65507022e29434df737 Mon Sep 17 00:00:00 2001 From: yang-g Date: Wed, 30 Aug 2017 21:33:31 -0700 Subject: [PATCH] Support features in grpc_package --- bazel/grpc_build_system.bzl | 5 +++-- test/core/network_benchmarks/BUILD | 11 +++-------- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/bazel/grpc_build_system.bzl b/bazel/grpc_build_system.bzl index bff89882744..ba7ffcc9beb 100644 --- a/bazel/grpc_build_system.bzl +++ b/bazel/grpc_build_system.bzl @@ -106,7 +106,7 @@ def grpc_sh_test(name, srcs, args = [], data = []): args = args, data = data) -def grpc_package(name, visibility = "private"): +def grpc_package(name, visibility = "private", features = []): if visibility == "tests": visibility = ["//test:__subpackages__"] elif visibility == "public": @@ -118,5 +118,6 @@ def grpc_package(name, visibility = "private"): if len(visibility) != 0: native.package( - default_visibility = visibility + default_visibility = visibility, + features = features ) diff --git a/test/core/network_benchmarks/BUILD b/test/core/network_benchmarks/BUILD index dd0c75c9d17..0e15393030c 100644 --- a/test/core/network_benchmarks/BUILD +++ b/test/core/network_benchmarks/BUILD @@ -14,17 +14,12 @@ load("//bazel:grpc_build_system.bzl", "grpc_cc_library", "grpc_cc_test", "grpc_cc_binary", "grpc_package") -grpc_package(name = "test/core/network_benchmarks") +grpc_package(name = "test/core/network_benchmarks", + features = ["-layering_check", "-parse_headers" ] +) licenses(["notice"]) # Apache v2 -package( - features = [ - "-layering_check", - "-parse_headers", - ], -) - grpc_cc_binary( name = "low_level_ping_pong", srcs = ["low_level_ping_pong.c"],