Chiebot-Mirror
/
grpc
mirror of https://github.com/grpc/grpc.git
8
0
Fork 0
Code Issues Projects Releases Wiki Activity

[fake stats plugin] add locking to avoid tsan failures

Browse Source
pull/36093/head
Mark D. Roth 12 months ago
parent 7533328075
commit f504330684
1 changed files with 46 additions and 12 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Split View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 58
      test/core/util/fake_stats_plugin.h

58
test/core/util/fake_stats_plugin.h
Unescape View File

@ -220,7 +220,8 @@ class FakeStatsPlugin : public StatsPlugin {
return;
}
switch (descriptor.instrument_type) {
case GlobalInstrumentsRegistry::InstrumentType::kCounter:
case GlobalInstrumentsRegistry::InstrumentType::kCounter: {
MutexLock lock(&mu_);
if (descriptor.value_type ==
GlobalInstrumentsRegistry::ValueType::kUInt64) {
uint64_counters_.emplace(descriptor.index, descriptor);
@ -228,7 +229,9 @@ class FakeStatsPlugin : public StatsPlugin {
double_counters_.emplace(descriptor.index, descriptor);
}
break;
case GlobalInstrumentsRegistry::InstrumentType::kHistogram:
}
case GlobalInstrumentsRegistry::InstrumentType::kHistogram: {
MutexLock lock(&mu_);
if (descriptor.value_type ==
GlobalInstrumentsRegistry::ValueType::kUInt64) {
uint64_histograms_.emplace(descriptor.index, descriptor);
@ -236,7 +239,9 @@ class FakeStatsPlugin : public StatsPlugin {
double_histograms_.emplace(descriptor.index, descriptor);
}
break;
case GlobalInstrumentsRegistry::InstrumentType::kGauge:
}
case GlobalInstrumentsRegistry::InstrumentType::kGauge: {
MutexLock lock(&mu_);
if (descriptor.value_type ==
GlobalInstrumentsRegistry::ValueType::kInt64) {
int64_gauges_.emplace(descriptor.index, descriptor);
@ -244,7 +249,9 @@ class FakeStatsPlugin : public StatsPlugin {
double_gauges_.emplace(descriptor.index, descriptor);
}
break;
case GlobalInstrumentsRegistry::InstrumentType::kCallbackGauge:
}
case GlobalInstrumentsRegistry::InstrumentType::kCallbackGauge: {
MutexLock lock(&callback_mu_);
if (descriptor.value_type ==
GlobalInstrumentsRegistry::ValueType::kInt64) {
int64_callback_gauges_.emplace(descriptor.index, descriptor);
@ -252,6 +259,7 @@ class FakeStatsPlugin : public StatsPlugin {
double_callback_gauges_.emplace(descriptor.index, descriptor);
}
break;
}
default:
Crash("unknown instrument type");
}
@ -286,6 +294,7 @@ class FakeStatsPlugin : public StatsPlugin {
this, handle.index, value,
absl::StrJoin(label_values, ", ").c_str(),
absl::StrJoin(optional_values, ", ").c_str());
MutexLock lock(&mu_);
auto iter = uint64_counters_.find(handle.index);
if (iter == uint64_counters_.end()) return;
iter->second.Add(value, label_values, optional_values);
@ -300,6 +309,7 @@ class FakeStatsPlugin : public StatsPlugin {
this, handle.index, value,
absl::StrJoin(label_values, ", ").c_str(),
absl::StrJoin(optional_values, ", ").c_str());
MutexLock lock(&mu_);
auto iter = double_counters_.find(handle.index);
if (iter == double_counters_.end()) return;
iter->second.Add(value, label_values, optional_values);
@ -314,6 +324,7 @@ class FakeStatsPlugin : public StatsPlugin {
this, handle.index, value,
absl::StrJoin(label_values, ", ").c_str(),
absl::StrJoin(optional_values, ", ").c_str());
MutexLock lock(&mu_);
auto iter = uint64_histograms_.find(handle.index);
if (iter == uint64_histograms_.end()) return;
iter->second.Record(value, label_values, optional_values);
@ -328,6 +339,7 @@ class FakeStatsPlugin : public StatsPlugin {
this, handle.index, value,
absl::StrJoin(label_values, ", ").c_str(),
absl::StrJoin(optional_values, ", ").c_str());
MutexLock lock(&mu_);
auto iter = double_histograms_.find(handle.index);
if (iter == double_histograms_.end()) return;
iter->second.Record(value, label_values, optional_values);
@ -341,6 +353,7 @@ class FakeStatsPlugin : public StatsPlugin {
this, handle.index, value,
absl::StrJoin(label_values, ", ").c_str(),
absl::StrJoin(optional_values, ", ").c_str());
MutexLock lock(&mu_);
auto iter = int64_gauges_.find(handle.index);
if (iter == int64_gauges_.end()) return;
iter->second.Set(value, label_values, optional_values);
@ -354,6 +367,7 @@ class FakeStatsPlugin : public StatsPlugin {
this, handle.index, value,
absl::StrJoin(label_values, ", ").c_str(),
absl::StrJoin(optional_values, ", ").c_str());
MutexLock lock(&mu_);
auto iter = double_gauges_.find(handle.index);
if (iter == double_gauges_.end()) return;
iter->second.Set(value, label_values, optional_values);
@ -372,6 +386,7 @@ class FakeStatsPlugin : public StatsPlugin {
GlobalInstrumentsRegistry::GlobalUInt64CounterHandle handle,
absl::Span<const absl::string_view> label_values,
absl::Span<const absl::string_view> optional_values) {
MutexLock lock(&mu_);
auto iter = uint64_counters_.find(handle.index);
if (iter == uint64_counters_.end()) {
return absl::nullopt;
@ -382,6 +397,7 @@ class FakeStatsPlugin : public StatsPlugin {
GlobalInstrumentsRegistry::GlobalDoubleCounterHandle handle,
absl::Span<const absl::string_view> label_values,
absl::Span<const absl::string_view> optional_values) {
MutexLock lock(&mu_);
auto iter = double_counters_.find(handle.index);
if (iter == double_counters_.end()) {
return absl::nullopt;
@ -392,6 +408,7 @@ class FakeStatsPlugin : public StatsPlugin {
GlobalInstrumentsRegistry::GlobalUInt64HistogramHandle handle,
absl::Span<const absl::string_view> label_values,
absl::Span<const absl::string_view> optional_values) {
MutexLock lock(&mu_);
auto iter = uint64_histograms_.find(handle.index);
if (iter == uint64_histograms_.end()) {
return absl::nullopt;
@ -402,6 +419,7 @@ class FakeStatsPlugin : public StatsPlugin {
GlobalInstrumentsRegistry::GlobalDoubleHistogramHandle handle,
absl::Span<const absl::string_view> label_values,
absl::Span<const absl::string_view> optional_values) {
MutexLock lock(&mu_);
auto iter = double_histograms_.find(handle.index);
if (iter == double_histograms_.end()) {
return absl::nullopt;
@ -412,6 +430,7 @@ class FakeStatsPlugin : public StatsPlugin {
GlobalInstrumentsRegistry::GlobalInt64GaugeHandle handle,
absl::Span<const absl::string_view> label_values,
absl::Span<const absl::string_view> optional_values) {
MutexLock lock(&mu_);
auto iter = int64_gauges_.find(handle.index);
if (iter == int64_gauges_.end()) {
return absl::nullopt;
@ -422,6 +441,7 @@ class FakeStatsPlugin : public StatsPlugin {
GlobalInstrumentsRegistry::GlobalDoubleGaugeHandle handle,
absl::Span<const absl::string_view> label_values,
absl::Span<const absl::string_view> optional_values) {
MutexLock lock(&mu_);
auto iter = double_gauges_.find(handle.index);
if (iter == double_gauges_.end()) {
return absl::nullopt;
@ -440,6 +460,7 @@ class FakeStatsPlugin : public StatsPlugin {
GlobalInstrumentsRegistry::GlobalCallbackInt64GaugeHandle handle,
absl::Span<const absl::string_view> label_values,
absl::Span<const absl::string_view> optional_values) {
MutexLock lock(&callback_mu_);
auto iter = int64_callback_gauges_.find(handle.index);
if (iter == int64_callback_gauges_.end()) {
return absl::nullopt;
@ -450,6 +471,7 @@ class FakeStatsPlugin : public StatsPlugin {
GlobalInstrumentsRegistry::GlobalCallbackDoubleGaugeHandle handle,
absl::Span<const absl::string_view> label_values,
absl::Span<const absl::string_view> optional_values) {
MutexLock lock(&callback_mu_);
auto iter = double_callback_gauges_.find(handle.index);
if (iter == double_callback_gauges_.end()) {
return absl::nullopt;
@ -473,6 +495,7 @@ class FakeStatsPlugin : public StatsPlugin {
this, handle.index, value,
absl::StrJoin(label_values, ", ").c_str(),
absl::StrJoin(optional_values, ", ").c_str());
MutexLock lock(&plugin_.callback_mu_);
auto iter = plugin_.int64_callback_gauges_.find(handle.index);
if (iter == plugin_.int64_callback_gauges_.end()) return;
iter->second.Set(value, label_values, optional_values);
@ -489,6 +512,7 @@ class FakeStatsPlugin : public StatsPlugin {
this, handle.index, value,
absl::StrJoin(label_values, ", ").c_str(),
absl::StrJoin(optional_values, ", ").c_str());
MutexLock lock(&plugin_.callback_mu_);
auto iter = plugin_.double_callback_gauges_.find(handle.index);
if (iter == plugin_.double_callback_gauges_.end()) return;
iter->second.Set(value, label_values, optional_values);
@ -621,14 +645,24 @@ class FakeStatsPlugin : public StatsPlugin {
absl::AnyInvocable<bool(const ChannelScope& /*scope*/) const> channel_filter_;
// Instruments.
absl::flat_hash_map<uint32_t, Counter<uint64_t>> uint64_counters_;
absl::flat_hash_map<uint32_t, Counter<double>> double_counters_;
absl::flat_hash_map<uint32_t, Histogram<uint64_t>> uint64_histograms_;
absl::flat_hash_map<uint32_t, Histogram<double>> double_histograms_;
absl::flat_hash_map<uint32_t, Gauge<int64_t>> int64_gauges_;
absl::flat_hash_map<uint32_t, Gauge<double>> double_gauges_;
absl::flat_hash_map<uint32_t, Gauge<int64_t>> int64_callback_gauges_;
absl::flat_hash_map<uint32_t, Gauge<double>> double_callback_gauges_;
Mutex mu_;
absl::flat_hash_map<uint32_t, Counter<uint64_t>> uint64_counters_
ABSL_GUARDED_BY(&mu_);
absl::flat_hash_map<uint32_t, Counter<double>> double_counters_
ABSL_GUARDED_BY(&mu_);
absl::flat_hash_map<uint32_t, Histogram<uint64_t>> uint64_histograms_
ABSL_GUARDED_BY(&mu_);
absl::flat_hash_map<uint32_t, Histogram<double>> double_histograms_
ABSL_GUARDED_BY(&mu_);
absl::flat_hash_map<uint32_t, Gauge<int64_t>> int64_gauges_
ABSL_GUARDED_BY(&mu_);
absl::flat_hash_map<uint32_t, Gauge<double>> double_gauges_
ABSL_GUARDED_BY(&mu_);
Mutex callback_mu_;
absl::flat_hash_map<uint32_t, Gauge<int64_t>> int64_callback_gauges_
ABSL_GUARDED_BY(&callback_mu_);
absl::flat_hash_map<uint32_t, Gauge<double>> double_callback_gauges_
ABSL_GUARDED_BY(&callback_mu_);
std::set<RegisteredMetricCallback*> callbacks_;
};

Write Preview
Loading…
Cancel
Save