Remove previous fix proposal proved to be wrong

pull/18722/head
Muxi Yan 6 years ago
parent bec72481b5
commit f371fce887
  1. 3
      src/core/ext/transport/cronet/transport/cronet_transport.cc

@ -335,9 +335,6 @@ static void add_to_storage(struct stream_obj* s,
/* add new op at the beginning of the linked list. The memory is freed /* add new op at the beginning of the linked list. The memory is freed
in remove_from_storage */ in remove_from_storage */
op_and_state* new_op = grpc_core::New<op_and_state>(s, *op); op_and_state* new_op = grpc_core::New<op_and_state>(s, *op);
// Pontential fix to crash on GPR_ASSERT(!curr->done)
// TODO (mxyan): check if this is indeed necessary.
new_op->done = false;
gpr_mu_lock(&s->mu); gpr_mu_lock(&s->mu);
new_op->next = storage->head; new_op->next = storage->head;
storage->head = new_op; storage->head = new_op;

Loading…
Cancel
Save