Cleanup host getter (#28547)

* cleanup host getter

* remove test
pull/28707/head^2
Ashitha Santhosh 3 years ago committed by GitHub
parent 3002bd462a
commit f33c587c2a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      src/core/lib/security/authorization/cel_authorization_engine.cc
  2. 10
      src/core/lib/security/authorization/evaluate_args.cc
  3. 1
      src/core/lib/security/authorization/evaluate_args.h
  4. 7
      test/core/security/evaluate_args_test.cc

@ -103,7 +103,7 @@ std::unique_ptr<mock_cel::Activation> CelAuthorizationEngine::CreateActivation(
mock_cel::CelValue::CreateStringView(url_path));
}
} else if (elem == kHost) {
absl::string_view host(args.GetHost());
absl::string_view host(args.GetAuthority());
if (!host.empty()) {
activation->InsertValue(kHost,
mock_cel::CelValue::CreateStringView(host));

@ -90,16 +90,6 @@ absl::string_view EvaluateArgs::GetPath() const {
return absl::string_view();
}
absl::string_view EvaluateArgs::GetHost() const {
absl::string_view host;
if (metadata_ != nullptr) {
if (auto* host_md = metadata_->get_pointer(HostMetadata())) {
host = host_md->as_string_view();
}
}
return host;
}
absl::string_view EvaluateArgs::GetAuthority() const {
absl::string_view authority;
if (metadata_ != nullptr) {

@ -57,7 +57,6 @@ class EvaluateArgs {
: metadata_(metadata), channel_args_(channel_args) {}
absl::string_view GetPath() const;
absl::string_view GetHost() const;
absl::string_view GetAuthority() const;
absl::string_view GetMethod() const;
// Returns metadata value(s) for the specified key.

@ -34,7 +34,6 @@ TEST_F(EvaluateArgsTest, EmptyMetadata) {
EvaluateArgs args = util_.MakeEvaluateArgs();
EXPECT_EQ(args.GetPath(), nullptr);
EXPECT_EQ(args.GetMethod(), nullptr);
EXPECT_EQ(args.GetHost(), nullptr);
EXPECT_EQ(args.GetAuthority(), nullptr);
EXPECT_EQ(args.GetHeaderValue("some_key", nullptr), absl::nullopt);
}
@ -45,12 +44,6 @@ TEST_F(EvaluateArgsTest, GetPathSuccess) {
EXPECT_EQ(args.GetPath(), "/expected/path");
}
TEST_F(EvaluateArgsTest, GetHostSuccess) {
util_.AddPairToMetadata("host", "host123");
EvaluateArgs args = util_.MakeEvaluateArgs();
EXPECT_EQ(args.GetHost(), "host123");
}
TEST_F(EvaluateArgsTest, GetAuthoritySuccess) {
util_.AddPairToMetadata(":authority", "test.google.com");
EvaluateArgs args = util_.MakeEvaluateArgs();

Loading…
Cancel
Save