diff --git a/src/core/ext/filters/client_channel/client_channel.cc b/src/core/ext/filters/client_channel/client_channel.cc index 2ee2ed3084e..a93e957b60e 100644 --- a/src/core/ext/filters/client_channel/client_channel.cc +++ b/src/core/ext/filters/client_channel/client_channel.cc @@ -292,8 +292,8 @@ class ClientChannel::FilterBasedCallData : public ClientChannel::CallData { grpc_polling_entity* pollent_ = nullptr; // Accessed while holding ClientChannel::resolution_mu_. - ResolverQueuedCallCanceller* resolver_call_canceller_ ABSL_GUARDED_BY( - &ClientChannel::resolution_mu_) = nullptr; + ResolverQueuedCallCanceller* resolver_call_canceller_ + ABSL_GUARDED_BY(&ClientChannel::resolution_mu_) = nullptr; grpc_closure* original_recv_trailing_metadata_ready_ = nullptr; grpc_closure recv_trailing_metadata_ready_; @@ -884,9 +884,8 @@ class ClientChannel::SubchannelWrapper : public SubchannelInterface { // corresponding WrapperWatcher to cancel on the underlying subchannel. std::map watcher_map_ ABSL_GUARDED_BY(*chand_->work_serializer_); - std::set, - DataWatcherLessThan> data_watchers_ - ABSL_GUARDED_BY(*chand_->work_serializer_); + std::set, DataWatcherLessThan> + data_watchers_ ABSL_GUARDED_BY(*chand_->work_serializer_); }; // diff --git a/src/core/lib/surface/call_trace.cc b/src/core/lib/surface/call_trace.cc index 206333da7b2..d9b544ee1f9 100644 --- a/src/core/lib/surface/call_trace.cc +++ b/src/core/lib/surface/call_trace.cc @@ -109,7 +109,8 @@ const grpc_channel_filter* PromiseTracingFilterFor( struct Globals { Mutex mu; absl::flat_hash_map> map ABSL_GUARDED_BY(mu); + std::unique_ptr> + map ABSL_GUARDED_BY(mu); }; auto* globals = NoDestructSingleton::Get(); MutexLock lock(&globals->mu); diff --git a/src/core/lib/transport/transport.h b/src/core/lib/transport/transport.h index ed8909d3e52..b0471fba201 100644 --- a/src/core/lib/transport/transport.h +++ b/src/core/lib/transport/transport.h @@ -246,28 +246,28 @@ class CallSpineInterface { class CallSpine final : public CallSpineInterface { public: - Pipe& client_initial_metadata() { + Pipe& client_initial_metadata() override { return client_initial_metadata_; } - Pipe& server_initial_metadata() { + Pipe& server_initial_metadata() override { return server_initial_metadata_; } - Pipe& client_to_server_messages() { + Pipe& client_to_server_messages() override { return client_to_server_messages_; } - Pipe& server_to_client_messages() { + Pipe& server_to_client_messages() override { return server_to_client_messages_; } - Pipe& server_trailing_metadata() { + Pipe& server_trailing_metadata() override { return server_trailing_metadata_; } - absl::nullopt_t Cancel(ServerMetadataHandle metadata) { + absl::nullopt_t Cancel(ServerMetadataHandle metadata) override { GPR_DEBUG_ASSERT(Activity::current() == &party()); if (cancel_latch_.is_set()) return absl::nullopt; cancel_latch_.Set(std::move(metadata)); return absl::nullopt; } - Party& party() { Crash("unimplemented"); } + Party& party() override { Crash("unimplemented"); } private: // Initial metadata from client to server