From f1e1832b3969b8c3c17073b27da6ceb7017811e4 Mon Sep 17 00:00:00 2001 From: AJ Heller Date: Wed, 2 Aug 2023 21:57:10 -0700 Subject: [PATCH] [bug] Fix race in EventEngine shim logging (#33973) Fixes b/294124240. We could get clever and keep the peeraddr in the log, but the wrapper address should be sufficient to tie things together. --- src/core/lib/iomgr/event_engine_shims/endpoint.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/core/lib/iomgr/event_engine_shims/endpoint.cc b/src/core/lib/iomgr/event_engine_shims/endpoint.cc index ae9004f11b6..7474ee3d6f8 100644 --- a/src/core/lib/iomgr/event_engine_shims/endpoint.cc +++ b/src/core/lib/iomgr/event_engine_shims/endpoint.cc @@ -119,8 +119,7 @@ class EventEngineEndpointWrapper { read_buffer->~SliceBuffer(); if (GRPC_TRACE_FLAG_ENABLED(grpc_tcp_trace)) { size_t i; - gpr_log(GPR_INFO, "TCP: %p READ (peer=%s) error=%s", eeep_->wrapper, - std::string(eeep_->wrapper->PeerAddress()).c_str(), + gpr_log(GPR_INFO, "TCP: %p READ error=%s", eeep_->wrapper, status.ToString().c_str()); if (gpr_should_log(GPR_LOG_SEVERITY_DEBUG)) { for (i = 0; i < pending_read_buffer_->count; i++) {