From f1df0f2b5f4d4b6073a81fe697fbeb986d4a3b6d Mon Sep 17 00:00:00 2001 From: Yousuk Seung Date: Fri, 27 Sep 2024 13:29:31 -0700 Subject: [PATCH] [doc] Clarify client callback API comments (#37805) Comments say users "should not" call Start* methods after notification callbacks are called with false, but users may still call so it's close to 'not recommended'. But it's less confusing to remove it altogether. Closes #37805 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37805 from yousukseung:client_callback_doc_clarify 38b9371f79d9763a84bbfb6972c21d23b4f36613 PiperOrigin-RevId: 679709417 --- include/grpcpp/support/client_callback.h | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/include/grpcpp/support/client_callback.h b/include/grpcpp/support/client_callback.h index 692dff6b8d1..82a404e2c87 100644 --- a/include/grpcpp/support/client_callback.h +++ b/include/grpcpp/support/client_callback.h @@ -325,21 +325,20 @@ class ClientBidiReactor : public internal::ClientReactor { /// call of OnReadDone or OnDone. /// /// \param[in] ok Was the initial metadata read successfully? If false, no - /// new read/write operation will succeed, and any further - /// Start* operations should not be called. + /// new read/write operation will succeed. virtual void OnReadInitialMetadataDone(bool /*ok*/) {} /// Notifies the application that a StartRead operation completed. /// /// \param[in] ok Was it successful? If false, no new read/write operation - /// will succeed, and any further Start* should not be called. + /// will succeed. virtual void OnReadDone(bool /*ok*/) {} /// Notifies the application that a StartWrite or StartWriteLast operation /// completed. /// /// \param[in] ok Was it successful? If false, no new read/write operation - /// will succeed, and any further Start* should not be called. + /// will succeed. virtual void OnWriteDone(bool /*ok*/) {} /// Notifies the application that a StartWritesDone operation completed. Note