Reviewer comments

pull/19924/head
Yash Tibrewal 5 years ago
parent 1713c36892
commit eceb4db63e
  1. 6
      src/core/ext/transport/chttp2/transport/chttp2_transport.cc
  2. 4
      src/core/ext/transport/chttp2/transport/internal.h

@ -1049,12 +1049,12 @@ static void write_action_begin_locked(void* gt, grpc_error* error_ignored) {
if (t->reading_paused_on_pending_induced_frames) { if (t->reading_paused_on_pending_induced_frames) {
GPR_ASSERT(t->num_pending_induced_frames == 0); GPR_ASSERT(t->num_pending_induced_frames == 0);
/* We had paused reading, because we had many induced frames (SETTINGS /* We had paused reading, because we had many induced frames (SETTINGS
* ACK, RST_STREAMS) pending in t->qbuf. Now that we have been able to * ACK, PINGS ACK and RST_STREAMS) pending in t->qbuf. Now that we have
* flush qbuf, we can resume reading. */ * been able to flush qbuf, we can resume reading. */
GRPC_CHTTP2_IF_TRACING(gpr_log( GRPC_CHTTP2_IF_TRACING(gpr_log(
GPR_INFO, GPR_INFO,
"transport %p : Resuming reading after being paused due to too " "transport %p : Resuming reading after being paused due to too "
"many unwritten SETTINGS ACK and RST_STREAM frames", "many unwritten SETTINGS ACK, PINGS ACK and RST_STREAM frames",
t)); t));
t->reading_paused_on_pending_induced_frames = false; t->reading_paused_on_pending_induced_frames = false;
continue_read_action_locked(t); continue_read_action_locked(t);

@ -493,8 +493,8 @@ struct grpc_chttp2_transport {
grpc_core::ContextList* cl = nullptr; grpc_core::ContextList* cl = nullptr;
grpc_core::RefCountedPtr<grpc_core::channelz::SocketNode> channelz_socket; grpc_core::RefCountedPtr<grpc_core::channelz::SocketNode> channelz_socket;
uint32_t num_messages_in_next_write = 0; uint32_t num_messages_in_next_write = 0;
/** The number of pending induced frames (SETTINGS_ACK and RST_STREAM) in the /** The number of pending induced frames (SETTINGS_ACK, PINGS_ACK and
* outgoing buffer (t->qbuf). If this number goes beyond * RST_STREAM) in the outgoing buffer (t->qbuf). If this number goes beyond
* DEFAULT_MAX_PENDING_INDUCED_FRAMES, we pause reading new frames. We would * DEFAULT_MAX_PENDING_INDUCED_FRAMES, we pause reading new frames. We would
* only continue reading when we are able to write to the socket again, * only continue reading when we are able to write to the socket again,
* thereby reducing the number of induced frames. */ * thereby reducing the number of induced frames. */

Loading…
Cancel
Save