From ecc07b6979555f3de1a906dd2ca54bc4c64787ae Mon Sep 17 00:00:00 2001
From: Ming-Chuan <mingcl@google.com>
Date: Thu, 26 Aug 2021 12:18:06 +0800
Subject: [PATCH] Add missing gpr_platform dependency for binder transport
(#27118)
Without this, layering check in internal repo will fail when non third
party code depends on the transport implementation
---
src/core/ext/transport/binder/client/BUILD | 5 +++++
src/core/ext/transport/binder/transport/BUILD | 4 ++++
src/core/ext/transport/binder/utils/BUILD | 4 ++++
src/core/ext/transport/binder/wire_format/BUILD | 8 ++++++++
4 files changed, 21 insertions(+)
diff --git a/src/core/ext/transport/binder/client/BUILD b/src/core/ext/transport/binder/client/BUILD
index 7b7b1e4eb3e..d942e7e0f08 100644
--- a/src/core/ext/transport/binder/client/BUILD
+++ b/src/core/ext/transport/binder/client/BUILD
@@ -18,6 +18,9 @@ licenses(["notice"])
package(
default_visibility = ["//visibility:public"],
+ features = [
+ "layering_check",
+ ],
)
# TODO(mingcl): See if it is possible to add flags that warns about undefined symbol at link time
@@ -40,6 +43,7 @@ grpc_cc_library(
":grpc_transport_binder_client_impl",
"//:gpr",
"//:gpr_base",
+ "//:gpr_platform",
"//:grpc",
"//:grpc++_base",
"//:grpc_base",
@@ -60,6 +64,7 @@ grpc_cc_library(
deps = [
"//:gpr",
"//:gpr_base",
+ "//:gpr_platform",
"//:grpc",
"//:grpc++_base",
"//:grpc_base",
diff --git a/src/core/ext/transport/binder/transport/BUILD b/src/core/ext/transport/binder/transport/BUILD
index 430a7ee6b8d..0923da1e6f5 100644
--- a/src/core/ext/transport/binder/transport/BUILD
+++ b/src/core/ext/transport/binder/transport/BUILD
@@ -18,6 +18,9 @@ licenses(["notice"])
package(
default_visibility = ["//visibility:public"],
+ features = [
+ "layering_check",
+ ],
)
grpc_cc_library(
@@ -36,6 +39,7 @@ grpc_cc_library(
deps = [
"//:gpr",
"//:gpr_base",
+ "//:gpr_platform",
"//:grpc",
"//:grpc_base",
"//:grpc_base_c",
diff --git a/src/core/ext/transport/binder/utils/BUILD b/src/core/ext/transport/binder/utils/BUILD
index 1027f98b03c..50e86a9a033 100644
--- a/src/core/ext/transport/binder/utils/BUILD
+++ b/src/core/ext/transport/binder/utils/BUILD
@@ -18,6 +18,9 @@ licenses(["notice"])
package(
default_visibility = ["//visibility:public"],
+ features = [
+ "layering_check",
+ ],
)
grpc_cc_library(
@@ -37,6 +40,7 @@ grpc_cc_library(
deps = [
"//:gpr",
"//:gpr_base",
+ "//:gpr_platform",
"//src/core/ext/transport/binder/wire_format:transaction",
],
)
diff --git a/src/core/ext/transport/binder/wire_format/BUILD b/src/core/ext/transport/binder/wire_format/BUILD
index b31cfd798a2..6e0a3d961f3 100644
--- a/src/core/ext/transport/binder/wire_format/BUILD
+++ b/src/core/ext/transport/binder/wire_format/BUILD
@@ -18,6 +18,9 @@ licenses(["notice"])
package(
default_visibility = ["//visibility:public"],
+ features = [
+ "layering_check",
+ ],
)
grpc_cc_library(
@@ -34,6 +37,7 @@ grpc_cc_library(
],
deps = [
"//:gpr",
+ "//:gpr_platform",
],
)
@@ -53,6 +57,7 @@ grpc_cc_library(
],
deps = [
"//:gpr",
+ "//:gpr_platform",
"//:orphanable",
],
)
@@ -72,6 +77,7 @@ grpc_cc_library(
deps = [
":binder",
":wire_reader",
+ "//:gpr_platform",
],
)
@@ -87,6 +93,7 @@ grpc_cc_library(
":transaction",
"//:gpr",
"//:gpr_base",
+ "//:gpr_platform",
],
)
@@ -107,6 +114,7 @@ grpc_cc_library(
":binder",
":wire_writer",
"//:gpr",
+ "//:gpr_platform",
"//:orphanable",
"//src/core/ext/transport/binder/utils:transport_stream_receiver",
],