GcpObservabilityConfig: s/disabled/enabled (#30905)

src/cpp/ext/gcp/observability_config.h

@@ -29,40 +29,40 @@ namespace internal {
 
 struct GcpObservabilityConfig {
   struct CloudLogging {
-    bool enabled = false;
+    bool disabled = false;
 
     static const grpc_core::JsonLoaderInterface* JsonLoader(
         const grpc_core::JsonArgs&) {
       static const auto* loader =
           grpc_core::JsonObjectLoader<CloudLogging>()
-              .OptionalField("enabled", &CloudLogging::enabled)
+              .OptionalField("disabled", &CloudLogging::disabled)
               .Finish();
       return loader;
     }
   };
 
   struct CloudMonitoring {
-    bool enabled = false;
+    bool disabled = false;
 
     static const grpc_core::JsonLoaderInterface* JsonLoader(
         const grpc_core::JsonArgs&) {
       static const auto* loader =
           grpc_core::JsonObjectLoader<CloudMonitoring>()
-              .OptionalField("enabled", &CloudMonitoring::enabled)
+              .OptionalField("disabled", &CloudMonitoring::disabled)
               .Finish();
       return loader;
     }
   };
 
   struct CloudTrace {
-    bool enabled = false;
+    bool disabled = false;
     float sampling_rate = 0;
 
     static const grpc_core::JsonLoaderInterface* JsonLoader(
         const grpc_core::JsonArgs&) {
       static const auto* loader =
           grpc_core::JsonObjectLoader<CloudTrace>()
-              .OptionalField("enabled", &CloudTrace::enabled)
+              .OptionalField("disabled", &CloudTrace::disabled)
               .OptionalField("sampling_rate", &CloudTrace::sampling_rate)
               .Finish();
       return loader;

test/cpp/ext/gcp/observability_config_test.cc

@@ -32,13 +32,13 @@ namespace {
 TEST(GcpObservabilityConfigJsonParsingTest, Basic) {
   const char* json_str = R"json({
       "cloud_logging": {
-        "enabled": true
+        "disabled": true
       },
       "cloud_monitoring": {
-        "enabled": true
+        "disabled": true
       },
       "cloud_trace": {
-        "enabled": true,
+        "disabled": true,
         "sampling_rate": 0.05
       },
       "project_id": "project"
@@ -49,9 +49,9 @@ TEST(GcpObservabilityConfigJsonParsingTest, Basic) {
   auto config = grpc_core::LoadFromJson<GcpObservabilityConfig>(
       *json, grpc_core::JsonArgs(), &errors);
   ASSERT_TRUE(errors.ok()) << errors.status();
-  EXPECT_TRUE(config.cloud_logging.enabled);
+  EXPECT_TRUE(config.cloud_logging.disabled);
-  EXPECT_TRUE(config.cloud_monitoring.enabled);
+  EXPECT_TRUE(config.cloud_monitoring.disabled);
-  EXPECT_TRUE(config.cloud_trace.enabled);
+  EXPECT_TRUE(config.cloud_trace.disabled);
   EXPECT_FLOAT_EQ(config.cloud_trace.sampling_rate, 0.05);
   EXPECT_EQ(config.project_id, "project");
 }
@@ -65,9 +65,10 @@ TEST(GcpObservabilityConfigJsonParsingTest, Defaults) {
   auto config = grpc_core::LoadFromJson<GcpObservabilityConfig>(
       *json, grpc_core::JsonArgs(), &errors);
   ASSERT_TRUE(errors.ok()) << errors.status();
-  EXPECT_FALSE(config.cloud_logging.enabled);
+  EXPECT_FALSE(config.cloud_logging.disabled);
-  EXPECT_FALSE(config.cloud_monitoring.enabled);
+  EXPECT_FALSE(config.cloud_monitoring.disabled);
-  EXPECT_FALSE(config.cloud_trace.enabled);
+  EXPECT_FALSE(config.cloud_trace.disabled);
+  EXPECT_FLOAT_EQ(config.cloud_trace.sampling_rate, 0);
   EXPECT_TRUE(config.project_id.empty());
 }