address comments

pull/18852/head
Muxi Yan 6 years ago
parent 2cb1892c77
commit eb62ad3fae
  1. 2
      src/objective-c/GRPCClient/GRPCInterceptor.h
  2. 50
      src/objective-c/GRPCClient/GRPCInterceptor.m

@ -74,7 +74,7 @@
* receiveNextMessages * receiveNextMessages
* didReceiveInitialMetadata * didReceiveInitialMetadata
* didReceiveData * didReceiveData
* didWriteData * didWriteData receiveNextmessages
* writeData ----- ----- ---- didReceiveInitialMetadata * writeData ----- ----- ---- didReceiveInitialMetadata
* receiveNextMessages | | | | | | didReceiveData * receiveNextMessages | | | | | | didReceiveData
* | V | V | V didWriteData * | V | V | V didWriteData

@ -44,39 +44,49 @@
- (void)startNextInterceptorWithRequest:(GRPCRequestOptions *)requestOptions - (void)startNextInterceptorWithRequest:(GRPCRequestOptions *)requestOptions
callOptions:(GRPCCallOptions *)callOptions { callOptions:(GRPCCallOptions *)callOptions {
id<GRPCInterceptorInterface> copiedNextInterceptor = _nextInterceptor; if (_nextInterceptor != nil) {
dispatch_async(copiedNextInterceptor.requestDispatchQueue, ^{ id<GRPCInterceptorInterface> copiedNextInterceptor = _nextInterceptor;
[copiedNextInterceptor startWithRequestOptions:requestOptions callOptions:callOptions]; dispatch_async(copiedNextInterceptor.requestDispatchQueue, ^{
}); [copiedNextInterceptor startWithRequestOptions:requestOptions callOptions:callOptions];
});
}
} }
- (void)writeNextInterceptorWithData:(id)data { - (void)writeNextInterceptorWithData:(id)data {
id<GRPCInterceptorInterface> copiedNextInterceptor = _nextInterceptor; if (_nextInterceptor != nil) {
dispatch_async(copiedNextInterceptor.requestDispatchQueue, ^{ id<GRPCInterceptorInterface> copiedNextInterceptor = _nextInterceptor;
[copiedNextInterceptor writeData:data]; dispatch_async(copiedNextInterceptor.requestDispatchQueue, ^{
}); [copiedNextInterceptor writeData:data];
});
}
} }
- (void)finishNextInterceptor { - (void)finishNextInterceptor {
id<GRPCInterceptorInterface> copiedNextInterceptor = _nextInterceptor; if (_nextInterceptor != nil) {
dispatch_async(copiedNextInterceptor.requestDispatchQueue, ^{ id<GRPCInterceptorInterface> copiedNextInterceptor = _nextInterceptor;
[copiedNextInterceptor finish]; dispatch_async(copiedNextInterceptor.requestDispatchQueue, ^{
}); [copiedNextInterceptor finish];
});
}
} }
- (void)cancelNextInterceptor { - (void)cancelNextInterceptor {
id<GRPCInterceptorInterface> copiedNextInterceptor = _nextInterceptor; if (_nextInterceptor != nil) {
dispatch_async(copiedNextInterceptor.requestDispatchQueue, ^{ id<GRPCInterceptorInterface> copiedNextInterceptor = _nextInterceptor;
[copiedNextInterceptor cancel]; dispatch_async(copiedNextInterceptor.requestDispatchQueue, ^{
}); [copiedNextInterceptor cancel];
});
}
} }
/** Notify the next interceptor in the chain to receive more messages */ /** Notify the next interceptor in the chain to receive more messages */
- (void)receiveNextInterceptorMessages:(NSUInteger)numberOfMessages { - (void)receiveNextInterceptorMessages:(NSUInteger)numberOfMessages {
id<GRPCInterceptorInterface> copiedNextInterceptor = _nextInterceptor; if (_nextInterceptor != nil) {
dispatch_async(copiedNextInterceptor.requestDispatchQueue, ^{ id<GRPCInterceptorInterface> copiedNextInterceptor = _nextInterceptor;
[copiedNextInterceptor receiveNextMessages:numberOfMessages]; dispatch_async(copiedNextInterceptor.requestDispatchQueue, ^{
}); [copiedNextInterceptor receiveNextMessages:numberOfMessages];
});
}
} }
// Methods to forward GRPCResponseHandler callbacks to the previous object // Methods to forward GRPCResponseHandler callbacks to the previous object

Loading…
Cancel
Save