[RBE windows] Use bazel 6.3.2 on windows RBE (after regenerating toolchain) (#34216)

- Upgrade windows RBE builds to bazel 6.3.2 (supersedes
https://github.com/grpc/grpc/pull/33880). To be able to do that, the RBE
toolchain needed to be regenerated and
- Also added "--dynamic_mode=off" option for windows build since it
seemed necessary for bazel 6.x builds to pass.
- Wrote instructions for generating windows RBE toolchain using the
`rbe_configs_gen` tool (the original windows RBE toolchain was out of
data and also it was generated by a custom script from
go/rbe-windows-user-guide - using a standard tool is better)
- Wrote instructions for rebuilding the windows RBE docker image.

This addresses the problem where windows RBE is stuck on bazel 5.x
(unlike the rest of the repository) and also documents the steps for
making changes to the RBE docker image (e.g. upgrading the visual studio
version used by RBE).

Since we were planning on adding testing for VS2022 (for which we don't
have any test ATM), this will definitely come handy. With the
documentation the process should now be relatively straightforward.
pull/34233/head
Jan Tattermusch 1 year ago committed by GitHub
parent 7c79712d13
commit eae3082829
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 6
      test/distrib/bazel/test_single_bazel_version.sh
  2. 12
      third_party/toolchains/BUILD
  3. 40
      third_party/toolchains/README.md
  4. 57
      third_party/toolchains/generate_windows_rbe_configs.sh
  5. 202
      third_party/toolchains/rbe_windows_bazel_6.3.2_vs2019/LICENSE
  6. 4
      third_party/toolchains/rbe_windows_bazel_6.3.2_vs2019/cc/BUILD
  7. 2
      third_party/toolchains/rbe_windows_bazel_6.3.2_vs2019/cc/WORKSPACE
  8. 2
      third_party/toolchains/rbe_windows_bazel_6.3.2_vs2019/cc/armeabi_cc_toolchain_config.bzl
  9. 7
      third_party/toolchains/rbe_windows_bazel_6.3.2_vs2019/cc/builtin_include_directory_paths_clangcl
  10. 8
      third_party/toolchains/rbe_windows_bazel_6.3.2_vs2019/cc/builtin_include_directory_paths_mingw
  11. 2
      third_party/toolchains/rbe_windows_bazel_6.3.2_vs2019/cc/builtin_include_directory_paths_msvc
  12. 24
      third_party/toolchains/rbe_windows_bazel_6.3.2_vs2019/cc/clang_installation_error.bat
  13. 3
      third_party/toolchains/rbe_windows_bazel_6.3.2_vs2019/cc/get_env.bat
  14. 23
      third_party/toolchains/rbe_windows_bazel_6.3.2_vs2019/cc/msys_gcc_installation_error.bat
  15. 29
      third_party/toolchains/rbe_windows_bazel_6.3.2_vs2019/cc/vc_installation_error_arm.bat
  16. 29
      third_party/toolchains/rbe_windows_bazel_6.3.2_vs2019/cc/vc_installation_error_arm64.bat
  17. 194
      third_party/toolchains/rbe_windows_bazel_6.3.2_vs2019/cc/windows_cc_toolchain_config.bzl
  18. 46
      third_party/toolchains/rbe_windows_bazel_6.3.2_vs2019/config/BUILD
  19. 2
      tools/internal_ci/windows/bazel_rbe.bat
  20. 4
      tools/remote_build/windows.bazelrc

@ -61,9 +61,9 @@ EXCLUDED_TARGETS=(
# This could be a legitmate failure due to bitrot.
"-//src/proto/grpc/testing:test_gen_proto"
# This appears to be a legitimately broken BUILD file. There's a reference to
# a non-existent "link_dynamic_library.sh".
"-//third_party/toolchains/rbe_windows_bazel_5.2.0_vs2019:all"
# Analyzing windows toolchains when running on linux results in an error.
# Since bazel distribtests are run on linux, we exclude the windows RBE toolchains.
"-//third_party/toolchains/rbe_windows_bazel_6.3.2_vs2019/..."
"-//third_party/toolchains:rbe_windows_default_toolchain_suite"
# TODO(jtattermusch): add back once fixed

@ -52,25 +52,21 @@ platform(
# The default toolchain suite for RBE windows, pass it to --crosstool_top
alias(
name = "rbe_windows_default_toolchain_suite",
actual = "//third_party/toolchains/rbe_windows_bazel_5.2.0_vs2019:toolchain",
actual = "//third_party/toolchains/rbe_windows_bazel_6.3.2_vs2019/cc:toolchain",
)
# The default CC toolchain suite for RBE windows
alias(
name = "rbe_windows_default_cc_toolchain",
actual = "//third_party/toolchains/rbe_windows_bazel_5.2.0_vs2019:cc-toolchain-x64_windows",
actual = "//third_party/toolchains/rbe_windows_bazel_6.3.2_vs2019/config:cc-toolchain",
)
# The default platform for RBE windows
platform(
name = "rbe_windows_default_platform",
constraint_values = [
"@platforms//cpu:x86_64",
"@platforms//os:windows",
],
# Inherit from the platform target generated by 'rbe_configs_gen'.
parents = ["//third_party/toolchains/rbe_windows_bazel_6.3.2_vs2019/config:platform"],
exec_properties = create_rbe_exec_properties_dict(
# See rbe_win2019/Dockerfile for image details
container_image = "docker://gcr.io/grpc-testing/rbe_windows2019@sha256:41772e8eeb9dd8c8b996bf32d58164d84b2315c8e81e634bbff5a0216b7f52fd",
os_family = "Windows",
# by default, all RBE actions will run on "small" workers.
labels = {"os": "windows_2019", "machine_size": "small"},

@ -1,11 +1,37 @@
# RBE toolchain configuration (Linux and Windows)
- rbe_ubuntu2004: Autogenerated toolchain configuration for linux RBE.
Run `generate_linux_rbe_configs.sh` to regenerate.
## Linux
The `rbe_ubuntu2004` directory contains the autogenerated toolchain configuration for linux RBE.
Run `generate_linux_rbe_configs.sh` to regenerate.
- rbe_windows_bazel_5.2.0_vs2019: The autogenerated toolchain configuration for windows RBE.
Note that the bazel version denotes the bazel version that was used to generate the toolchain configuration. The configuration
can be use with different bazel versions (as long as it works).
See go/rbe-windows-user-guide
## Windows
- rbe_win2019: The windows dockerfile to rebuild the docker image we use on RBE workers. See go/rbe-windows-user-guide
The `rbe_windows_bazel_6.3.2_vs2019` directory contains the autogenerated toolchain configuration for windows RBE.
The configuration was generated by the `rbe_configs_gen` tool (just as the linux RBE config),
but since it's a windows configuration, it needs to be run on a windows machine.
In order to regenerate:
- Clone `grpc` repository in a kokoro debug windows VM (see internal documentation for how to create one)
- Run `generate_windows_rbe_configs.sh` to regenerate the configs locally on the VM.
- Copy the generated configs back to your workstation (e.g. via `gcloud compute scp` command)
Note that the bazel version denotes the bazel version that was used to generate the toolchain configuration. The configuration
can be use with different bazel versions (as long as it works).
Also see go/rbe-windows-user-guide
# Windows RBE docker image
The `rbe_win2019` directory contains the dockerfile to rebuild the docker image we use on RBE windows workers. See go/rbe-windows-user-guide.
Note that for linux, we use a docker image under `tools/dockerfile` (since for Linux RBE docker image is simply of the testing docker images
we maintain)
## How to rebuild the Windows RBE docker image and use it for Windows RBE
On a kokoro debug windows VM, run the following:
- `docker build -t us-docker.pkg.dev/grpc-testing/testing-images-public/rbe_windows2019 third_party/toolchains/rbe_win2019`
- To be able to authenticate when pushing the image to GAR, run `gcloud auth configure-docker us-docker.pkg.dev`
- `docker push us-docker.pkg.dev/grpc-testing/testing-images-public/rbe_windows2019`
- Update the `generate_windows_rbe_configs.sh` with the newly built & pushed image's SHA256 digest.
- Regenerate the Windows RBE toolchain with the instructions above.

@ -0,0 +1,57 @@
#!/bin/bash
# Copyright 2023 The gRPC Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
# Generate windows RBE configs using rbe_configs_gen.
# See https://github.com/bazelbuild/bazel-toolchains#rbe_configs_gen---cli-tool-to-generate-configs
set -ex
cd $(dirname $0)/../..
REPO_ROOT="$(pwd)"
# Download a recent version of rbe_configs_gen binary
wget https://github.com/bazelbuild/bazel-toolchains/releases/download/v5.1.2/rbe_configs_gen_windows_amd64.exe
RBE_CONFIGS_GEN_TOOL_PATH="./rbe_configs_gen_windows_amd64.exe"
# Actions on RBE will run under a dedicated docker image.
WINDOWS_RBE_DOCKER_IMAGE=gcr.io/grpc-testing/rbe_windows2019@sha256:41772e8eeb9dd8c8b996bf32d58164d84b2315c8e81e634bbff5a0216b7f52fd
# Bazel version used for configuring
# Needs to be one of the versions from bazel/supported_versions.txt chosen so that the result is compatible
# with other supported bazel versions.
BAZEL_VERSION=6.3.2
# Where to store the generated configs (relative to repo root)
CONFIG_OUTPUT_PATH=third_party/toolchains/rbe_windows_bazel_6.3.2_vs2019
# Delete old generated configs.
rm -rf "${REPO_ROOT}/${CONFIG_OUTPUT_PATH}"
# Pull the RBE windows docker image first.
# Note that you need to run "gcloud auth configure-docker gcr.io" first to be able to pull the image from gcr.io
# TOOD(jtattermusch): investigate why pulling a docker image on windows is extremely slow.
# TODO(jtattermusch): move the RBE windows docker image to GAR where it will be publicly accessible.
docker pull ${WINDOWS_RBE_DOCKER_IMAGE}
${RBE_CONFIGS_GEN_TOOL_PATH} \
--bazel_version="${BAZEL_VERSION}" \
--toolchain_container="${WINDOWS_RBE_DOCKER_IMAGE}" \
--output_src_root="${REPO_ROOT}" \
--output_config_path="${CONFIG_OUTPUT_PATH}" \
--exec_os=windows \
--target_os=windows \
--generate_java_configs=false

@ -0,0 +1,202 @@
Apache License
Version 2.0, January 2004
http://www.apache.org/licenses/
TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
1. Definitions.
"License" shall mean the terms and conditions for use, reproduction,
and distribution as defined by Sections 1 through 9 of this document.
"Licensor" shall mean the copyright owner or entity authorized by
the copyright owner that is granting the License.
"Legal Entity" shall mean the union of the acting entity and all
other entities that control, are controlled by, or are under common
control with that entity. For the purposes of this definition,
"control" means (i) the power, direct or indirect, to cause the
direction or management of such entity, whether by contract or
otherwise, or (ii) ownership of fifty percent (50%) or more of the
outstanding shares, or (iii) beneficial ownership of such entity.
"You" (or "Your") shall mean an individual or Legal Entity
exercising permissions granted by this License.
"Source" form shall mean the preferred form for making modifications,
including but not limited to software source code, documentation
source, and configuration files.
"Object" form shall mean any form resulting from mechanical
transformation or translation of a Source form, including but
not limited to compiled object code, generated documentation,
and conversions to other media types.
"Work" shall mean the work of authorship, whether in Source or
Object form, made available under the License, as indicated by a
copyright notice that is included in or attached to the work
(an example is provided in the Appendix below).
"Derivative Works" shall mean any work, whether in Source or Object
form, that is based on (or derived from) the Work and for which the
editorial revisions, annotations, elaborations, or other modifications
represent, as a whole, an original work of authorship. For the purposes
of this License, Derivative Works shall not include works that remain
separable from, or merely link (or bind by name) to the interfaces of,
the Work and Derivative Works thereof.
"Contribution" shall mean any work of authorship, including
the original version of the Work and any modifications or additions
to that Work or Derivative Works thereof, that is intentionally
submitted to Licensor for inclusion in the Work by the copyright owner
or by an individual or Legal Entity authorized to submit on behalf of
the copyright owner. For the purposes of this definition, "submitted"
means any form of electronic, verbal, or written communication sent
to the Licensor or its representatives, including but not limited to
communication on electronic mailing lists, source code control systems,
and issue tracking systems that are managed by, or on behalf of, the
Licensor for the purpose of discussing and improving the Work, but
excluding communication that is conspicuously marked or otherwise
designated in writing by the copyright owner as "Not a Contribution."
"Contributor" shall mean Licensor and any individual or Legal Entity
on behalf of whom a Contribution has been received by Licensor and
subsequently incorporated within the Work.
2. Grant of Copyright License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
copyright license to reproduce, prepare Derivative Works of,
publicly display, publicly perform, sublicense, and distribute the
Work and such Derivative Works in Source or Object form.
3. Grant of Patent License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
(except as stated in this section) patent license to make, have made,
use, offer to sell, sell, import, and otherwise transfer the Work,
where such license applies only to those patent claims licensable
by such Contributor that are necessarily infringed by their
Contribution(s) alone or by combination of their Contribution(s)
with the Work to which such Contribution(s) was submitted. If You
institute patent litigation against any entity (including a
cross-claim or counterclaim in a lawsuit) alleging that the Work
or a Contribution incorporated within the Work constitutes direct
or contributory patent infringement, then any patent licenses
granted to You under this License for that Work shall terminate
as of the date such litigation is filed.
4. Redistribution. You may reproduce and distribute copies of the
Work or Derivative Works thereof in any medium, with or without
modifications, and in Source or Object form, provided that You
meet the following conditions:
(a) You must give any other recipients of the Work or
Derivative Works a copy of this License; and
(b) You must cause any modified files to carry prominent notices
stating that You changed the files; and
(c) You must retain, in the Source form of any Derivative Works
that You distribute, all copyright, patent, trademark, and
attribution notices from the Source form of the Work,
excluding those notices that do not pertain to any part of
the Derivative Works; and
(d) If the Work includes a "NOTICE" text file as part of its
distribution, then any Derivative Works that You distribute must
include a readable copy of the attribution notices contained
within such NOTICE file, excluding those notices that do not
pertain to any part of the Derivative Works, in at least one
of the following places: within a NOTICE text file distributed
as part of the Derivative Works; within the Source form or
documentation, if provided along with the Derivative Works; or,
within a display generated by the Derivative Works, if and
wherever such third-party notices normally appear. The contents
of the NOTICE file are for informational purposes only and
do not modify the License. You may add Your own attribution
notices within Derivative Works that You distribute, alongside
or as an addendum to the NOTICE text from the Work, provided
that such additional attribution notices cannot be construed
as modifying the License.
You may add Your own copyright statement to Your modifications and
may provide additional or different license terms and conditions
for use, reproduction, or distribution of Your modifications, or
for any such Derivative Works as a whole, provided Your use,
reproduction, and distribution of the Work otherwise complies with
the conditions stated in this License.
5. Submission of Contributions. Unless You explicitly state otherwise,
any Contribution intentionally submitted for inclusion in the Work
by You to the Licensor shall be under the terms and conditions of
this License, without any additional terms or conditions.
Notwithstanding the above, nothing herein shall supersede or modify
the terms of any separate license agreement you may have executed
with Licensor regarding such Contributions.
6. Trademarks. This License does not grant permission to use the trade
names, trademarks, service marks, or product names of the Licensor,
except as required for reasonable and customary use in describing the
origin of the Work and reproducing the content of the NOTICE file.
7. Disclaimer of Warranty. Unless required by applicable law or
agreed to in writing, Licensor provides the Work (and each
Contributor provides its Contributions) on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied, including, without limitation, any warranties or conditions
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
PARTICULAR PURPOSE. You are solely responsible for determining the
appropriateness of using or redistributing the Work and assume any
risks associated with Your exercise of permissions under this License.
8. Limitation of Liability. In no event and under no legal theory,
whether in tort (including negligence), contract, or otherwise,
unless required by applicable law (such as deliberate and grossly
negligent acts) or agreed to in writing, shall any Contributor be
liable to You for damages, including any direct, indirect, special,
incidental, or consequential damages of any character arising as a
result of this License or out of the use or inability to use the
Work (including but not limited to damages for loss of goodwill,
work stoppage, computer failure or malfunction, or any and all
other commercial damages or losses), even if such Contributor
has been advised of the possibility of such damages.
9. Accepting Warranty or Additional Liability. While redistributing
the Work or Derivative Works thereof, You may choose to offer,
and charge a fee for, acceptance of support, warranty, indemnity,
or other liability obligations and/or rights consistent with this
License. However, in accepting such obligations, You may act only
on Your own behalf and on Your sole responsibility, not on behalf
of any other Contributor, and only if You agree to indemnify,
defend, and hold each Contributor harmless for any liability
incurred by, or claims asserted against, such Contributor by reason
of your accepting any such warranty or additional liability.
END OF TERMS AND CONDITIONS
APPENDIX: How to apply the Apache License to your work.
To apply the Apache License to your work, attach the following
boilerplate notice, with the fields enclosed by brackets "[]"
replaced with your own identifying information. (Don't include
the brackets!) The text should be enclosed in the appropriate
comment syntax for the file format. We also recommend that a
file or class name and description of purpose be included on the
same "printed page" as the copyright notice for easier
identification within third-party archives.
Copyright 2021 Google LLC
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.

@ -96,7 +96,6 @@ cc_toolchain_config(
cxx_builtin_include_directories = [ "c:/msys64/usr/",
],
tool_paths = {"ar": "c:/msys64/usr/bin/ar",
"compat-ld": "c:/msys64/usr/bin/compat-ld",
"cpp": "c:/msys64/usr/bin/cpp",
"dwp": "c:/msys64/usr/bin/dwp",
"gcc": "c:/msys64/usr/bin/gcc",
@ -154,7 +153,6 @@ cc_toolchain_config(
cxx_builtin_include_directories = [ "c:/msys64/mingw64/",
],
tool_paths = {"ar": "c:/msys64/mingw64/bin/ar",
"compat-ld": "c:/msys64/mingw64/bin/compat-ld",
"cpp": "c:/msys64/mingw64/bin/cpp",
"dwp": "c:/msys64/mingw64/bin/dwp",
"gcc": "c:/msys64/mingw64/bin/gcc",
@ -612,7 +610,7 @@ toolchain(
exec_compatible_with = [
],
target_compatible_with = [
"@platforms//cpu:arm",
"@platforms//cpu:armv7",
"@platforms//os:android",
],
toolchain = ":cc-compiler-armeabi-v7a",

@ -0,0 +1,2 @@
# DO NOT EDIT: automatically generated WORKSPACE file for cc_autoconf rule
workspace(name = "local_config_cc")

@ -43,12 +43,12 @@ def _impl(ctx):
tool_paths = [
tool_path(name = "ar", path = "/bin/false"),
tool_path(name = "compat-ld", path = "/bin/false"),
tool_path(name = "cpp", path = "/bin/false"),
tool_path(name = "dwp", path = "/bin/false"),
tool_path(name = "gcc", path = "/bin/false"),
tool_path(name = "gcov", path = "/bin/false"),
tool_path(name = "ld", path = "/bin/false"),
tool_path(name = "llvm-profdata", path = "/bin/false"),
tool_path(name = "nm", path = "/bin/false"),
tool_path(name = "objcopy", path = "/bin/false"),
tool_path(name = "objdump", path = "/bin/false"),

@ -0,0 +1,7 @@
This file is generated by cc_configure and contains builtin include directories
that clang-cl reported. This file is a dependency of every compilation action and
changes to it will be reflected in the action cache key. When some of these
paths change, Bazel will make sure to rerun the action, even though none of
declared action inputs or the action commandline changes.

@ -0,0 +1,8 @@
This file is generated by cc_configure and contains builtin include directories
that mingw reported. This file is a dependency of every compilation action and
changes to it will be reflected in the action cache key. When some of these
paths change, Bazel will make sure to rerun the action, even though none of
declared action inputs or the action commandline changes.
"c:/msys64/mingw64/",

@ -3,3 +3,5 @@ that msvc reported. This file is a dependency of every compilation action and
changes to it will be reflected in the action cache key. When some of these
paths change, Bazel will make sure to rerun the action, even though none of
declared action inputs or the action commandline changes.

@ -0,0 +1,24 @@
:: Copyright 2019 The Bazel Authors. All rights reserved.
::
:: Licensed under the Apache License, Version 2.0 (the "License");
:: you may not use this file except in compliance with the License.
:: You may obtain a copy of the License at
::
:: http://www.apache.org/licenses/LICENSE-2.0
::
:: Unless required by applicable law or agreed to in writing, software
:: distributed under the License is distributed on an "AS IS" BASIS,
:: WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
:: See the License for the specific language governing permissions and
:: limitations under the License.
@echo OFF
echo. 1>&2
echo The target you are compiling requires the Clang compiler. 1>&2
echo Bazel couldn't find a valid Clang installation on your machine. 1>&2
echo Please check your installation following https://bazel.build/docs/windows#using 1>&2
echo. 1>&2
exit /b 1

@ -0,0 +1,3 @@
@echo off
call "C:\VS\VC\Auxiliary\Build\VCVARSALL.BAT" amd64 -vcvars_ver=14.29.30133 > NUL
echo PATH=%PATH%,INCLUDE=%INCLUDE%,LIB=%LIB%,WINDOWSSDKDIR=%WINDOWSSDKDIR%

@ -0,0 +1,23 @@
:: Copyright 2018 The Bazel Authors. All rights reserved.
::
:: Licensed under the Apache License, Version 2.0 (the "License");
:: you may not use this file except in compliance with the License.
:: You may obtain a copy of the License at
::
:: http://www.apache.org/licenses/LICENSE-2.0
::
:: Unless required by applicable law or agreed to in writing, software
:: distributed under the License is distributed on an "AS IS" BASIS,
:: WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
:: See the License for the specific language governing permissions and
:: limitations under the License.
@echo OFF
echo. 1>&2
echo The target you are compiling requires MSYS gcc / MINGW gcc. 1>&2
echo Bazel couldn't find gcc installation on your machine. 1>&2
echo Please install MSYS gcc / MINGW gcc and set BAZEL_SH environment variable 1>&2
echo. 1>&2
exit /b 1

@ -0,0 +1,29 @@
:: Copyright 2017 The Bazel Authors. All rights reserved.
::
:: Licensed under the Apache License, Version 2.0 (the "License");
:: you may not use this file except in compliance with the License.
:: You may obtain a copy of the License at
::
:: http://www.apache.org/licenses/LICENSE-2.0
::
:: Unless required by applicable law or agreed to in writing, software
:: distributed under the License is distributed on an "AS IS" BASIS,
:: WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
:: See the License for the specific language governing permissions and
:: limitations under the License.
@echo OFF
echo. 1>&2
echo The target you are compiling requires Visual C++ build tools. 1>&2
echo Bazel couldn't find a valid Visual C++ build tools installation on your machine. 1>&2
echo. 1>&2
echo Visual C++ build tools seems to be installed at C:\VS\VC 1>&2
echo But Bazel can't find the following tools: 1>&2
echo cl.exe, link.exe, lib.exe 1>&2
echo for arm target architecture 1>&2
echo. 1>&2
echo Please check your installation following https://bazel.build/docs/windows#using 1>&2
echo. 1>&2
exit /b 1

@ -0,0 +1,29 @@
:: Copyright 2017 The Bazel Authors. All rights reserved.
::
:: Licensed under the Apache License, Version 2.0 (the "License");
:: you may not use this file except in compliance with the License.
:: You may obtain a copy of the License at
::
:: http://www.apache.org/licenses/LICENSE-2.0
::
:: Unless required by applicable law or agreed to in writing, software
:: distributed under the License is distributed on an "AS IS" BASIS,
:: WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
:: See the License for the specific language governing permissions and
:: limitations under the License.
@echo OFF
echo. 1>&2
echo The target you are compiling requires Visual C++ build tools. 1>&2
echo Bazel couldn't find a valid Visual C++ build tools installation on your machine. 1>&2
echo. 1>&2
echo Visual C++ build tools seems to be installed at C:\VS\VC 1>&2
echo But Bazel can't find the following tools: 1>&2
echo cl.exe, link.exe, lib.exe 1>&2
echo for arm64 target architecture 1>&2
echo. 1>&2
echo Please check your installation following https://bazel.build/docs/windows#using 1>&2
echo. 1>&2
exit /b 1

@ -21,7 +21,6 @@ load(
"env_entry",
"env_set",
"feature",
"feature_set",
"flag_group",
"flag_set",
"tool",
@ -135,7 +134,6 @@ def _impl(ctx):
"output_execpath_flags",
"input_param_flags",
"user_link_flags",
"default_link_flags",
"linker_subsystem_flag",
"linker_param_file",
"msvc_env",
@ -184,6 +182,20 @@ def _impl(ctx):
c_compile_action = action_config(
action_name = ACTION_NAMES.c_compile,
implies = [
"compiler_input_flags",
"compiler_output_flags",
"nologo",
"msvc_env",
"parse_showincludes",
"user_compile_flags",
"sysroot",
],
tools = [tool(path = ctx.attr.msvc_cl_path)],
)
linkstamp_compile_action = action_config(
action_name = ACTION_NAMES.linkstamp_compile,
implies = [
"compiler_input_flags",
"compiler_output_flags",
@ -203,13 +215,11 @@ def _impl(ctx):
implies = [
"compiler_input_flags",
"compiler_output_flags",
"default_compile_flags",
"nologo",
"msvc_env",
"parse_showincludes",
"user_compile_flags",
"sysroot",
"unfiltered_compile_flags",
],
tools = [tool(path = ctx.attr.msvc_cl_path)],
)
@ -222,7 +232,6 @@ def _impl(ctx):
"output_execpath_flags",
"input_param_flags",
"user_link_flags",
"default_link_flags",
"linker_subsystem_flag",
"linker_param_file",
"msvc_env",
@ -240,7 +249,6 @@ def _impl(ctx):
"output_execpath_flags",
"input_param_flags",
"user_link_flags",
"default_link_flags",
"linker_subsystem_flag",
"linker_param_file",
"msvc_env",
@ -255,6 +263,7 @@ def _impl(ctx):
assemble_action,
preprocess_assemble_action,
c_compile_action,
linkstamp_compile_action,
cpp_compile_action,
cpp_link_executable_action,
cpp_link_dynamic_library_action,
@ -317,6 +326,7 @@ def _impl(ctx):
ACTION_NAMES.assemble,
ACTION_NAMES.preprocess_assemble,
ACTION_NAMES.c_compile,
ACTION_NAMES.linkstamp_compile,
ACTION_NAMES.cpp_compile,
ACTION_NAMES.cpp_header_parsing,
ACTION_NAMES.cpp_module_compile,
@ -338,11 +348,13 @@ def _impl(ctx):
unfiltered_compile_flags_feature = feature(
name = "unfiltered_compile_flags",
enabled = True,
flag_sets = [
flag_set(
actions = [
ACTION_NAMES.preprocess_assemble,
ACTION_NAMES.c_compile,
ACTION_NAMES.linkstamp_compile,
ACTION_NAMES.cpp_compile,
ACTION_NAMES.cpp_header_parsing,
ACTION_NAMES.cpp_module_compile,
@ -359,6 +371,11 @@ def _impl(ctx):
],
)
archive_param_file_feature = feature(
name = "archive_param_file",
enabled = True,
)
compiler_param_file_feature = feature(
name = "compiler_param_file",
)
@ -471,6 +488,7 @@ def _impl(ctx):
actions = [
ACTION_NAMES.preprocess_assemble,
ACTION_NAMES.c_compile,
ACTION_NAMES.linkstamp_compile,
ACTION_NAMES.cpp_compile,
ACTION_NAMES.cpp_header_parsing,
ACTION_NAMES.cpp_module_compile,
@ -516,21 +534,57 @@ def _impl(ctx):
],
)
static_link_msvcrt_feature = feature(name = "static_link_msvcrt")
static_link_msvcrt_feature = feature(
name = "static_link_msvcrt",
flag_sets = [
flag_set(
actions = [ACTION_NAMES.c_compile, ACTION_NAMES.cpp_compile],
flag_groups = [flag_group(flags = ["/MT"])],
with_features = [with_feature_set(not_features = ["dbg"])],
),
flag_set(
actions = [ACTION_NAMES.c_compile, ACTION_NAMES.cpp_compile],
flag_groups = [flag_group(flags = ["/MTd"])],
with_features = [with_feature_set(features = ["dbg"])],
),
flag_set(
actions = all_link_actions,
flag_groups = [flag_group(flags = ["/DEFAULTLIB:libcmt.lib"])],
with_features = [with_feature_set(not_features = ["dbg"])],
),
flag_set(
actions = all_link_actions,
flag_groups = [flag_group(flags = ["/DEFAULTLIB:libcmtd.lib"])],
with_features = [with_feature_set(features = ["dbg"])],
),
],
)
dynamic_link_msvcrt_debug_feature = feature(
name = "dynamic_link_msvcrt_debug",
dynamic_link_msvcrt_feature = feature(
name = "dynamic_link_msvcrt",
enabled = True,
flag_sets = [
flag_set(
actions = [ACTION_NAMES.c_compile, ACTION_NAMES.cpp_compile],
flag_groups = [flag_group(flags = ["/MD"])],
with_features = [with_feature_set(not_features = ["dbg", "static_link_msvcrt"])],
),
flag_set(
actions = [ACTION_NAMES.c_compile, ACTION_NAMES.cpp_compile],
flag_groups = [flag_group(flags = ["/MDd"])],
with_features = [with_feature_set(features = ["dbg"], not_features = ["static_link_msvcrt"])],
),
flag_set(
actions = all_link_actions,
flag_groups = [flag_group(flags = ["/DEFAULTLIB:msvcrt.lib"])],
with_features = [with_feature_set(not_features = ["dbg", "static_link_msvcrt"])],
),
flag_set(
actions = all_link_actions,
flag_groups = [flag_group(flags = ["/DEFAULTLIB:msvcrtd.lib"])],
with_features = [with_feature_set(features = ["dbg"], not_features = ["static_link_msvcrt"])],
),
],
requires = [feature_set(features = ["dbg"])],
)
dbg_feature = feature(
@ -629,6 +683,7 @@ def _impl(ctx):
env_set(
actions = [
ACTION_NAMES.c_compile,
ACTION_NAMES.linkstamp_compile,
ACTION_NAMES.cpp_compile,
ACTION_NAMES.cpp_module_compile,
ACTION_NAMES.cpp_module_codegen,
@ -650,6 +705,7 @@ def _impl(ctx):
ACTION_NAMES.assemble,
ACTION_NAMES.preprocess_assemble,
ACTION_NAMES.c_compile,
ACTION_NAMES.linkstamp_compile,
ACTION_NAMES.cpp_compile,
ACTION_NAMES.cpp_header_parsing,
ACTION_NAMES.cpp_module_compile,
@ -683,24 +739,6 @@ def _impl(ctx):
],
)
dynamic_link_msvcrt_no_debug_feature = feature(
name = "dynamic_link_msvcrt_no_debug",
flag_sets = [
flag_set(
actions = [ACTION_NAMES.c_compile, ACTION_NAMES.cpp_compile],
flag_groups = [flag_group(flags = ["/MD"])],
),
flag_set(
actions = all_link_actions,
flag_groups = [flag_group(flags = ["/DEFAULTLIB:msvcrt.lib"])],
),
],
requires = [
feature_set(features = ["fastbuild"]),
feature_set(features = ["opt"]),
],
)
disable_assertions_feature = feature(
name = "disable_assertions",
enabled = True,
@ -755,6 +793,7 @@ def _impl(ctx):
actions = [
ACTION_NAMES.preprocess_assemble,
ACTION_NAMES.c_compile,
ACTION_NAMES.linkstamp_compile,
ACTION_NAMES.cpp_compile,
ACTION_NAMES.cpp_module_compile,
ACTION_NAMES.cpp_header_parsing,
@ -764,29 +803,11 @@ def _impl(ctx):
],
)
static_link_msvcrt_no_debug_feature = feature(
name = "static_link_msvcrt_no_debug",
flag_sets = [
flag_set(
actions = [ACTION_NAMES.c_compile, ACTION_NAMES.cpp_compile],
flag_groups = [flag_group(flags = ["/MT"])],
),
flag_set(
actions = all_link_actions,
flag_groups = [flag_group(flags = ["/DEFAULTLIB:libcmt.lib"])],
),
],
requires = [
feature_set(features = ["fastbuild"]),
feature_set(features = ["opt"]),
],
)
treat_warnings_as_errors_feature = feature(
name = "treat_warnings_as_errors",
flag_sets = [
flag_set(
actions = [ACTION_NAMES.c_compile, ACTION_NAMES.cpp_compile],
actions = [ACTION_NAMES.c_compile, ACTION_NAMES.cpp_compile] + all_link_actions,
flag_groups = [flag_group(flags = ["/WX"])],
),
],
@ -805,6 +826,7 @@ def _impl(ctx):
ACTION_NAMES.assemble,
ACTION_NAMES.preprocess_assemble,
ACTION_NAMES.c_compile,
ACTION_NAMES.linkstamp_compile,
ACTION_NAMES.cpp_compile,
ACTION_NAMES.cpp_header_parsing,
ACTION_NAMES.cpp_module_compile,
@ -827,6 +849,32 @@ def _impl(ctx):
],
)
external_include_paths_feature = feature(
name = "external_include_paths",
flag_sets = [
flag_set(
actions = [
ACTION_NAMES.preprocess_assemble,
ACTION_NAMES.linkstamp_compile,
ACTION_NAMES.c_compile,
ACTION_NAMES.cpp_compile,
ACTION_NAMES.cpp_header_parsing,
ACTION_NAMES.cpp_module_compile,
ACTION_NAMES.clif_match,
ACTION_NAMES.objc_compile,
ACTION_NAMES.objcpp_compile,
],
flag_groups = [
flag_group(
flags = ["/external:I", "%{external_include_paths}"],
iterate_over = "external_include_paths",
expand_if_available = "external_include_paths",
),
],
),
],
)
linkstamps_feature = feature(
name = "linkstamps",
flag_sets = [
@ -859,21 +907,6 @@ def _impl(ctx):
],
)
static_link_msvcrt_debug_feature = feature(
name = "static_link_msvcrt_debug",
flag_sets = [
flag_set(
actions = [ACTION_NAMES.c_compile, ACTION_NAMES.cpp_compile],
flag_groups = [flag_group(flags = ["/MTd"])],
),
flag_set(
actions = all_link_actions,
flag_groups = [flag_group(flags = ["/DEFAULTLIB:libcmtd.lib"])],
),
],
requires = [feature_set(features = ["dbg"])],
)
frame_pointer_feature = feature(
name = "frame_pointer",
flag_sets = [
@ -906,6 +939,7 @@ def _impl(ctx):
actions = [
ACTION_NAMES.preprocess_assemble,
ACTION_NAMES.c_compile,
ACTION_NAMES.linkstamp_compile,
ACTION_NAMES.cpp_compile,
ACTION_NAMES.cpp_header_parsing,
ACTION_NAMES.cpp_module_compile,
@ -951,6 +985,7 @@ def _impl(ctx):
flag_set(
actions = [
ACTION_NAMES.c_compile,
ACTION_NAMES.linkstamp_compile,
ACTION_NAMES.cpp_compile,
ACTION_NAMES.cpp_module_compile,
ACTION_NAMES.cpp_module_codegen,
@ -992,6 +1027,7 @@ def _impl(ctx):
ACTION_NAMES.assemble,
ACTION_NAMES.preprocess_assemble,
ACTION_NAMES.c_compile,
ACTION_NAMES.linkstamp_compile,
ACTION_NAMES.cpp_compile,
ACTION_NAMES.cpp_header_parsing,
ACTION_NAMES.cpp_module_compile,
@ -1028,6 +1064,7 @@ def _impl(ctx):
env_set(
actions = [
ACTION_NAMES.c_compile,
ACTION_NAMES.linkstamp_compile,
ACTION_NAMES.cpp_compile,
ACTION_NAMES.cpp_module_compile,
ACTION_NAMES.cpp_module_codegen,
@ -1060,6 +1097,7 @@ def _impl(ctx):
msvc_compile_env_feature,
msvc_link_env_feature,
include_paths_feature,
external_include_paths_feature,
preprocessor_defines_feature,
parse_showincludes_feature,
generate_pdb_file_feature,
@ -1073,10 +1111,7 @@ def _impl(ctx):
default_link_flags_feature,
linker_param_file_feature,
static_link_msvcrt_feature,
static_link_msvcrt_no_debug_feature,
dynamic_link_msvcrt_no_debug_feature,
static_link_msvcrt_debug_feature,
dynamic_link_msvcrt_debug_feature,
dynamic_link_msvcrt_feature,
dbg_feature,
fastbuild_feature,
opt_feature,
@ -1089,6 +1124,7 @@ def _impl(ctx):
user_compile_flags_feature,
sysroot_feature,
unfiltered_compile_flags_feature,
archive_param_file_feature,
compiler_param_file_feature,
compiler_output_flags_feature,
compiler_input_flags_feature,
@ -1114,6 +1150,7 @@ def _impl(ctx):
env_set(
actions = [
ACTION_NAMES.c_compile,
ACTION_NAMES.linkstamp_compile,
ACTION_NAMES.cpp_compile,
ACTION_NAMES.cpp_module_compile,
ACTION_NAMES.cpp_module_codegen,
@ -1198,6 +1235,11 @@ def _impl(ctx):
)
if ctx.attr.cpu == "x64_windows" and ctx.attr.compiler == "mingw-gcc":
archive_param_file_feature = feature(
name = "archive_param_file",
enabled = True,
)
compiler_param_file_feature = feature(
name = "compiler_param_file",
)
@ -1207,6 +1249,7 @@ def _impl(ctx):
copy_dynamic_libraries_to_binary_feature,
gcc_env_feature,
default_compile_flags_feature,
archive_param_file_feature,
compiler_param_file_feature,
default_link_flags_feature,
supports_dynamic_linker_feature,
@ -1218,10 +1261,6 @@ def _impl(ctx):
name = "supports_pic",
enabled = True,
)
supports_start_end_lib_feature = feature(
name = "supports_start_end_lib",
enabled = True,
)
sysroot_feature = feature(
name = "sysroot",
@ -1271,6 +1310,20 @@ def _impl(ctx):
provides = ["profile"],
)
treat_warnings_as_errors_feature = feature(
name = "treat_warnings_as_errors",
flag_sets = [
flag_set(
actions = [ACTION_NAMES.c_compile, ACTION_NAMES.cpp_compile],
flag_groups = [flag_group(flags = ["-Werror"])],
),
flag_set(
actions = all_link_actions,
flag_groups = [flag_group(flags = ["-Wl,-fatal-warnings"])],
),
],
)
user_compile_flags_feature = feature(
name = "user_compile_flags",
enabled = True,
@ -1311,6 +1364,7 @@ def _impl(ctx):
dbg_feature,
opt_feature,
user_compile_flags_feature,
treat_warnings_as_errors_feature,
sysroot_feature,
]

@ -0,0 +1,46 @@
# Copyright 2020 The Bazel Authors. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
# This file is auto-generated by github.com/bazelbuild/bazel-toolchains/pkg/rbeconfigsgen
# and should not be modified directly.
package(default_visibility = ["//visibility:public"])
toolchain(
name = "cc-toolchain",
exec_compatible_with = [
"@platforms//os:windows",
"@platforms//cpu:x86_64",
],
target_compatible_with = [
"@platforms//os:windows",
"@platforms//cpu:x86_64",
],
toolchain = "//third_party/toolchains/rbe_windows_bazel_6.3.2_vs2019/cc:cc-compiler-x64_windows",
toolchain_type = "@bazel_tools//tools/cpp:toolchain_type",
)
platform(
name = "platform",
parents = ["@local_config_platform//:host"],
constraint_values = [
"@platforms//os:windows",
"@platforms//cpu:x86_64",
],
exec_properties = {
"container-image": "docker://gcr.io/grpc-testing/rbe_windows2019@sha256:41772e8eeb9dd8c8b996bf32d58164d84b2315c8e81e634bbff5a0216b7f52fd",
"OSFamily": "Windows",
},
)

@ -29,8 +29,6 @@ call tools/internal_ci/helper_scripts/prepare_build_windows.bat || exit /b 1
@rem Install bazel
@rem Side effect of the tools/bazel script is that it downloads the correct version of bazel binary.
mkdir C:\bazel
@rem This is a workaround to resolve weird linker error from Bazel 6.x
set OVERRIDE_BAZEL_VERSION=5.4.1
bash -c "tools/bazel --version && cp tools/bazel-*.exe /c/bazel/bazel.exe"
set PATH=C:\bazel;%PATH%
bazel --version

@ -16,4 +16,8 @@ build --build_tag_filters=-no_windows
build --jobs=100
# Without this the build is broken on windows RBE with bazel 6.x+
# TODO(jtattermusch): Remove the workaround.
build --dynamic_mode=off
import %workspace%/tools/remote_build/include/test_config_common.bazelrc

Loading…
Cancel
Save