Merge pull request #23992 from yashykt/docimp1

Improve logging message on exceeding metadata size limit
pull/24046/head
Yash Tibrewal 4 years ago committed by GitHub
commit e8bb9ec2af
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 8
      src/core/ext/transport/chttp2/transport/parsing.cc

@ -447,7 +447,8 @@ static grpc_error* GPR_ATTRIBUTE_NOINLINE handle_metadata_size_limit_exceeded(
size_t new_size, size_t metadata_size_limit) { size_t new_size, size_t metadata_size_limit) {
gpr_log(GPR_DEBUG, gpr_log(GPR_DEBUG,
"received initial metadata size exceeds limit (%" PRIuPTR "received initial metadata size exceeds limit (%" PRIuPTR
" vs. %" PRIuPTR ")", " vs. %" PRIuPTR
"). GRPC_ARG_MAX_METADATA_SIZE can be set to increase this limit.",
new_size, metadata_size_limit); new_size, metadata_size_limit);
grpc_chttp2_cancel_stream( grpc_chttp2_cancel_stream(
t, s, t, s,
@ -528,7 +529,10 @@ static grpc_error* on_trailing_header(void* tp, grpc_mdelem md) {
if (new_size > metadata_size_limit) { if (new_size > metadata_size_limit) {
gpr_log(GPR_DEBUG, gpr_log(GPR_DEBUG,
"received trailing metadata size exceeds limit (%" PRIuPTR "received trailing metadata size exceeds limit (%" PRIuPTR
" vs. %" PRIuPTR ")", " vs. %" PRIuPTR
"). Please note that the status is also included in the trailing "
"metadata and a large status message can also trigger this. "
"GRPC_ARG_MAX_METADATA_SIZE can be set to increase this limit.",
new_size, metadata_size_limit); new_size, metadata_size_limit);
grpc_chttp2_cancel_stream( grpc_chttp2_cancel_stream(
t, s, t, s,

Loading…
Cancel
Save