From 779e331a7f9d4a4512245c3476ee93bb3a1b2731 Mon Sep 17 00:00:00 2001 From: Yash Tibrewal Date: Wed, 26 Aug 2020 22:24:25 -0700 Subject: [PATCH] Improve logging message on exceeding metadata size limit --- src/core/ext/transport/chttp2/transport/parsing.cc | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/core/ext/transport/chttp2/transport/parsing.cc b/src/core/ext/transport/chttp2/transport/parsing.cc index 7721b16e91f..7985799696e 100644 --- a/src/core/ext/transport/chttp2/transport/parsing.cc +++ b/src/core/ext/transport/chttp2/transport/parsing.cc @@ -437,7 +437,8 @@ static grpc_error* GPR_ATTRIBUTE_NOINLINE handle_metadata_size_limit_exceeded( size_t new_size, size_t metadata_size_limit) { gpr_log(GPR_DEBUG, "received initial metadata size exceeds limit (%" PRIuPTR - " vs. %" PRIuPTR ")", + " vs. %" PRIuPTR + "). GRPC_ARG_MAX_METADATA_SIZE can be set to increase this limit.", new_size, metadata_size_limit); grpc_chttp2_cancel_stream( t, s, @@ -518,7 +519,10 @@ static grpc_error* on_trailing_header(void* tp, grpc_mdelem md) { if (new_size > metadata_size_limit) { gpr_log(GPR_DEBUG, "received trailing metadata size exceeds limit (%" PRIuPTR - " vs. %" PRIuPTR ")", + " vs. %" PRIuPTR + "). Please note that the status is also included in the trailing " + "metadata and a large status message can also trigger this. " + "GRPC_ARG_MAX_METADATA_SIZE can be set to increase this limit.", new_size, metadata_size_limit); grpc_chttp2_cancel_stream( t, s,