From bccb9c0588b1f8d486fbf139ac4a5e490ae8c8e5 Mon Sep 17 00:00:00 2001 From: Yash Tibrewal Date: Mon, 14 Sep 2020 21:10:01 -0700 Subject: [PATCH] Disable initiating writes on bdp pings till b/168345569 is fixed --- src/core/ext/transport/chttp2/transport/chttp2_transport.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/core/ext/transport/chttp2/transport/chttp2_transport.cc b/src/core/ext/transport/chttp2/transport/chttp2_transport.cc index 8d4ff9a679e..67e0e8505f0 100644 --- a/src/core/ext/transport/chttp2/transport/chttp2_transport.cc +++ b/src/core/ext/transport/chttp2/transport/chttp2_transport.cc @@ -2582,7 +2582,9 @@ void schedule_bdp_ping_locked(grpc_chttp2_transport* t) { grpc_schedule_on_exec_ctx), GRPC_CLOSURE_INIT(&t->finish_bdp_ping_locked, finish_bdp_ping, t, grpc_schedule_on_exec_ctx)); - grpc_chttp2_initiate_write(t, GRPC_CHTTP2_INITIATE_WRITE_BDP_PING); + // TODO(yashykt): Enabling this causes internal b/168345569. Re-enable once + // fixed. + // grpc_chttp2_initiate_write(t, GRPC_CHTTP2_INITIATE_WRITE_BDP_PING); } static void start_bdp_ping(void* tp, grpc_error* error) {