Merge pull request #24152 from yashykt/bdpinitwritedisable

Disable initiating writes on bdp pings till b/168345569 is fixed
5 years ago · e834d0b34b
parent f31a322e1c bccb9c0588
commit e834d0b34b
1 changed files with 3 additions and 1 deletions
--- a/src/core/ext/transport/chttp2/transport/chttp2_transport.cc
+++ b/src/core/ext/transport/chttp2/transport/chttp2_transport.cc
@ -2582,7 +2582,9 @@ void schedule_bdp_ping_locked(grpc_chttp2_transport* t) {
                        grpc_schedule_on_exec_ctx),
      GRPC_CLOSURE_INIT(&t->finish_bdp_ping_locked, finish_bdp_ping, t,
                        grpc_schedule_on_exec_ctx));
-  grpc_chttp2_initiate_write(t, GRPC_CHTTP2_INITIATE_WRITE_BDP_PING);
+  // TODO(yashykt): Enabling this causes internal b/168345569. Re-enable once
+  // fixed.
+  // grpc_chttp2_initiate_write(t, GRPC_CHTTP2_INITIATE_WRITE_BDP_PING);
 }

 static void start_bdp_ping(void* tp, grpc_error* error) {