Remove the check that ensures server completion queues are of type GRPC_CQ_NEXT (because ruby uses GRPC_CQ_PLUCK only)

reviewable/pr9972/r1
Sree Kuchibhotla 8 years ago
parent 189eb4adbe
commit e7e38da237
  1. 9
      src/core/lib/surface/server.c

@ -1003,10 +1003,11 @@ void grpc_server_register_completion_queue(grpc_server *server,
(server, cq, reserved)); (server, cq, reserved));
if (grpc_get_cq_completion_type(cq) != GRPC_CQ_NEXT) { if (grpc_get_cq_completion_type(cq) != GRPC_CQ_NEXT) {
gpr_log( gpr_log(GPR_INFO,
GPR_ERROR, "Completion queue which is not of type GRPC_CQ_NEXT is being "
"Server completion queues must have a completion type of GRPC_CQ_NEXT"); "registered as a server-completion-queue");
abort(); /* Ideally we should log an error and abort but ruby-wrapped-language API
calls grpc_completion_queue_pluck() on server completion queues */
} }
register_completion_queue(server, cq, false, reserved); register_completion_queue(server, cq, false, reserved);

Loading…
Cancel
Save