diff --git a/include/grpcpp/security/server_credentials.h b/include/grpcpp/security/server_credentials.h index 7e4381af487..29afc7d2744 100644 --- a/include/grpcpp/security/server_credentials.h +++ b/include/grpcpp/security/server_credentials.h @@ -55,35 +55,21 @@ struct SslServerCredentialsOptions { grpc_ssl_client_certificate_request_type client_certificate_request; }; -static inline std::shared_ptr SslServerCredentials( - const SslServerCredentialsOptions& options) { - return ::grpc::SslServerCredentials(options); -} +std::shared_ptr SslServerCredentials(const SslServerCredentialsOptions& options); -static inline std::shared_ptr InsecureServerCredentials() { - return ::grpc::InsecureServerCredentials(); -} +std::shared_ptr InsecureServerCredentials(); namespace experimental { typedef ::grpc_impl::experimental::AltsServerCredentialsOptions AltsServerCredentialsOptions; -static inline std::shared_ptr AltsServerCredentials( - const AltsServerCredentialsOptions& options) { - return ::grpc::experimental::AltsServerCredentials(options); -} +std::shared_ptr AltsServerCredentials(const AltsServerCredentialsOptions& options); -static inline std::shared_ptr LocalServerCredentials( - grpc_local_connect_type type) { - return ::grpc::experimental::LocalServerCredentials(type); -} +std::shared_ptr LocalServerCredentials(grpc_local_connect_type type); /// Builds TLS ServerCredentials given TLS options. -static inline std::shared_ptr TlsServerCredentials( - const ::grpc::experimental::TlsCredentialsOptions& options) { - return ::grpc::experimental::TlsServerCredentials(options); -} +std::shared_ptr TlsServerCredentials(const ::grpc::experimental::TlsCredentialsOptions& options); } // namespace experimental } // namespace grpc diff --git a/src/cpp/server/insecure_server_credentials.cc b/src/cpp/server/insecure_server_credentials.cc index bc908920b8d..04e5435efb9 100644 --- a/src/cpp/server/insecure_server_credentials.cc +++ b/src/cpp/server/insecure_server_credentials.cc @@ -21,7 +21,7 @@ #include #include -namespace grpc_impl { +namespace grpc { namespace { class InsecureServerCredentialsImpl final : public ServerCredentials { public: @@ -41,4 +41,4 @@ std::shared_ptr InsecureServerCredentials() { new InsecureServerCredentialsImpl()); } -} // namespace grpc_impl +} // namespace grpc diff --git a/src/cpp/server/secure_server_credentials.cc b/src/cpp/server/secure_server_credentials.cc index a7eb7a1505c..48fb3ad9f34 100644 --- a/src/cpp/server/secure_server_credentials.cc +++ b/src/cpp/server/secure_server_credentials.cc @@ -94,7 +94,7 @@ void AuthMetadataProcessorAyncWrapper::InvokeProcessor( } // namespace grpc -namespace grpc_impl { +namespace grpc { int SecureServerCredentials::AddPortToServer(const std::string& addr, grpc_server* server) { @@ -156,4 +156,4 @@ std::shared_ptr TlsServerCredentials( } } // namespace experimental -} // namespace grpc_impl +} // namespace grpc diff --git a/src/cpp/server/secure_server_credentials.h b/src/cpp/server/secure_server_credentials.h index 9e9e33579f0..407d70766b5 100644 --- a/src/cpp/server/secure_server_credentials.h +++ b/src/cpp/server/secure_server_credentials.h @@ -28,14 +28,9 @@ #include "src/cpp/server/thread_pool_interface.h" -namespace grpc_impl { - -class SecureServerCredentials; -} // namespace grpc_impl - namespace grpc { -typedef ::grpc_impl::SecureServerCredentials SecureServerCredentials; +class SecureServerCredentials; class AuthMetadataProcessorAyncWrapper final { public: @@ -61,10 +56,6 @@ class AuthMetadataProcessorAyncWrapper final { std::shared_ptr processor_; }; -} // namespace grpc - -namespace grpc_impl { - class SecureServerCredentials final : public ServerCredentials { public: explicit SecureServerCredentials(grpc_server_credentials* creds) @@ -83,6 +74,6 @@ class SecureServerCredentials final : public ServerCredentials { std::unique_ptr processor_; }; -} // namespace grpc_impl +} // namespace grpc #endif // GRPC_INTERNAL_CPP_SERVER_SECURE_SERVER_CREDENTIALS_H