From e65a79a0801d33bbfe7b211ee33b42b04876b817 Mon Sep 17 00:00:00 2001 From: AJ Heller Date: Thu, 4 Aug 2022 14:50:37 -0700 Subject: [PATCH] Fix missing destructors on JSON Object Loader (#30503) This was causing failures with `-Wnon-virtual-dtor` in the feature example tests. --- src/core/lib/json/json_object_loader.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/core/lib/json/json_object_loader.h b/src/core/lib/json/json_object_loader.h index 89af25dad48..2fbec033136 100644 --- a/src/core/lib/json/json_object_loader.h +++ b/src/core/lib/json/json_object_loader.h @@ -235,6 +235,9 @@ class LoadBool : public LoaderInterface { public: void LoadInto(const Json& json, const JsonArgs& /*args*/, void* dst, ErrorList* errors) const override; + + protected: + ~LoadBool() = default; }; // Loads an unprocessed JSON object value. @@ -242,6 +245,9 @@ class LoadUnprocessedJsonObject : public LoaderInterface { public: void LoadInto(const Json& json, const JsonArgs& /*args*/, void* dst, ErrorList* errors) const override; + + protected: + ~LoadUnprocessedJsonObject() = default; }; // Load a vector of some type.