From e0059af33b69806cb35e2cf125e301d500095b50 Mon Sep 17 00:00:00 2001 From: Nicolas Noble Date: Wed, 6 Mar 2019 16:44:37 -0800 Subject: [PATCH 1/4] Adding a few potential breaking changes --- doc/core/pending_api_cleanups.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/doc/core/pending_api_cleanups.md b/doc/core/pending_api_cleanups.md index 67d587deadc..f330240cadf 100644 --- a/doc/core/pending_api_cleanups.md +++ b/doc/core/pending_api_cleanups.md @@ -15,3 +15,7 @@ number: `include/grpc/impl/codegen/grpc_types.h` (commit `af00d8b`) (cannot be done until after next grpc release, so that TensorFlow can use the same code both internally and externally) +- get rid of all of the grpc++ headers that are currently deprecated + in favor of their grpcpp counterpart due to iOS' parsing issue on the + + sign. +- require a C++ runtime for all languages. From 0a36746ebe1dafd58b44620294ca571d592c3b06 Mon Sep 17 00:00:00 2001 From: Nicolas Noble Date: Wed, 6 Mar 2019 16:45:25 -0800 Subject: [PATCH 2/4] Changing + to plus. --- doc/core/pending_api_cleanups.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/core/pending_api_cleanups.md b/doc/core/pending_api_cleanups.md index f330240cadf..eb44659c9e0 100644 --- a/doc/core/pending_api_cleanups.md +++ b/doc/core/pending_api_cleanups.md @@ -17,5 +17,5 @@ number: use the same code both internally and externally) - get rid of all of the grpc++ headers that are currently deprecated in favor of their grpcpp counterpart due to iOS' parsing issue on the - + sign. + plus sign. - require a C++ runtime for all languages. From fc56889a5cef2f43df22748a813cc5ed91df91f6 Mon Sep 17 00:00:00 2001 From: Nicolas Noble Date: Wed, 6 Mar 2019 16:47:30 -0800 Subject: [PATCH 3/4] Removing the change about headers, since it's the wrong file. --- doc/core/pending_api_cleanups.md | 3 --- 1 file changed, 3 deletions(-) diff --git a/doc/core/pending_api_cleanups.md b/doc/core/pending_api_cleanups.md index eb44659c9e0..5a8270349a4 100644 --- a/doc/core/pending_api_cleanups.md +++ b/doc/core/pending_api_cleanups.md @@ -15,7 +15,4 @@ number: `include/grpc/impl/codegen/grpc_types.h` (commit `af00d8b`) (cannot be done until after next grpc release, so that TensorFlow can use the same code both internally and externally) -- get rid of all of the grpc++ headers that are currently deprecated - in favor of their grpcpp counterpart due to iOS' parsing issue on the - plus sign. - require a C++ runtime for all languages. From 7dbe321d767f2a28991ed1c57650620d5b1b4afa Mon Sep 17 00:00:00 2001 From: Nicolas Noble Date: Thu, 14 Mar 2019 10:54:02 -0700 Subject: [PATCH 4/4] Update pending_api_cleanups.md --- doc/core/pending_api_cleanups.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/core/pending_api_cleanups.md b/doc/core/pending_api_cleanups.md index 5a8270349a4..970bcd08300 100644 --- a/doc/core/pending_api_cleanups.md +++ b/doc/core/pending_api_cleanups.md @@ -15,4 +15,4 @@ number: `include/grpc/impl/codegen/grpc_types.h` (commit `af00d8b`) (cannot be done until after next grpc release, so that TensorFlow can use the same code both internally and externally) -- require a C++ runtime for all languages. +- require a C++ runtime for all languages wrapping core.