mirror of https://github.com/grpc/grpc.git
Fix a RexAnalyzer error during the import, and update in github as well. Parentheses around a single item in Python has no effect: (foo) is exactly equivalent to foo. In many cases this is harmless, but it can suggest a subtle bug when used in string formatting. A '%'-formatted string with a single format specifier can be formatted using a single value or a one element tuple: 'hello %s' % name or 'hello %s' % (name,). Consequently, a line like error_msg = 'Cannot process %s' % (data) may leave code reviewers and future readers unsure if there is a subtle bug if data is a tuple. Since the args.repo_owner here is a single string, drop the parentheses is better.pull/23738/head
parent
e4e7d48d99
commit
e4ead4bec0
1 changed files with 1 additions and 1 deletions
Loading…
Reference in new issue