Merge pull request #24483 from veblush/tidy-readability-redundant-control-flow

[Clang-Tidy] Enable readability-redundant-control-flow
pull/24516/head
Esun Kim 4 years ago committed by GitHub
commit e37dab3b7f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      .clang-tidy
  2. 4
      src/core/lib/compression/stream_compression_identity.cc
  3. 2
      src/core/lib/surface/call.cc
  4. 1
      test/cpp/naming/resolver_component_tests_runner_invoker.cc
  5. 2
      test/cpp/qps/client_callback.cc

@ -35,7 +35,7 @@ Checks: '-*,
readability-deleted-default,
readability-function-size,
-readability-inconsistent-declaration-parameter-name,
-readability-redundant-control-flow,
readability-redundant-control-flow,
readability-redundant-smartptr-get,
-readability-string-compare'
WarningsAsErrors: '*'

@ -82,9 +82,7 @@ grpc_stream_compression_context_create_identity(
}
static void grpc_stream_compression_context_destroy_identity(
grpc_stream_compression_context* /*ctx*/) {
return;
}
grpc_stream_compression_context* /*ctx*/) {}
const grpc_stream_compression_vtable grpc_stream_compression_identity_vtable = {
grpc_stream_compress_identity, grpc_stream_decompress_identity,

@ -811,7 +811,7 @@ uint32_t grpc_call_test_only_get_message_flags(grpc_call* call) {
return flags;
}
static void destroy_encodings_accepted_by_peer(void* /*p*/) { return; }
static void destroy_encodings_accepted_by_peer(void* /*p*/) {}
static void set_encodings_accepted_by_peer(grpc_call* /*call*/,
grpc_mdelem mdel,

@ -95,7 +95,6 @@ void RunSigHandlingThread(SubProcess* test_driver, gpr_mu* test_driver_mu,
"Test timeout reached or received signal. Interrupting test driver "
"child process.");
test_driver->Interrupt();
return;
}
} // namespace

@ -164,7 +164,7 @@ class CallbackUnaryClient final : public CallbackClient {
return true;
}
void InitThreadFuncImpl(size_t /*thread_idx*/) override { return; }
void InitThreadFuncImpl(size_t /*thread_idx*/) override {}
private:
void ScheduleRpc(Thread* t, size_t vector_idx) {

Loading…
Cancel
Save