From e25637ebea51e4b5fd7ac939438cd49a59c61bee Mon Sep 17 00:00:00 2001 From: AJ Heller Date: Fri, 16 Apr 2021 18:22:22 -0700 Subject: [PATCH] Fix EventEngine factory method return types: unique_ptr for lifetime management (#25971) --- include/grpc/event_engine/event_engine.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/include/grpc/event_engine/event_engine.h b/include/grpc/event_engine/event_engine.h index 9044e1b5ba1..2bdefa78730 100644 --- a/include/grpc/event_engine/event_engine.h +++ b/include/grpc/event_engine/event_engine.h @@ -166,14 +166,13 @@ class EventEngine { /// been called. virtual absl::Status Bind(const ResolvedAddress& addr) = 0; virtual absl::Status Start() = 0; - virtual absl::Status Shutdown() = 0; }; // TODO(hork): define status codes for the callback // TODO(hork): define return status codes // TODO(hork): document status arg meanings for on_accept and on_shutdown /// Factory method to create a network listener. - virtual absl::StatusOr CreateListener( + virtual absl::StatusOr> CreateListener( Listener::AcceptCallback on_accept, Callback on_shutdown, const ChannelArgs& args, SliceAllocatorFactory slice_allocator_factory) = 0; @@ -236,7 +235,7 @@ class EventEngine { // TODO(hork): define return status codes /// Retrieves an instance of a DNSResolver. - virtual absl::StatusOr GetDNSResolver() = 0; + virtual absl::StatusOr> GetDNSResolver() = 0; /// Intended for future expansion of Task run functionality. struct RunOptions {};