[end2end] Fix simple delayed request (#33450)

omgwtfbbq

This test relies on WAIT_FOR_READY semantics, but we don't do that in
the proxy, so it got assigned the wrong suite.
Fix the suite, fix the flakes.

Also add some handy dandy logging to help figure this stuff out in the
future.
pull/33457/head
Craig Tiller 2 years ago committed by GitHub
parent 6c6faa9cab
commit e0ad9e5746
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      test/core/end2end/BUILD
  2. 14
      test/core/end2end/tests/simple_delayed_request.cc

@ -430,7 +430,7 @@ grpc_core_end2end_test(name = "shutdown_finishes_tags")
grpc_core_end2end_test(
name = "simple_delayed_request",
shard_count = 50,
shard_count = 3,
)
grpc_core_end2end_test(name = "simple_metadata")

@ -16,34 +16,46 @@
//
//
#include "absl/strings/str_cat.h"
#include "gtest/gtest.h"
#include <grpc/grpc.h>
#include <grpc/status.h>
#include <grpc/support/log.h>
#include "src/core/lib/channel/channel_args.h"
#include "src/core/lib/gprpp/crash.h"
#include "src/core/lib/gprpp/time.h"
#include "test/core/end2end/end2end_tests.h"
namespace grpc_core {
namespace {
CORE_END2END_TEST(CoreClientChannelTest, SimpleDelayedRequestShort) {
CORE_END2END_TEST(Http2SingleHopTest, SimpleDelayedRequestShort) {
InitClient(ChannelArgs()
.Set(GRPC_ARG_INITIAL_RECONNECT_BACKOFF_MS, 1000)
.Set(GRPC_ARG_MAX_RECONNECT_BACKOFF_MS, 1000)
.Set(GRPC_ARG_MIN_RECONNECT_BACKOFF_MS, 5000));
gpr_log(GPR_ERROR, "Create client side call");
auto c = NewClientCall("/foo").Timeout(Duration::Seconds(5)).Create();
IncomingMetadata server_initial_metadata;
IncomingStatusOnClient server_status;
gpr_log(GPR_ERROR, "Start initial batch");
c.NewBatch(1)
.SendInitialMetadata({}, GRPC_INITIAL_METADATA_WAIT_FOR_READY)
.SendCloseFromClient()
.RecvInitialMetadata(server_initial_metadata)
.RecvStatusOnClient(server_status);
gpr_log(GPR_ERROR, "Start server");
InitServer(ChannelArgs());
auto s = RequestCall(101);
Expect(101, true);
Expect(1, CoreEnd2endTest::MaybePerformAction{[&](bool success) {
Crash(absl::StrCat(
"Unexpected completion of client side call: success=",
success ? "true" : "false", " status=", server_status.ToString(),
" initial_md=", server_initial_metadata.ToString()));
}});
Step();
IncomingCloseOnServer client_close;
s.NewBatch(102)

Loading…
Cancel
Save