From e033b0390d889e2fd11aac91245e5d8381004a30 Mon Sep 17 00:00:00 2001 From: Esun Kim Date: Wed, 16 Oct 2024 08:58:58 -0700 Subject: [PATCH] [CI] Disallowed std::string_view (#37930) `std::string_view` is not allowed to use per Google C++ style guide. This test will prevent us from accidentally using it after C++17 upgrade. Closes #37930 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37930 from veblush:string-view 88f56c12ba31d006f3168b6bea39784c36f6a47a PiperOrigin-RevId: 686526151 --- tools/run_tests/sanity/cpp_banned_constructs.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/run_tests/sanity/cpp_banned_constructs.sh b/tools/run_tests/sanity/cpp_banned_constructs.sh index 2318fd95b71..b0535b18244 100755 --- a/tools/run_tests/sanity/cpp_banned_constructs.sh +++ b/tools/run_tests/sanity/cpp_banned_constructs.sh @@ -24,7 +24,7 @@ cd "$(dirname "$0")/../../.." # grep -EIrn \ - 'std::(mutex|condition_variable|lock_guard|unique_lock|thread)' \ + '\bstd::(mutex|condition_variable|lock_guard|unique_lock|thread|string_view)' \ include/grpc include/grpcpp src/core src/cpp | \ grep -Ev 'include/grpcpp/impl/sync.h|src/core/util/work_serializer.cc' | \ diff - /dev/null