Merge remote-tracking branch 'upstream/master' into ssl_fuzzer

pull/8642/head
yang-g 8 years ago
commit df13cd1cdb
  1. 8
      src/php/lib/Grpc/AbstractCall.php
  2. 2
      src/php/lib/Grpc/BaseStub.php
  3. 8
      src/php/tests/interop/interop_client.php
  4. 2
      src/php/tests/unit_tests/CallTest.php

@ -35,7 +35,7 @@
namespace Grpc; namespace Grpc;
/** /**
* Class AbstractCall * Class AbstractCall.
* @package Grpc * @package Grpc
*/ */
abstract class AbstractCall abstract class AbstractCall
@ -121,13 +121,14 @@ abstract class AbstractCall
} }
/** /**
* Serialize a message to the protobuf binary format * Serialize a message to the protobuf binary format.
* *
* @param mixed $data The Protobuf message * @param mixed $data The Protobuf message
* *
* @return string The protobuf binary format * @return string The protobuf binary format
*/ */
protected function serializeMessage($data) { protected function serializeMessage($data)
{
// Proto3 implementation // Proto3 implementation
if (method_exists($data, 'encode')) { if (method_exists($data, 'encode')) {
return $data->encode(); return $data->encode();
@ -155,6 +156,7 @@ abstract class AbstractCall
list($className, $deserializeFunc) = $this->deserialize; list($className, $deserializeFunc) = $this->deserialize;
$obj = new $className(); $obj = new $className();
$obj->$deserializeFunc($value); $obj->$deserializeFunc($value);
return $obj; return $obj;
} }

@ -252,7 +252,7 @@ class BaseStub
* *
* @param string $method The name of the method to call * @param string $method The name of the method to call
* @param array $arguments An array or Traversable of arguments to stream to the * @param array $arguments An array or Traversable of arguments to stream to the
* server * server
* @param callable $deserialize A function that deserializes the response * @param callable $deserialize A function that deserializes the response
* @param array $metadata A metadata map to send to the server * @param array $metadata A metadata map to send to the server
* *

@ -477,10 +477,10 @@ function statusCodeAndMessage($stub)
list($result, $status) = $call->wait(); list($result, $status) = $call->wait();
hardAssert($status->code === 2, hardAssert($status->code === 2,
'Received unexpected UnaryCall status code: ' . 'Received unexpected UnaryCall status code: '.
$status->code); $status->code);
hardAssert($status->details === 'test status message', hardAssert($status->details === 'test status message',
'Received unexpected UnaryCall status details: ' . 'Received unexpected UnaryCall status details: '.
$status->details); $status->details);
$streaming_call = $stub->FullDuplexCall(); $streaming_call = $stub->FullDuplexCall();
@ -493,10 +493,10 @@ function statusCodeAndMessage($stub)
$status = $streaming_call->getStatus(); $status = $streaming_call->getStatus();
hardAssert($status->code === 2, hardAssert($status->code === 2,
'Received unexpected FullDuplexCall status code: ' . 'Received unexpected FullDuplexCall status code: '.
$status->code); $status->code);
hardAssert($status->details === 'test status message', hardAssert($status->details === 'test status message',
'Received unexpected FullDuplexCall status details: ' . 'Received unexpected FullDuplexCall status details: '.
$status->details); $status->details);
} }

@ -94,7 +94,7 @@ class CallTest extends PHPUnit_Framework_TestCase
$batch = [ $batch = [
Grpc\OP_SEND_INITIAL_METADATA => ['key1' => ['value1'], Grpc\OP_SEND_INITIAL_METADATA => ['key1' => ['value1'],
'key2' => ['value2', 'key2' => ['value2',
'value3'], ], 'value3', ], ],
]; ];
$result = $this->call->startBatch($batch); $result = $this->call->startBatch($batch);
$this->assertTrue($result->send_metadata); $this->assertTrue($result->send_metadata);

Loading…
Cancel
Save