Fix clang-tidy concerns

pull/16655/head
Vijay Pai 6 years ago
parent d177c8fe46
commit deb3126611
  1. 4
      src/cpp/common/callback_common.cc
  2. 2
      test/cpp/end2end/client_callback_end2end_test.cc

@ -66,8 +66,8 @@ class CallbackWithSuccessImpl : public grpc_core::CQCallbackInterface {
GPR_ASSERT(parent_->ops()->FinalizeResult(&ignored, &new_ok));
GPR_ASSERT(ignored == parent_->ops());
// Last use of func_ or ok, so ok to move them out for rvalue call above
CatchingCallback(std::move(func_), std::move(ok));
// Last use of func_, so ok to move it out for rvalue call above
CatchingCallback(std::move(func_), ok);
func_ = nullptr; // reset to clear this out for sure
grpc_call_unref(call_);

@ -95,6 +95,8 @@ class ClientCallbackEnd2endTest : public ::testing::Test {
if (maybe_except) {
throw - 1;
}
#else
GPR_ASSERT(!maybe_except);
#endif
});
std::unique_lock<std::mutex> l(mu);

Loading…
Cancel
Save