Merge pull request #24659 from veblush/fix-stacktrace-test

Disable stack-trace tests in Release
4 years ago · da53ff02c7
parent d39e7133c5 b85e2ebc8f
commit da53ff02c7
2 changed files with 4 additions and 0 deletions
--- a/test/core/gprpp/examine_stack_test.cc
+++ b/test/core/gprpp/examine_stack_test.cc
@ -71,7 +71,9 @@ TEST(ExamineStackTest, AbseilStackProvider) {
      grpc_core::GetCurrentStackTrace();
  EXPECT_NE(stack_trace, absl::nullopt);
  gpr_log(GPR_INFO, "stack_trace=%s", stack_trace->c_str());
+#ifndef NDEBUG
  EXPECT_TRUE(stack_trace->find("GetCurrentStackTrace") != -1);
+#endif
 }

 int main(int argc, char** argv) {
--- a/test/core/util/stack_tracer_test.cc
+++ b/test/core/util/stack_tracer_test.cc
@ -30,7 +30,9 @@
 TEST(StackTracerTest, Basic) {
  std::string stack_trace = grpc_core::testing::GetCurrentStackTrace();
  gpr_log(GPR_INFO, "stack_trace=%s", stack_trace.c_str());
+#ifndef NDEBUG
  EXPECT_TRUE(stack_trace.find("Basic") != -1);
+#endif
 }

 int main(int argc, char** argv) {