From 57cc401597f9464809ee9d9402bd448aa1e0aecc Mon Sep 17 00:00:00 2001 From: weiyongji <232589621@qq.com> Date: Sat, 25 May 2019 11:20:08 +0800 Subject: [PATCH 1/3] typo fix --- src/cpp/thread_manager/thread_manager.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cpp/thread_manager/thread_manager.h b/src/cpp/thread_manager/thread_manager.h index 2fbf309d421..62b1beebc37 100644 --- a/src/cpp/thread_manager/thread_manager.h +++ b/src/cpp/thread_manager/thread_manager.h @@ -56,7 +56,7 @@ class ThreadManager { // DoWork() // // If the return value is SHUTDOWN:, - // - ThreadManager WILL NOT call DoWork() and terminates the thead + // - ThreadManager WILL NOT call DoWork() and terminates the thread // // If the return value is TIMEOUT:, // - ThreadManager WILL NOT call DoWork() @@ -133,7 +133,7 @@ class ThreadManager { grpc_core::Thread thd_; }; - // The main funtion in ThreadManager + // The main function in ThreadManager void MainWorkLoop(); void MarkAsCompleted(WorkerThread* thd); From a2f7ce699be7678ff72870c6a164317762b1b30d Mon Sep 17 00:00:00 2001 From: weiyongji <232589621@qq.com> Date: Sat, 25 May 2019 15:07:24 +0800 Subject: [PATCH 2/3] call destroy function in test_serial() --- test/core/gpr/mpscq_test.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/test/core/gpr/mpscq_test.cc b/test/core/gpr/mpscq_test.cc index 744cea934c5..552fe8d9687 100644 --- a/test/core/gpr/mpscq_test.cc +++ b/test/core/gpr/mpscq_test.cc @@ -55,6 +55,7 @@ static void test_serial(void) { GPR_ASSERT(n->i == i); gpr_free(n); } + gpr_mpscq_destroy(&q); } typedef struct { From bd0d6fc7b6b7499f3385a92c42e853a8d55ce16e Mon Sep 17 00:00:00 2001 From: weiyongji <232589621@qq.com> Date: Sat, 25 May 2019 15:46:28 +0800 Subject: [PATCH 3/3] cancel the modification in mpscq_test.cc --- test/core/gpr/mpscq_test.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/test/core/gpr/mpscq_test.cc b/test/core/gpr/mpscq_test.cc index 552fe8d9687..744cea934c5 100644 --- a/test/core/gpr/mpscq_test.cc +++ b/test/core/gpr/mpscq_test.cc @@ -55,7 +55,6 @@ static void test_serial(void) { GPR_ASSERT(n->i == i); gpr_free(n); } - gpr_mpscq_destroy(&q); } typedef struct {