Merge pull request #23463 from markdroth/xds_experimental

Remove xds-experimental URI scheme.
pull/23473/head
Mark D. Roth 5 years ago committed by GitHub
commit d73bf4a43d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 16
      src/core/ext/filters/client_channel/resolver/xds/xds_resolver.cc

@ -144,8 +144,6 @@ void XdsResolver::StartLocked() {
class XdsResolverFactory : public ResolverFactory { class XdsResolverFactory : public ResolverFactory {
public: public:
explicit XdsResolverFactory(const char* scheme) : scheme_(scheme) {}
bool IsValidUri(const grpc_uri* uri) const override { bool IsValidUri(const grpc_uri* uri) const override {
if (GPR_UNLIKELY(0 != strcmp(uri->authority, ""))) { if (GPR_UNLIKELY(0 != strcmp(uri->authority, ""))) {
gpr_log(GPR_ERROR, "URI authority not supported"); gpr_log(GPR_ERROR, "URI authority not supported");
@ -159,26 +157,16 @@ class XdsResolverFactory : public ResolverFactory {
return MakeOrphanable<XdsResolver>(std::move(args)); return MakeOrphanable<XdsResolver>(std::move(args));
} }
const char* scheme() const override { return scheme_; } const char* scheme() const override { return "xds"; }
private:
const char* scheme_;
}; };
constexpr char kXdsScheme[] = "xds";
constexpr char kXdsExperimentalScheme[] = "xds-experimental";
} // namespace } // namespace
} // namespace grpc_core } // namespace grpc_core
void grpc_resolver_xds_init() { void grpc_resolver_xds_init() {
grpc_core::ResolverRegistry::Builder::RegisterResolverFactory( grpc_core::ResolverRegistry::Builder::RegisterResolverFactory(
absl::make_unique<grpc_core::XdsResolverFactory>(grpc_core::kXdsScheme)); absl::make_unique<grpc_core::XdsResolverFactory>());
// TODO(roth): Remov this in the 1.31 release.
grpc_core::ResolverRegistry::Builder::RegisterResolverFactory(
absl::make_unique<grpc_core::XdsResolverFactory>(
grpc_core::kXdsExperimentalScheme));
} }
void grpc_resolver_xds_shutdown() {} void grpc_resolver_xds_shutdown() {}

Loading…
Cancel
Save