From d6f245cf6909c718ada49df1491ffedf31480b3c Mon Sep 17 00:00:00 2001 From: Eugene Ostroukhov Date: Tue, 7 May 2024 16:25:59 -0700 Subject: [PATCH] fixup: Code review comments --- .../event_engine/thread_pool/work_stealing_thread_pool.cc | 8 +------- .../event_engine/thread_pool/work_stealing_thread_pool.h | 1 - 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/src/core/lib/event_engine/thread_pool/work_stealing_thread_pool.cc b/src/core/lib/event_engine/thread_pool/work_stealing_thread_pool.cc index 5cfc0fa5103..eeaed8abb3c 100644 --- a/src/core/lib/event_engine/thread_pool/work_stealing_thread_pool.cc +++ b/src/core/lib/event_engine/thread_pool/work_stealing_thread_pool.cc @@ -229,12 +229,6 @@ WorkStealingThreadPool::WorkStealingThreadPoolImpl::WorkStealingThreadPoolImpl( size_t reserve_threads) : reserve_threads_(reserve_threads), queue_(this) {} -WorkStealingThreadPool::WorkStealingThreadPoolImpl:: - ~WorkStealingThreadPoolImpl() { - grpc_core::MutexLock lock(&lifeguard_ptr_mu_); - lifeguard_.reset(); -} - void WorkStealingThreadPool::WorkStealingThreadPoolImpl::Start() { for (size_t i = 0; i < reserve_threads_; i++) { StartThread(); @@ -245,7 +239,7 @@ void WorkStealingThreadPool::WorkStealingThreadPoolImpl::Start() { void WorkStealingThreadPool::WorkStealingThreadPoolImpl::Run( EventEngine::Closure* closure) { - DCHECK(!IsQuiesced()); + CHECK(!IsQuiesced()); if (g_local_queue != nullptr && g_local_queue->owner() == this) { g_local_queue->Add(closure); } else { diff --git a/src/core/lib/event_engine/thread_pool/work_stealing_thread_pool.h b/src/core/lib/event_engine/thread_pool/work_stealing_thread_pool.h index 72efad4e328..7543db92900 100644 --- a/src/core/lib/event_engine/thread_pool/work_stealing_thread_pool.h +++ b/src/core/lib/event_engine/thread_pool/work_stealing_thread_pool.h @@ -105,7 +105,6 @@ class WorkStealingThreadPool final : public ThreadPool { : public std::enable_shared_from_this { public: explicit WorkStealingThreadPoolImpl(size_t reserve_threads); - ~WorkStealingThreadPoolImpl(); // Start all threads. void Start(); // Add a closure to a work queue, preferably a thread-local queue if