From d63dcc188bcdc3baf54a7da930efdea2b0f73dd6 Mon Sep 17 00:00:00 2001 From: Tanvi Jagtap <139093547+tanvi-jagtap@users.noreply.github.com> Date: Fri, 7 Jun 2024 10:10:22 -0700 Subject: [PATCH] [Gpr_To_Absl_Logging] Adding comment (#36846) [Gpr_To_Absl_Logging] Adding comment Closes #36846 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36846 from tanvi-jagtap:add_comment_no_logging 4a584d0d1da7b0e0f96c22ca5f0185fcb0dc325f PiperOrigin-RevId: 641284644 --- test/core/end2end/tests/no_logging.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/core/end2end/tests/no_logging.cc b/test/core/end2end/tests/no_logging.cc index 4235b02a759..52a11825d14 100644 --- a/test/core/end2end/tests/no_logging.cc +++ b/test/core/end2end/tests/no_logging.cc @@ -140,6 +140,9 @@ void SimpleRequest(CoreEnd2endTest& test) { } CORE_END2END_TEST(NoLoggingTest, NoLoggingTest) { +// This test makes sure that we dont get spammy logs when making an rpc +// especially when rpcs are successful. + // TODO(hork): remove when the listener flake is identified #ifdef GPR_WINDOWS if (IsEventEngineListenerEnabled()) {