Merge pull request #22819 from veblush/time-convert-flag

Remove flaky flag from ChannelzChannelTest::LastCallStartedTime
reviewable/pr22983/r1
Esun Kim 5 years ago committed by GitHub
commit d2fbaf7f46
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      Makefile
  2. 1
      build_autogenerated.yaml
  3. 1
      test/core/channel/BUILD
  4. 24
      tools/run_tests/generated/tests.json

@ -2196,6 +2196,8 @@ test_cxx: buildtests_cxx
$(Q) $(BINDIR)/$(CONFIG)/channelz_registry_test || ( echo test channelz_registry_test failed ; exit 1 ) $(Q) $(BINDIR)/$(CONFIG)/channelz_registry_test || ( echo test channelz_registry_test failed ; exit 1 )
$(E) "[RUN] Testing channelz_service_test" $(E) "[RUN] Testing channelz_service_test"
$(Q) $(BINDIR)/$(CONFIG)/channelz_service_test || ( echo test channelz_service_test failed ; exit 1 ) $(Q) $(BINDIR)/$(CONFIG)/channelz_service_test || ( echo test channelz_service_test failed ; exit 1 )
$(E) "[RUN] Testing channelz_test"
$(Q) $(BINDIR)/$(CONFIG)/channelz_test || ( echo test channelz_test failed ; exit 1 )
$(E) "[RUN] Testing cli_call_test" $(E) "[RUN] Testing cli_call_test"
$(Q) $(BINDIR)/$(CONFIG)/cli_call_test || ( echo test cli_call_test failed ; exit 1 ) $(Q) $(BINDIR)/$(CONFIG)/cli_call_test || ( echo test cli_call_test failed ; exit 1 )
$(E) "[RUN] Testing client_callback_end2end_test" $(E) "[RUN] Testing client_callback_end2end_test"

@ -5466,7 +5466,6 @@ targets:
- name: channelz_test - name: channelz_test
gtest: true gtest: true
build: test build: test
run: false
language: c++ language: c++
headers: headers:
- test/cpp/util/channel_trace_proto_helper.h - test/cpp/util/channel_trace_proto_helper.h

@ -87,7 +87,6 @@ grpc_cc_test(
external_deps = [ external_deps = [
"gtest", "gtest",
], ],
flaky = True, # TODO(b/151792070)
language = "C++", language = "C++",
deps = [ deps = [
"//:gpr", "//:gpr",

@ -4049,6 +4049,30 @@
], ],
"uses_polling": true "uses_polling": true
}, },
{
"args": [],
"benchmark": false,
"ci_platforms": [
"linux",
"mac",
"posix",
"windows"
],
"cpu_cost": 1.0,
"exclude_configs": [],
"exclude_iomgrs": [],
"flaky": false,
"gtest": true,
"language": "c++",
"name": "channelz_test",
"platforms": [
"linux",
"mac",
"posix",
"windows"
],
"uses_polling": true
},
{ {
"args": [], "args": [],
"benchmark": false, "benchmark": false,

Loading…
Cancel
Save