Merge pull request #20645 from vjpai/remove_warn_16

Remove unused parameter warnings (16 of 20)
reviewable/pr18856/r16
Vijay Pai 5 years ago committed by GitHub
commit d29d0d71e4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      test/cpp/end2end/message_allocator_end2end_test.cc
  2. 8
      test/cpp/end2end/mock_test.cc
  3. 2
      test/cpp/end2end/port_sharing_end2end_test.cc
  4. 6
      test/cpp/end2end/server_builder_plugin_test.cc
  5. 5
      test/cpp/end2end/server_crash_test.cc
  6. 4
      test/cpp/end2end/server_interceptors_end2end_test.cc
  7. 4
      test/cpp/end2end/shutdown_test.cc
  8. 2
      test/cpp/end2end/streaming_throughput_test.cc
  9. 2
      test/cpp/end2end/thread_stress_test.cc
  10. 2
      test/cpp/end2end/xds_end2end_test.cc

@ -70,7 +70,7 @@ class CallbackTestServiceImpl
allocator_mutator_ = mutator; allocator_mutator_ = mutator;
} }
void Echo(ServerContext* context, const EchoRequest* request, void Echo(ServerContext* /*context*/, const EchoRequest* request,
EchoResponse* response, EchoResponse* response,
experimental::ServerCallbackRpcController* controller) override { experimental::ServerCallbackRpcController* controller) override {
response->set_message(request->message()); response->set_message(request->message());

@ -163,13 +163,13 @@ class FakeClient {
class TestServiceImpl : public EchoTestService::Service { class TestServiceImpl : public EchoTestService::Service {
public: public:
Status Echo(ServerContext* context, const EchoRequest* request, Status Echo(ServerContext* /*context*/, const EchoRequest* request,
EchoResponse* response) override { EchoResponse* response) override {
response->set_message(request->message()); response->set_message(request->message());
return Status::OK; return Status::OK;
} }
Status RequestStream(ServerContext* context, Status RequestStream(ServerContext* /*context*/,
ServerReader<EchoRequest>* reader, ServerReader<EchoRequest>* reader,
EchoResponse* response) override { EchoResponse* response) override {
EchoRequest request; EchoRequest request;
@ -182,7 +182,7 @@ class TestServiceImpl : public EchoTestService::Service {
return Status::OK; return Status::OK;
} }
Status ResponseStream(ServerContext* context, const EchoRequest* request, Status ResponseStream(ServerContext* /*context*/, const EchoRequest* request,
ServerWriter<EchoResponse>* writer) override { ServerWriter<EchoResponse>* writer) override {
EchoResponse response; EchoResponse response;
vector<grpc::string> tokens = split(request->message()); vector<grpc::string> tokens = split(request->message());
@ -194,7 +194,7 @@ class TestServiceImpl : public EchoTestService::Service {
} }
Status BidiStream( Status BidiStream(
ServerContext* context, ServerContext* /*context*/,
ServerReaderWriter<EchoResponse, EchoRequest>* stream) override { ServerReaderWriter<EchoResponse, EchoRequest>* stream) override {
EchoRequest request; EchoRequest request;
EchoResponse response; EchoResponse response;

@ -154,7 +154,7 @@ class TestTcpServer {
} }
private: private:
void OnConnect(grpc_endpoint* tcp, grpc_pollset* accepting_pollset, void OnConnect(grpc_endpoint* tcp, grpc_pollset* /*accepting_pollset*/,
grpc_tcp_server_acceptor* acceptor) { grpc_tcp_server_acceptor* acceptor) {
char* peer = grpc_endpoint_get_peer(tcp); char* peer = grpc_endpoint_get_peer(tcp);
gpr_log(GPR_INFO, "Got incoming connection! from %s", peer); gpr_log(GPR_INFO, "Got incoming connection! from %s", peer);

@ -61,9 +61,9 @@ class TestServerBuilderPlugin : public ServerBuilderPlugin {
} }
} }
void Finish(ServerInitializer* si) override { finish_is_called_ = true; } void Finish(ServerInitializer* /*si*/) override { finish_is_called_ = true; }
void ChangeArguments(const grpc::string& name, void* value) override { void ChangeArguments(const grpc::string& /*name*/, void* /*value*/) override {
change_arguments_is_called_ = true; change_arguments_is_called_ = true;
} }
@ -99,7 +99,7 @@ class InsertPluginServerBuilderOption : public ServerBuilderOption {
public: public:
InsertPluginServerBuilderOption() { register_service_ = false; } InsertPluginServerBuilderOption() { register_service_ = false; }
void UpdateArguments(ChannelArguments* arg) override {} void UpdateArguments(ChannelArguments* /*arg*/) override {}
void UpdatePlugins( void UpdatePlugins(
std::vector<std::unique_ptr<ServerBuilderPlugin>>* plugins) override { std::vector<std::unique_ptr<ServerBuilderPlugin>>* plugins) override {

@ -50,7 +50,7 @@ class ServiceImpl final : public ::grpc::testing::EchoTestService::Service {
ServiceImpl() : bidi_stream_count_(0), response_stream_count_(0) {} ServiceImpl() : bidi_stream_count_(0), response_stream_count_(0) {}
Status BidiStream( Status BidiStream(
ServerContext* context, ServerContext* /*context*/,
ServerReaderWriter<EchoResponse, EchoRequest>* stream) override { ServerReaderWriter<EchoResponse, EchoRequest>* stream) override {
bidi_stream_count_++; bidi_stream_count_++;
EchoRequest request; EchoRequest request;
@ -65,7 +65,8 @@ class ServiceImpl final : public ::grpc::testing::EchoTestService::Service {
return Status::OK; return Status::OK;
} }
Status ResponseStream(ServerContext* context, const EchoRequest* request, Status ResponseStream(ServerContext* /*context*/,
const EchoRequest* /*request*/,
ServerWriter<EchoResponse>* writer) override { ServerWriter<EchoResponse>* writer) override {
EchoResponse response; EchoResponse response;
response_stream_count_++; response_stream_count_++;

@ -147,7 +147,7 @@ class LoggingInterceptorFactory
// Test if SendMessage function family works as expected for sync/callback apis // Test if SendMessage function family works as expected for sync/callback apis
class SyncSendMessageTester : public experimental::Interceptor { class SyncSendMessageTester : public experimental::Interceptor {
public: public:
SyncSendMessageTester(experimental::ServerRpcInfo* info) {} SyncSendMessageTester(experimental::ServerRpcInfo* /*info*/) {}
void Intercept(experimental::InterceptorBatchMethods* methods) override { void Intercept(experimental::InterceptorBatchMethods* methods) override {
if (methods->QueryInterceptionHookPoint( if (methods->QueryInterceptionHookPoint(
@ -177,7 +177,7 @@ class SyncSendMessageTesterFactory
// Test if SendMessage function family works as expected for sync/callback apis // Test if SendMessage function family works as expected for sync/callback apis
class SyncSendMessageVerifier : public experimental::Interceptor { class SyncSendMessageVerifier : public experimental::Interceptor {
public: public:
SyncSendMessageVerifier(experimental::ServerRpcInfo* info) {} SyncSendMessageVerifier(experimental::ServerRpcInfo* /*info*/) {}
void Intercept(experimental::InterceptorBatchMethods* methods) override { void Intercept(experimental::InterceptorBatchMethods* methods) override {
if (methods->QueryInterceptionHookPoint( if (methods->QueryInterceptionHookPoint(

@ -46,8 +46,8 @@ class TestServiceImpl : public ::grpc::testing::EchoTestService::Service {
public: public:
explicit TestServiceImpl(gpr_event* ev) : ev_(ev) {} explicit TestServiceImpl(gpr_event* ev) : ev_(ev) {}
Status Echo(ServerContext* context, const EchoRequest* request, Status Echo(ServerContext* context, const EchoRequest* /*request*/,
EchoResponse* response) override { EchoResponse* /*response*/) override {
gpr_event_set(ev_, (void*)1); gpr_event_set(ev_, (void*)1);
while (!context->IsCancelled()) { while (!context->IsCancelled()) {
} }

@ -106,7 +106,7 @@ class TestServiceImpl : public ::grpc::testing::EchoTestService::Service {
// Only implement the one method we will be calling for brevity. // Only implement the one method we will be calling for brevity.
Status BidiStream( Status BidiStream(
ServerContext* context, ServerContext* /*context*/,
ServerReaderWriter<EchoResponse, EchoRequest>* stream) override { ServerReaderWriter<EchoResponse, EchoRequest>* stream) override {
EchoRequest request; EchoRequest request;
gpr_atm should_exit; gpr_atm should_exit;

@ -57,7 +57,7 @@ class TestServiceImpl : public ::grpc::testing::EchoTestService::Service {
public: public:
TestServiceImpl() {} TestServiceImpl() {}
Status Echo(ServerContext* context, const EchoRequest* request, Status Echo(ServerContext* /*context*/, const EchoRequest* request,
EchoResponse* response) override { EchoResponse* response) override {
response->set_message(request->message()); response->set_message(request->message());
return Status::OK; return Status::OK;

@ -423,7 +423,7 @@ class LrsServiceImpl : public LrsService {
: client_load_reporting_interval_seconds_( : client_load_reporting_interval_seconds_(
client_load_reporting_interval_seconds) {} client_load_reporting_interval_seconds) {}
Status StreamLoadStats(ServerContext* context, Stream* stream) override { Status StreamLoadStats(ServerContext* /*context*/, Stream* stream) override {
gpr_log(GPR_INFO, "LRS[%p]: StreamLoadStats starts", this); gpr_log(GPR_INFO, "LRS[%p]: StreamLoadStats starts", this);
// Read request. // Read request.
LoadStatsRequest request; LoadStatsRequest request;

Loading…
Cancel
Save