From d10a885922387c7237dc5d26ec4db8c1474a70cd Mon Sep 17 00:00:00 2001 From: makdharma <> Date: Mon, 12 Mar 2018 10:12:01 -0700 Subject: [PATCH] removed unnecessary "virtual" Removed unnecessary "virtual" keyword from CompletionQueue::Next. Reverted two files that no longer need to be changed. --- src/cpp/common/completion_queue_cc.cc | 6 ------ test/cpp/codegen/codegen_test_minimal.cc | 5 ----- 2 files changed, 11 deletions(-) diff --git a/src/cpp/common/completion_queue_cc.cc b/src/cpp/common/completion_queue_cc.cc index b3af25fbf95..6893201e2e3 100644 --- a/src/cpp/common/completion_queue_cc.cc +++ b/src/cpp/common/completion_queue_cc.cc @@ -50,12 +50,6 @@ void CompletionQueue::CompleteAvalanching() { } } -bool CompletionQueue::Next(void** tag, bool* ok) { - return (AsyncNextInternal(tag, ok, - g_core_codegen_interface->gpr_inf_future( - GPR_CLOCK_REALTIME)) != SHUTDOWN); -} - CompletionQueue::NextStatus CompletionQueue::AsyncNextInternal( void** tag, bool* ok, gpr_timespec deadline) { for (;;) { diff --git a/test/cpp/codegen/codegen_test_minimal.cc b/test/cpp/codegen/codegen_test_minimal.cc index a614848184f..d317ea31164 100644 --- a/test/cpp/codegen/codegen_test_minimal.cc +++ b/test/cpp/codegen/codegen_test_minimal.cc @@ -16,14 +16,9 @@ * */ -#include #include namespace grpc { - -// Unused implementation for the virtual "Next" method. -bool CompletionQueue::Next(void** tag, bool* ok) { return false; } - namespace { class CodegenTestMinimal : public ::testing::Test {};