Remove the racy check added in commit i74c14e5ac752edc7e1dc0aaf31abfd1153df1d0a.

This is potentially unsafe since checking the deadline involves more than 1 word
read.
pull/1196/head
Vijay Pai 10 years ago
parent cc6017bb08
commit cf1a7e03e7
  1. 4
      src/core/iomgr/alarm.c

@ -307,10 +307,6 @@ static int run_some_expired_alarms(gpr_mu *drop_mu, gpr_timespec now,
/* TODO(ctiller): verify that there are any alarms (atomically) here */
if (gpr_time_cmp(g_shard_queue[0]->min_deadline, now) >= 0) {
return 0;
}
if (gpr_mu_trylock(&g_checker_mu)) {
gpr_mu_lock(&g_mu);

Loading…
Cancel
Save