Fixed memory leak in Alarm's move assignment

2 years ago · cd4154f21d
parent 7b3977e9f1
commit cd4154f21d
1 changed files with 1 additions and 2 deletions
--- a/include/grpcpp/alarm.h
+++ b/include/grpcpp/alarm.h
@ -72,8 +72,7 @@ class Alarm : private grpc::internal::GrpcLibrary {
  /// Alarms are movable.
  Alarm(Alarm&& rhs) noexcept : alarm_(rhs.alarm_) { rhs.alarm_ = nullptr; }
  Alarm& operator=(Alarm&& rhs) noexcept {
-    alarm_ = rhs.alarm_;
+    std::swap(alarm_, rhs.alarm_);
    rhs.alarm_ = nullptr;
    return *this;
  }