Remove TCP transmit zerocopy shutdown when removing TCP endpoint from pollset. (#25782)

Previously, we disabled TCP transmit zerocopy and waited for all pending
completions when removing a TCP endpoint from a pollset. However, certain
transports may do this and then re-add the endpoint to a pollset, in which case
zerocopy is no longer active.

Instead, here we only shutdown zerocopy if the socket is being torn down.
reviewable/pr25653/r3
Arjun Roy 4 years ago committed by GitHub
parent afd2b354f2
commit ccbb2dd207
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 1
      src/core/lib/iomgr/tcp_posix.cc

@ -1639,7 +1639,6 @@ static void tcp_add_to_pollset_set(grpc_endpoint* ep,
static void tcp_delete_from_pollset_set(grpc_endpoint* ep,
grpc_pollset_set* pollset_set) {
grpc_tcp* tcp = reinterpret_cast<grpc_tcp*>(ep);
ZerocopyDisableAndWaitForRemaining(tcp);
grpc_pollset_set_del_fd(pollset_set, tcp->em_fd);
}

Loading…
Cancel
Save