From cbdcc5be7726803949e5f7003f882448c69cd2f8 Mon Sep 17 00:00:00 2001 From: Michael Lumish Date: Thu, 19 Nov 2020 13:57:37 -0800 Subject: [PATCH] Add target argument to Node examples --- examples/node/dynamic_codegen/greeter_client.js | 16 +++++++++++++--- examples/node/static_codegen/greeter_client.js | 15 ++++++++++++--- 2 files changed, 25 insertions(+), 6 deletions(-) diff --git a/examples/node/dynamic_codegen/greeter_client.js b/examples/node/dynamic_codegen/greeter_client.js index 849376b6a9e..c1274b11f3e 100644 --- a/examples/node/dynamic_codegen/greeter_client.js +++ b/examples/node/dynamic_codegen/greeter_client.js @@ -18,6 +18,7 @@ var PROTO_PATH = __dirname + '/../../protos/helloworld.proto'; +var parseArgs = require('minimist'); var grpc = require('@grpc/grpc-js'); var protoLoader = require('@grpc/proto-loader'); var packageDefinition = protoLoader.loadSync( @@ -31,11 +32,20 @@ var packageDefinition = protoLoader.loadSync( var hello_proto = grpc.loadPackageDefinition(packageDefinition).helloworld; function main() { - var client = new hello_proto.Greeter('localhost:50051', + var argv = parseArgs(process.argv.slice(2), { + string: 'target' + }); + var target; + if (argv.target) { + target = argv.target; + } else { + target = 'localhost:50051'; + } + var client = new hello_proto.Greeter(target, grpc.credentials.createInsecure()); var user; - if (process.argv.length >= 3) { - user = process.argv[2]; + if (argv._.length > 0) { + user = argv._[0]; } else { user = 'world'; } diff --git a/examples/node/static_codegen/greeter_client.js b/examples/node/static_codegen/greeter_client.js index 4fdc12b9f29..a647140131c 100644 --- a/examples/node/static_codegen/greeter_client.js +++ b/examples/node/static_codegen/greeter_client.js @@ -22,12 +22,21 @@ var services = require('./helloworld_grpc_pb'); var grpc = require('@grpc/grpc-js'); function main() { - var client = new services.GreeterClient('localhost:50051', + var argv = parseArgs(process.argv.slice(2), { + string: 'target' + }); + var target; + if (argv.target) { + target = argv.target; + } else { + target = 'localhost:50051'; + } + var client = new services.GreeterClient(target, grpc.credentials.createInsecure()); var request = new messages.HelloRequest(); var user; - if (process.argv.length >= 3) { - user = process.argv[2]; + if (argv._.length > 0) { + user = argv._[0]; } else { user = 'world'; }