libuv changes don't work with Electron

8 years ago · cb4b2b5d7d
parent 5a38f2e490
commit cb4b2b5d7d
2 changed files with 12 additions and 4 deletions
--- a/binding.gyp
+++ b/binding.gyp
@ -46,10 +46,14 @@
      'include'
    ],
    'defines': [
-      'GPR_BACKWARDS_COMPATIBILITY_MODE',
-      'GRPC_UV'
+      'GPR_BACKWARDS_COMPATIBILITY_MODE'
    ],
    'conditions': [
+      ['runtime=="node"', {
+        'defines': [
+          'GRPC_UV'
+        ]
+      }],
      # This is the condition for using boringssl
      ['OS=="win" or runtime=="electron"', {
        "include_dirs": [
--- a/templates/binding.gyp.template
+++ b/templates/binding.gyp.template
@ -48,10 +48,14 @@
        'include'
      ],
      'defines': [
-        'GPR_BACKWARDS_COMPATIBILITY_MODE',
-        'GRPC_UV'
+        'GPR_BACKWARDS_COMPATIBILITY_MODE'
      ],
      'conditions': [
+        ['runtime=="node"', {
+          'defines': [
+            'GRPC_UV'
+          ]
+        }],
        # This is the condition for using boringssl
        ['OS=="win" or runtime=="electron"', {
          "include_dirs": [