From cad2782c6f64b93f2389d8126837102fb57bcdf0 Mon Sep 17 00:00:00 2001 From: Jan Tattermusch Date: Fri, 20 Feb 2015 17:14:30 -0800 Subject: [PATCH] Forgot to commit some files --- tools/dockerfile/grpc_node_base/Dockerfile | 2 ++ tools/dockerfile/grpc_ruby_base/Dockerfile | 5 +++++ 2 files changed, 7 insertions(+) diff --git a/tools/dockerfile/grpc_node_base/Dockerfile b/tools/dockerfile/grpc_node_base/Dockerfile index 20efde98add..e14e03143f7 100644 --- a/tools/dockerfile/grpc_node_base/Dockerfile +++ b/tools/dockerfile/grpc_node_base/Dockerfile @@ -15,6 +15,8 @@ RUN cd /var/local/git/grpc && \ git pull --recurse-submodules && \ git submodule update --init --recursive +# TODO: pre-building seems unnecessary, because we need to run make clean +# anyway to prevent build from crashing if header files are added/removed. # Build the C core RUN make static_c shared_c -j12 -C /var/local/git/grpc diff --git a/tools/dockerfile/grpc_ruby_base/Dockerfile b/tools/dockerfile/grpc_ruby_base/Dockerfile index a3a80daf9be..0d872069d70 100644 --- a/tools/dockerfile/grpc_ruby_base/Dockerfile +++ b/tools/dockerfile/grpc_ruby_base/Dockerfile @@ -54,5 +54,10 @@ RUN cd /var/local/git/grpc/third_party/protobuf && \ ./configure --prefix=/usr && \ make -j12 && make check && make install && make clean +# TODO: pre-building seems unnecessary, because we need to run make clean +# anyway to prevent build from crashing if header files are added/removed. # Build the C core RUN make static_c shared_c -j12 -C /var/local/git/grpc + +# Define the default command. +CMD ["bash"]