Remove `include/grpcpp/impl/codegen/completion_queue_tag.h` (#31320)

* Remove `include/grpcpp/impl/codegen/completion_queue_tag.h`

* Automated change: Fix sanity tests
pull/31673/head^2
Cheng-Yu Chung 2 years ago committed by GitHub
parent 589fee0530
commit c91c2fbd1a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 1
      BUILD
  2. 2
      CMakeLists.txt
  3. 2
      build_autogenerated.yaml
  4. 1
      gRPC-C++.podspec
  5. 2
      include/grpcpp/alarm.h
  6. 2
      include/grpcpp/completion_queue.h
  7. 2
      include/grpcpp/impl/call_op_set.h
  8. 2
      include/grpcpp/impl/call_op_set_interface.h
  9. 33
      include/grpcpp/impl/codegen/completion_queue_tag.h
  10. 2
      include/grpcpp/impl/codegen/server_interface.h
  11. 54
      include/grpcpp/impl/completion_queue_tag.h
  12. 2
      include/grpcpp/server_context.h
  13. 2
      include/grpcpp/support/callback_common.h
  14. 2
      src/cpp/client/channel_cc.cc
  15. 2
      src/cpp/common/alarm.cc
  16. 2
      src/cpp/common/completion_queue_cc.cc
  17. 2
      src/cpp/server/server_cc.cc
  18. 2
      src/cpp/server/server_context.cc
  19. 1
      tools/doxygen/Doxyfile.c++
  20. 1
      tools/doxygen/Doxyfile.c++.internal

@ -341,6 +341,7 @@ GRPCXX_PUBLIC_HDRS = [
"include/grpcpp/impl/channel_interface.h",
"include/grpcpp/impl/client_unary_call.h",
"include/grpcpp/impl/codegen/core_codegen.h",
"include/grpcpp/impl/completion_queue_tag.h",
"include/grpcpp/impl/grpc_library.h",
"include/grpcpp/impl/method_handler_impl.h",
"include/grpcpp/impl/rpc_method.h",

2
CMakeLists.txt generated

@ -3448,6 +3448,7 @@ foreach(_hdr
include/grpcpp/impl/codegen/sync.h
include/grpcpp/impl/codegen/sync_stream.h
include/grpcpp/impl/codegen/time.h
include/grpcpp/impl/completion_queue_tag.h
include/grpcpp/impl/grpc_library.h
include/grpcpp/impl/method_handler_impl.h
include/grpcpp/impl/rpc_method.h
@ -4133,6 +4134,7 @@ foreach(_hdr
include/grpcpp/impl/codegen/sync.h
include/grpcpp/impl/codegen/sync_stream.h
include/grpcpp/impl/codegen/time.h
include/grpcpp/impl/completion_queue_tag.h
include/grpcpp/impl/grpc_library.h
include/grpcpp/impl/method_handler_impl.h
include/grpcpp/impl/rpc_method.h

@ -2826,6 +2826,7 @@ libs:
- include/grpcpp/impl/codegen/sync.h
- include/grpcpp/impl/codegen/sync_stream.h
- include/grpcpp/impl/codegen/time.h
- include/grpcpp/impl/completion_queue_tag.h
- include/grpcpp/impl/grpc_library.h
- include/grpcpp/impl/method_handler_impl.h
- include/grpcpp/impl/rpc_method.h
@ -3242,6 +3243,7 @@ libs:
- include/grpcpp/impl/codegen/sync.h
- include/grpcpp/impl/codegen/sync_stream.h
- include/grpcpp/impl/codegen/time.h
- include/grpcpp/impl/completion_queue_tag.h
- include/grpcpp/impl/grpc_library.h
- include/grpcpp/impl/method_handler_impl.h
- include/grpcpp/impl/rpc_method.h

1
gRPC-C++.podspec generated

@ -146,6 +146,7 @@ Pod::Spec.new do |s|
'include/grpcpp/impl/codegen/sync.h',
'include/grpcpp/impl/codegen/sync_stream.h',
'include/grpcpp/impl/codegen/time.h',
'include/grpcpp/impl/completion_queue_tag.h',
'include/grpcpp/impl/grpc_library.h',
'include/grpcpp/impl/method_handler_impl.h',
'include/grpcpp/impl/rpc_method.h',

@ -25,7 +25,7 @@
#include <grpc/grpc.h>
#include <grpcpp/completion_queue.h>
#include <grpcpp/impl/codegen/completion_queue_tag.h>
#include <grpcpp/impl/completion_queue_tag.h>
#include <grpcpp/impl/grpc_library.h>
#include <grpcpp/support/time.h>

@ -35,12 +35,12 @@
#include <list>
#include <grpc/impl/codegen/atm.h>
#include <grpcpp/impl/codegen/completion_queue_tag.h>
#include <grpcpp/impl/codegen/core_codegen_interface.h>
#include <grpcpp/impl/codegen/rpc_service_method.h>
#include <grpcpp/impl/codegen/status.h>
#include <grpcpp/impl/codegen/sync.h>
#include <grpcpp/impl/codegen/time.h>
#include <grpcpp/impl/completion_queue_tag.h>
#include <grpcpp/impl/grpc_library.h>
struct grpc_completion_queue;

@ -31,10 +31,10 @@
#include <grpcpp/impl/call.h>
#include <grpcpp/impl/call_hook.h>
#include <grpcpp/impl/call_op_set_interface.h>
#include <grpcpp/impl/codegen/completion_queue_tag.h>
#include <grpcpp/impl/codegen/core_codegen_interface.h>
#include <grpcpp/impl/codegen/intercepted_channel.h>
#include <grpcpp/impl/codegen/interceptor_common.h>
#include <grpcpp/impl/completion_queue_tag.h>
#include <grpcpp/impl/serialization_traits.h>
#include <grpcpp/support/byte_buffer.h>
#include <grpcpp/support/config.h>

@ -21,7 +21,7 @@
// IWYU pragma: private
#include <grpcpp/impl/codegen/completion_queue_tag.h>
#include <grpcpp/impl/completion_queue_tag.h>
namespace grpc {
namespace internal {

@ -21,36 +21,7 @@
// IWYU pragma: private
namespace grpc {
namespace internal {
/// An interface allowing implementors to process and filter event tags.
class CompletionQueueTag {
public:
virtual ~CompletionQueueTag() {}
/// FinalizeResult must be called before informing user code that the
/// operation bound to the underlying core completion queue tag has
/// completed. In practice, this means:
///
/// 1. For the sync API - before returning from Pluck
/// 2. For the CQ-based async API - before returning from Next
/// 3. For the callback-based API - before invoking the user callback
///
/// This is the method that translates from core-side tag/status to
/// C++ API-observable tag/status.
///
/// The return value is the status of the operation (returning status is the
/// general behavior of this function). If this function returns false, the
/// tag is dropped and not returned from the completion queue: this concept is
/// for events that are observed at core but not requested by the user
/// application (e.g., server shutdown, for server unimplemented method
/// responses, or for cases where a server-side RPC doesn't have a completion
/// notification registered using AsyncNotifyWhenDone)
virtual bool FinalizeResult(void** tag, bool* status) = 0;
};
} // namespace internal
} // namespace grpc
/// TODO(chengyuc): Remove this file after solving compatibility.
#include <grpcpp/impl/completion_queue_tag.h>
#endif // GRPCPP_IMPL_CODEGEN_COMPLETION_QUEUE_TAG_H

@ -26,11 +26,11 @@
#include <grpc/impl/codegen/grpc_types.h>
#include <grpcpp/impl/codegen/call.h>
#include <grpcpp/impl/codegen/call_hook.h>
#include <grpcpp/impl/codegen/completion_queue_tag.h>
#include <grpcpp/impl/codegen/core_codegen_interface.h>
#include <grpcpp/impl/codegen/interceptor_common.h>
#include <grpcpp/impl/codegen/rpc_service_method.h>
#include <grpcpp/impl/codegen/server_context.h>
#include <grpcpp/impl/completion_queue_tag.h>
#include <grpcpp/support/byte_buffer.h>
namespace grpc {

@ -0,0 +1,54 @@
/*
*
* Copyright 2015 gRPC authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
*/
#ifndef GRPCPP_IMPL_COMPLETION_QUEUE_TAG_H
#define GRPCPP_IMPL_COMPLETION_QUEUE_TAG_H
namespace grpc {
namespace internal {
/// An interface allowing implementors to process and filter event tags.
class CompletionQueueTag {
public:
virtual ~CompletionQueueTag() {}
/// FinalizeResult must be called before informing user code that the
/// operation bound to the underlying core completion queue tag has
/// completed. In practice, this means:
///
/// 1. For the sync API - before returning from Pluck
/// 2. For the CQ-based async API - before returning from Next
/// 3. For the callback-based API - before invoking the user callback
///
/// This is the method that translates from core-side tag/status to
/// C++ API-observable tag/status.
///
/// The return value is the status of the operation (returning status is the
/// general behavior of this function). If this function returns false, the
/// tag is dropped and not returned from the completion queue: this concept is
/// for events that are observed at core but not requested by the user
/// application (e.g., server shutdown, for server unimplemented method
/// responses, or for cases where a server-side RPC doesn't have a completion
/// notification registered using AsyncNotifyWhenDone)
virtual bool FinalizeResult(void** tag, bool* status) = 0;
};
} // namespace internal
} // namespace grpc
#endif // GRPCPP_IMPL_COMPLETION_QUEUE_TAG_H

@ -31,9 +31,9 @@
#include <grpc/impl/codegen/compression_types.h>
#include <grpcpp/impl/call.h>
#include <grpcpp/impl/call_op_set.h>
#include <grpcpp/impl/codegen/completion_queue_tag.h>
#include <grpcpp/impl/codegen/create_auth_context.h>
#include <grpcpp/impl/codegen/metadata_map.h>
#include <grpcpp/impl/completion_queue_tag.h>
#include <grpcpp/impl/rpc_service_method.h>
#include <grpcpp/security/auth_context.h>
#include <grpcpp/support/callback_common.h>

@ -24,8 +24,8 @@
#include <grpc/impl/codegen/grpc_types.h>
#include <grpcpp/impl/call.h>
#include <grpcpp/impl/codegen/channel_interface.h>
#include <grpcpp/impl/codegen/completion_queue_tag.h>
#include <grpcpp/impl/codegen/core_codegen_interface.h>
#include <grpcpp/impl/completion_queue_tag.h>
#include <grpcpp/support/config.h>
#include <grpcpp/support/status.h>

@ -35,9 +35,9 @@
#include <grpcpp/completion_queue.h>
#include <grpcpp/impl/call.h>
#include <grpcpp/impl/call_op_set_interface.h>
#include <grpcpp/impl/codegen/completion_queue_tag.h>
#include <grpcpp/impl/codegen/core_codegen_interface.h>
#include <grpcpp/impl/codegen/sync.h>
#include <grpcpp/impl/completion_queue_tag.h>
#include <grpcpp/impl/grpc_library.h>
#include <grpcpp/impl/rpc_method.h>
#include <grpcpp/support/client_interceptor.h>

@ -26,7 +26,7 @@
#include <grpc/support/sync.h>
#include <grpcpp/alarm.h>
#include <grpcpp/completion_queue.h>
#include <grpcpp/impl/codegen/completion_queue_tag.h>
#include <grpcpp/impl/completion_queue_tag.h>
#include <grpcpp/impl/grpc_library.h>
#include "src/core/lib/gprpp/time.h"

@ -27,7 +27,7 @@
#include <grpc/support/sync.h>
#include <grpc/support/time.h>
#include <grpcpp/completion_queue.h>
#include <grpcpp/impl/codegen/completion_queue_tag.h>
#include <grpcpp/impl/completion_queue_tag.h>
#include <grpcpp/impl/grpc_library.h>
#include "src/core/lib/gpr/useful.h"

@ -45,12 +45,12 @@
#include <grpcpp/impl/call.h>
#include <grpcpp/impl/call_op_set.h>
#include <grpcpp/impl/call_op_set_interface.h>
#include <grpcpp/impl/codegen/completion_queue_tag.h>
#include <grpcpp/impl/codegen/interceptor_common.h>
#include <grpcpp/impl/codegen/metadata_map.h>
#include <grpcpp/impl/codegen/server_callback_handlers.h>
#include <grpcpp/impl/codegen/server_interface.h>
#include <grpcpp/impl/codegen/sync.h>
#include <grpcpp/impl/completion_queue_tag.h>
#include <grpcpp/impl/grpc_library.h>
#include <grpcpp/impl/rpc_method.h>
#include <grpcpp/impl/rpc_service_method.h>

@ -44,9 +44,9 @@
#include <grpcpp/impl/call.h>
#include <grpcpp/impl/call_op_set.h>
#include <grpcpp/impl/call_op_set_interface.h>
#include <grpcpp/impl/codegen/completion_queue_tag.h>
#include <grpcpp/impl/codegen/interceptor_common.h>
#include <grpcpp/impl/codegen/metadata_map.h>
#include <grpcpp/impl/completion_queue_tag.h>
#include <grpcpp/impl/grpc_library.h>
#include <grpcpp/server_context.h>
#include <grpcpp/support/callback_common.h>

@ -1010,6 +1010,7 @@ include/grpcpp/impl/codegen/stub_options.h \
include/grpcpp/impl/codegen/sync.h \
include/grpcpp/impl/codegen/sync_stream.h \
include/grpcpp/impl/codegen/time.h \
include/grpcpp/impl/completion_queue_tag.h \
include/grpcpp/impl/grpc_library.h \
include/grpcpp/impl/method_handler_impl.h \
include/grpcpp/impl/rpc_method.h \

@ -1010,6 +1010,7 @@ include/grpcpp/impl/codegen/stub_options.h \
include/grpcpp/impl/codegen/sync.h \
include/grpcpp/impl/codegen/sync_stream.h \
include/grpcpp/impl/codegen/time.h \
include/grpcpp/impl/completion_queue_tag.h \
include/grpcpp/impl/grpc_library.h \
include/grpcpp/impl/method_handler_impl.h \
include/grpcpp/impl/rpc_method.h \

Loading…
Cancel
Save